commit c4deee49a3ec42b7fe83c82f750539b36aae1d3f
author Peter Boström <pbos@webrtc.org> Tue May 03 17:59:59 2016
committer Peter Boström <pbos@webrtc.org> Tue May 03 18:00:05 2016
tree 9061483bc78e326dbea43f6641f6771248df48fe
parent c8fe991a3df41ee3f6e9a9154426a6ee46619977

Use RC_TIMESTAMP_MODE for OpenH264.

Performs rate control based on timestamp deltas instead of announced
frame rate.

BUG=webrtc:5855
R=hbos@webrtc.org

Review URL: https://codereview.webrtc.org/1945763002 .

Cr-Commit-Position: refs/heads/master@{#12611}

webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
index 18eccb2..a6325a9 100644
--- a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
+++ b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
@@ -224,7 +224,7 @@
   init_params.iTargetBitrate = codec_settings_.targetBitrate * 1000;
   init_params.iMaxBitrate = codec_settings_.maxBitrate * 1000;
   // Rate Control mode
-  init_params.iRCMode = RC_BITRATE_MODE;
+  init_params.iRCMode = RC_TIMESTAMP_MODE;
   init_params.fMaxFrameRate = static_cast<float>(codec_settings_.maxFramerate);
 
   // The following parameters are extension parameters (they're in SEncParamExt,
@@ -343,21 +343,13 @@
     return WEBRTC_VIDEO_CODEC_ERR_SIZE;
   }
 
-  bool force_key_frame = false;
-  if (frame_types != nullptr) {
-    // We only support a single stream.
-    RTC_DCHECK_EQ(frame_types->size(), static_cast<size_t>(1));
-    // Skip frame?
-    if ((*frame_types)[0] == kEmptyFrame) {
-      return WEBRTC_VIDEO_CODEC_OK;
-    }
-    // Force key frame?
-    force_key_frame = (*frame_types)[0] == kVideoFrameKey;
-  }
-  if (force_key_frame) {
+  RTC_DCHECK(frame_types != nullptr);
+  // We only support a single stream.
+  RTC_DCHECK_EQ(1u, frame_types->size());
+  // Force key frame?
+  if ((*frame_types)[0] == kVideoFrameKey) {
     // API doc says ForceIntraFrame(false) does nothing, but calling this
     // function forces a key frame regardless of the |bIDR| argument's value.
-    // (If every frame is a key frame we get lag/delays.)
     openh264_encoder_->ForceIntraFrame(true);
   }