commit c54f6722cefb75fdb7be6948d3326a2ad22b23da
author Victor Boivie <boivie@webrtc.org> Tue Apr 13 09:23:16 2021
committer Commit Bot <commit-bot@chromium.org> Wed Apr 14 07:54:06 2021
tree 752564a5c0a1da03d0ba828342b8a88db0e7fcec
parent 04985198442d4e2193cc4cbf988152554d5d3eb0

dcsctp: Fix post-review comments for DataTracker

These are some fixes that were added after submission of
https://webrtc-review.googlesource.com/c/src/+/213664

Mainly:

 * Don't accept TSNs that have a too large difference from expected
 * Renaming of member variable (to confirm to style guidelines)

Bug: webrtc:12614
Change-Id: I06e11ab2acf5d307b68c3cbc135fde2c038ee690
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215070
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33721}

net/dcsctp/rx/data_tracker_test.cc

diff --git a/net/dcsctp/rx/data_tracker_test.cc b/net/dcsctp/rx/data_tracker_test.cc
index 1bad807..d714b0b 100644
--- a/net/dcsctp/rx/data_tracker_test.cc
+++ b/net/dcsctp/rx/data_tracker_test.cc
@@ -27,6 +27,7 @@
 using ::testing::IsEmpty;
 
 constexpr size_t kArwnd = 10000;
+constexpr TSN kInitialTSN(11);
 
 class DataTrackerTest : public testing::Test {
  protected:
@@ -37,7 +38,7 @@
             "test/delayed_ack",
             []() { return absl::nullopt; },
             TimerOptions(DurationMs(0)))),
-        buf_("log: ", timer_.get(), /*peer_initial_tsn=*/TSN(11)) {}
+        buf_("log: ", timer_.get(), kInitialTSN) {}
 
   void Observer(std::initializer_list<uint32_t> tsns) {
     for (const uint32_t tsn : tsns) {
@@ -205,5 +206,29 @@
 
   EXPECT_TRUE(buf_.ShouldSendAck());
 }
+
+TEST_F(DataTrackerTest, WillAcceptValidTSNs) {
+  // The initial TSN is always one more than the last, which is our base.
+  TSN last_tsn = TSN(*kInitialTSN - 1);
+  int limit = static_cast<int>(DataTracker::kMaxAcceptedOutstandingFragments);
+
+  for (int i = -limit; i <= limit; ++i) {
+    EXPECT_TRUE(buf_.IsTSNValid(TSN(*last_tsn + i)));
+  }
+}
+
+TEST_F(DataTrackerTest, WillNotAcceptInvalidTSNs) {
+  // The initial TSN is always one more than the last, which is our base.
+  TSN last_tsn = TSN(*kInitialTSN - 1);
+
+  size_t limit = DataTracker::kMaxAcceptedOutstandingFragments;
+  EXPECT_FALSE(buf_.IsTSNValid(TSN(*last_tsn + limit + 1)));
+  EXPECT_FALSE(buf_.IsTSNValid(TSN(*last_tsn - (limit + 1))));
+  EXPECT_FALSE(buf_.IsTSNValid(TSN(*last_tsn + 65536)));
+  EXPECT_FALSE(buf_.IsTSNValid(TSN(*last_tsn - 65536)));
+  EXPECT_FALSE(buf_.IsTSNValid(TSN(*last_tsn + 0x8000000)));
+  EXPECT_FALSE(buf_.IsTSNValid(TSN(*last_tsn - 0x8000000)));
+}
+
 }  // namespace
 }  // namespace dcsctp