commit cfc79174f2f153c0e19b4fa6fcdbb84a1c7aec02
author Rasmus Brandt <brandtr@webrtc.org> Fri May 20 12:55:32 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 25 07:02:39 2022
tree 8dbc17ad684bd0338134841a17d1fb54e942b92d
parent 02d65d7ec5106fe807536bc8f561ec6aca211d4d

Remove unused FlexfecReceiveStream::Stats struct

Bug: webrtc:14109
Change-Id: Ie06c267c15b21eff15803ead11b6deb661d17523
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262944
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36996}

call/flexfec_receive_stream.h

diff --git a/call/flexfec_receive_stream.h b/call/flexfec_receive_stream.h
index 31aa99d..b54eadd 100644
--- a/call/flexfec_receive_stream.h
+++ b/call/flexfec_receive_stream.h
@@ -29,13 +29,6 @@
  public:
   ~FlexfecReceiveStream() override = default;
 
-  struct Stats {
-    std::string ToString(int64_t time_ms) const;
-
-    // TODO(brandtr): Add appropriate stats here.
-    int flexfec_bitrate_bps;
-  };
-
   struct Config {
     explicit Config(Transport* rtcp_send_transport);
     Config(const Config&);
@@ -66,8 +59,6 @@
     // Transport for outgoing RTCP packets.
     Transport* rtcp_send_transport = nullptr;
   };
-
-  virtual Stats GetStats() const = 0;
 };
 
 }  // namespace webrtc

call/flexfec_receive_stream_impl.cc

diff --git a/call/flexfec_receive_stream_impl.cc b/call/flexfec_receive_stream_impl.cc
index 59add82..90bb3f3 100644
--- a/call/flexfec_receive_stream_impl.cc
+++ b/call/flexfec_receive_stream_impl.cc
@@ -31,14 +31,6 @@
 
 namespace webrtc {
 
-std::string FlexfecReceiveStream::Stats::ToString(int64_t time_ms) const {
-  char buf[1024];
-  rtc::SimpleStringBuilder ss(buf);
-  ss << "FlexfecReceiveStream stats: " << time_ms
-     << ", {flexfec_bitrate_bps: " << flexfec_bitrate_bps << "}";
-  return ss.str();
-}
-
 std::string FlexfecReceiveStream::Config::ToString() const {
   char buf[1024];
   rtc::SimpleStringBuilder ss(buf);
@@ -196,12 +188,6 @@
   }
 }
 
-// TODO(brandtr): Implement this member function when we have designed the
-// stats for FlexFEC.
-FlexfecReceiveStreamImpl::Stats FlexfecReceiveStreamImpl::GetStats() const {
-  return FlexfecReceiveStream::Stats();
-}
-
 void FlexfecReceiveStreamImpl::SetRtpExtensions(
     std::vector<RtpExtension> extensions) {
   RTC_DCHECK_RUN_ON(&packet_sequence_checker_);

call/flexfec_receive_stream_impl.h

diff --git a/call/flexfec_receive_stream_impl.h b/call/flexfec_receive_stream_impl.h
index 48edf09..5bfe5ca 100644
--- a/call/flexfec_receive_stream_impl.h
+++ b/call/flexfec_receive_stream_impl.h
@@ -55,9 +55,6 @@
 
   // RtpPacketSinkInterface.
   void OnRtpPacket(const RtpPacketReceived& packet) override;
-
-  Stats GetStats() const override;
-
   // ReceiveStreamInterface impl.
   void SetRtpExtensions(std::vector<RtpExtension> extensions) override;
   RtpHeaderExtensionMap GetRtpExtensionMap() const override;

media/engine/fake_webrtc_call.cc

diff --git a/media/engine/fake_webrtc_call.cc b/media/engine/fake_webrtc_call.cc
index 4558119..b7ffd0f 100644
--- a/media/engine/fake_webrtc_call.cc
+++ b/media/engine/fake_webrtc_call.cc
@@ -427,11 +427,6 @@
   return config_;
 }
 
-// TODO(brandtr): Implement when the stats have been designed.
-webrtc::FlexfecReceiveStream::Stats FakeFlexfecReceiveStream::GetStats() const {
-  return webrtc::FlexfecReceiveStream::Stats();
-}
-
 void FakeFlexfecReceiveStream::OnRtpPacket(const webrtc::RtpPacketReceived&) {
   RTC_DCHECK_NOTREACHED() << "Not implemented.";
 }

media/engine/fake_webrtc_call.h

diff --git a/media/engine/fake_webrtc_call.h b/media/engine/fake_webrtc_call.h
index 3c45829..8dca0dd 100644
--- a/media/engine/fake_webrtc_call.h
+++ b/media/engine/fake_webrtc_call.h
@@ -316,8 +316,6 @@
   uint32_t remote_ssrc() const { return config_.rtp.remote_ssrc; }
 
  private:
-  webrtc::FlexfecReceiveStream::Stats GetStats() const override;
-
   void OnRtpPacket(const webrtc::RtpPacketReceived& packet) override;
 
   webrtc::FlexfecReceiveStream::Config config_;