| commit | d6b4819e4a161ebf1e723c13e972d1564ed71348 | [log] [tgz] |
|---|---|---|
| author | Karl Wiberg <kwiberg@webrtc.org> | Mon Oct 16 21:01:06 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 16 21:37:14 2017 |
| tree | ca7e5324d10ab2a4ccd9274ec4c45cd9df956848 | |
| parent | b06b358207054de346351e3bd3180db6fff0bf04 [diff] |
PeerConnection::StartRtcEventLog: Improve callback memory safety By having a unique_ptr own the callback data instead of a raw pointer, the compiler helps us ensure that it's destroyed exactly once, and never used after being destroyed. (This made the callback object move-only, so I had to add support for move-only callbacks to rtc::Thread::Invoke().) BUG=webrtc:8111 Change-Id: Ia0804e4662e63e91e5cee18ecc3f38d2cfe8a26b Reviewed-on: https://webrtc-review.googlesource.com/10812 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20317}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.