Fix potential UAF in StunDictionaryWriter::CreateDelta + heap exhaustion in StunDictionaryView::ApplyDelta

1) The UAF is possible if Write used Set + Delete in same Delta,
when later cleaning the delta (in ApplyDeltaAck) the state was
left inconsistently so that subsequent CreateDelta could experience
UAF. It is theoretically possible that an actual WebRTC program could do
this, but I'm quite certain we currently *dont* use Delete.

2) The heap exhaustion in StunDictionaryView::ApplyDelta after
crafting a malicious delta. This is not possible to do with existing
code, but obviously an attacker could it learning about the ice
ufra/passwd.

BUG=b/513584807,b/513584726

Change-Id: Ic286ad4a7cc6c127fdcd3359505898a36eabdfee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/474600
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#47777}
2 files changed
tree: 5a1e8f1407abeebc061f51634e103ab7999a5d40
  1. .agents/
  2. agents/
  3. api/
  4. audio/
  5. build_overrides/
  6. call/
  7. common_audio/
  8. common_video/
  9. data/
  10. docs/
  11. examples/
  12. experiments/
  13. g3doc/
  14. infra/
  15. logging/
  16. media/
  17. modules/
  18. net/
  19. p2p/
  20. pc/
  21. resources/
  22. rtc_base/
  23. rtc_tools/
  24. rust/
  25. sdk/
  26. stats/
  27. system_wrappers/
  28. test/
  29. tools_webrtc/
  30. video/
  31. .clang-format
  32. .clang-tidy
  33. .git-blame-ignore-revs
  34. .gitignore
  35. .gn
  36. .mailmap
  37. .rustfmt.toml
  38. .style.yapf
  39. .vpython3
  40. .yapfignore
  41. AUTHORS
  42. BUILD.gn
  43. CODE_OF_CONDUCT.md
  44. codereview.settings
  45. DEPS
  46. DIR_METADATA
  47. ENG_REVIEW_OWNERS
  48. GEMINI.md
  49. LICENSE
  50. license_template.txt
  51. native-api.md
  52. OWNERS
  53. OWNERS_INFRA
  54. PATENTS
  55. PRESUBMIT.py
  56. presubmit_test.py
  57. presubmit_test_mocks.py
  58. pylintrc
  59. pylintrc_old_style
  60. README.chromium
  61. README.md
  62. unsafe_buffers_paths.txt
  63. WATCHLISTS
  64. webrtc.gni
  65. webrtc_lib_link_test.cc
  66. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info