| commit | eec79a071a1a82b8769d7496d7dea21fef013c5a | [log] [tgz] |
|---|---|---|
| author | Jonas Oreland <jonaso@webrtc.org> | Wed Mar 05 06:39:47 2025 |
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 05 07:24:11 2025 |
| tree | 17dda6de8d440b09974e11137e7a4dc052f332a6 | |
| parent | b3373d8697feb4595f11da128bf544e654096659 [diff] |
dtls-in-stun: Only read IceConfig.dtls_handshake_in_stun in 1 place. This patch fixes 2 problems, that both stem from the same root, the the code had scattered checking IceConfig.dtls_handshake_in_stun but that value was not updated when we discovered that remote peer does not support piggy backing, "restart". the patch modifies the code so that the IceConfig.dtls_handshake_in_stun is only checked during DtlsTransport::SetupDtls. The problems fixed are: 1) P2PTransportChannel correctly (set/does not set) Connection::RegisterDtlsPiggyback based on the existing dtls_stun_piggyback_callbacks_.empty() (that is reset when we detect that peer does not support piggybacking) rather than on config which is unchanged. 2) The timeout was not set properly during "restart", properly == the value based upon ice rtt, but was still using the "infinitely high" value for piggybacking. This is tested with the DtlsTransportVersionTest which now runs (optionally) with dtls-in-stun piggybacking. BUG=webrtc:367395350 Change-Id: Ib511bcd1d3371a2132cefe26a3c49372208735ac Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/379760 Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Auto-Submit: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44044}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.