commit feea82fad5d472cf787c54455f147d86b219196f
author Per K <perkj@webrtc.org> Mon Jun 17 15:09:47 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 17 15:39:20 2024
tree 198cc6e97d3cdd3d3f6d25e8e47b97ffe5635c0a
parent 6948d84f63fe2878d6e7c6f01679f0d514406623

Fix issue with SchedulableNetworkBehavior::UpdateConfigAndReschedule returning negative delay

If the task queue is blocked, there is a risk that delay becomes negative. Therefore, use max of calculated time to next schedule and 0.

Bug: webrtc:42224804
Change-Id: Ibae9000192d5042cf62b46d93e8364b58dae0d82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/354880
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Auto-Submit: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42501}

test/network/schedulable_network_behavior.cc

diff --git a/test/network/schedulable_network_behavior.cc b/test/network/schedulable_network_behavior.cc
index e64e7bd..a3291d0 100644
--- a/test/network/schedulable_network_behavior.cc
+++ b/test/network/schedulable_network_behavior.cc
@@ -117,9 +117,10 @@
   webrtc::TimeDelta time_since_first_sent_packet =
       reschedule_time - first_send_time_;
   if (next_schedule_index_ != 0) {
-    delay = webrtc::TimeDelta::Millis(schedule_.item()[next_schedule_index_]
-                                          .time_since_first_sent_packet_ms()) -
-            (time_since_first_sent_packet - wrap_time_delta_);
+    delay = std::max(TimeDelta::Millis(schedule_.item()[next_schedule_index_]
+                                           .time_since_first_sent_packet_ms()) -
+                         (time_since_first_sent_packet - wrap_time_delta_),
+                     TimeDelta::Zero());
   } else if (!schedule_.has_repeat_schedule_after_last_ms()) {
     // No more schedule items.
     schedule_task_.Stop();