commit 8c4d7ff6bffdea5c4d752f6372f0361e3d71d6d6
author Rasmus Brandt <brandtr@webrtc.org> Thu Jan 15 08:52:14 2026
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 15 12:11:00 2026
tree 1dfaf1dc2f33fd2f48001d35d778e948b20437c9
parent 0ce7f03d0cc28f8ab39250482450476a34c06e73

Reland "Log RTX OSN by decentralizing packet event logging to streams."

This reverts commit 4c29ebeb35bde8b2d164e5a7c34d9dfa67faba14.

Reason for reland: Temporary constructor signature was extended, to fix
downstream failures.

Original change's description:
> Revert "Log RTX OSN by decentralizing packet event logging to streams."
>
> This reverts commit 7d3af2ee95f292d148cf606f17a8129f8e7177b0.
>
> Reason for revert: Breaks downstream.
>
> Original change's description:
> > Log RTX OSN by decentralizing packet event logging to streams.
> >
> > This change decentralizes the logging of `RtcEventRtpPacketIncoming` to
> > the streams, to allow logging of RTX original sequence number (OSN) for
> > valid RTX streams.
> >
> > Why not keep logging centralized? We tried that in
> > https://webrtc-review.googlesource.com/c/src/+/434300, but that solution
> > turned out to be non-ideal: 1) it is complicated and hacky [duplicating
> > SSRC demuxing and RTX decapsulation], 2) it is not safe [we cannot
> > guarantee that the first two bytes are indeed _always_ RTX OSNs]
> >
> > This decentralized logging solution is neither complicated/hacky nor
> > unsafe. It does however have the drawback that a single log call is
> > replaced by one of five calls (one per stream type + undemuxable). So
> > there is a risk that future refactorings might break the logging. We
> > protect against that with a set of tests.
> >
> > Bug: b/305890678, b/423646186
> > Change-Id: Ic97a954d277b7088886bd95230e9b93ebd4f41c6
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/432440
> > Reviewed-by: Björn Terelius <terelius@webrtc.org>
> > Reviewed-by: Erik Språng <sprang@webrtc.org>
> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> > Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#46664}
>
> Bug: b/305890678, b/423646186
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Iaae182baed67ec7f3c97e2dc4212cd684411967a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/442301
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#46667}

Bug: b/305890678, b/423646186
Change-Id: Ie9e4a69d8f587fbc2eb8ca234f35ab44fd20cbcf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/442320
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#46670}