Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include <memory> |
| 12 | #include <vector> |
| 13 | |
Karl Wiberg | 1b0eae3 | 2017-10-17 12:48:54 | [diff] [blame] | 14 | #include "api/audio_codecs/builtin_audio_decoder_factory.h" |
| 15 | #include "api/audio_codecs/builtin_audio_encoder_factory.h" |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 16 | #include "api/jsep.h" |
| 17 | #include "api/mediastreaminterface.h" |
| 18 | #include "api/peerconnectioninterface.h" |
| 19 | #include "pc/mediastream.h" |
| 20 | #include "pc/mediastreamtrack.h" |
| 21 | #include "pc/peerconnectionwrapper.h" |
| 22 | #include "pc/test/fakeaudiocapturemodule.h" |
| 23 | #include "pc/test/mockpeerconnectionobservers.h" |
| 24 | #include "rtc_base/checks.h" |
| 25 | #include "rtc_base/gunit.h" |
| 26 | #include "rtc_base/ptr_util.h" |
| 27 | #include "rtc_base/refcountedobject.h" |
| 28 | #include "rtc_base/scoped_ref_ptr.h" |
| 29 | #include "rtc_base/thread.h" |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 30 | #include "test/gmock.h" |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 31 | |
| 32 | // This file contains tests for RTP Media API-related behavior of |
| 33 | // |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api. |
| 34 | |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 35 | namespace webrtc { |
| 36 | |
| 37 | using RTCConfiguration = PeerConnectionInterface::RTCConfiguration; |
| 38 | using ::testing::ElementsAre; |
| 39 | using ::testing::UnorderedElementsAre; |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 40 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 41 | const uint32_t kDefaultTimeout = 10000u; |
| 42 | |
| 43 | template <typename MethodFunctor> |
| 44 | class OnSuccessObserver : public rtc::RefCountedObject< |
| 45 | webrtc::SetRemoteDescriptionObserverInterface> { |
| 46 | public: |
| 47 | explicit OnSuccessObserver(MethodFunctor on_success) |
| 48 | : on_success_(std::move(on_success)) {} |
| 49 | |
| 50 | // webrtc::SetRemoteDescriptionObserverInterface implementation. |
| 51 | void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override { |
| 52 | RTC_CHECK(error.ok()); |
| 53 | on_success_(); |
| 54 | } |
| 55 | |
| 56 | private: |
| 57 | MethodFunctor on_success_; |
| 58 | }; |
| 59 | |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 60 | class PeerConnectionRtpTest : public testing::Test { |
| 61 | public: |
| 62 | PeerConnectionRtpTest() |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 63 | : pc_factory_( |
| 64 | CreatePeerConnectionFactory(rtc::Thread::Current(), |
| 65 | rtc::Thread::Current(), |
| 66 | rtc::Thread::Current(), |
| 67 | FakeAudioCaptureModule::Create(), |
| 68 | CreateBuiltinAudioEncoderFactory(), |
| 69 | CreateBuiltinAudioDecoderFactory(), |
| 70 | nullptr, |
| 71 | nullptr)) {} |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 72 | |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 73 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() { |
| 74 | return CreatePeerConnection(RTCConfiguration()); |
| 75 | } |
| 76 | |
| 77 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() { |
| 78 | RTCConfiguration config; |
| 79 | config.sdp_semantics = SdpSemantics::kUnifiedPlan; |
| 80 | return CreatePeerConnection(config); |
| 81 | } |
| 82 | |
| 83 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection( |
| 84 | const RTCConfiguration& config) { |
| 85 | auto observer = rtc::MakeUnique<MockPeerConnectionObserver>(); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 86 | auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr, |
| 87 | observer.get()); |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 88 | return rtc::MakeUnique<PeerConnectionWrapper>(pc_factory_, pc, |
| 89 | std::move(observer)); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 90 | } |
| 91 | |
| 92 | protected: |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 93 | rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_; |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 94 | }; |
| 95 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 96 | // These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon |
| 97 | // setting the remote description. |
| 98 | class PeerConnectionRtpCallbacksTest : public PeerConnectionRtpTest {}; |
| 99 | |
| 100 | TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithoutStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 101 | auto caller = CreatePeerConnection(); |
| 102 | auto callee = CreatePeerConnection(); |
| 103 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 104 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"))); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 105 | ASSERT_TRUE( |
| 106 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 107 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 108 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 109 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
| 110 | // TODO(hbos): When "no stream" is handled correctly we would expect |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 111 | // |add_track_events_[0].streams| to be empty. https://crbug.com/webrtc/7933 |
Henrik Boström | 9e6fd2b | 2017-11-21 12:41:51 | [diff] [blame] | 112 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 113 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 12:41:51 | [diff] [blame] | 114 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 115 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 116 | } |
| 117 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 118 | TEST_F(PeerConnectionRtpCallbacksTest, AddTrackWithStreamFiresOnAddTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 119 | auto caller = CreatePeerConnection(); |
| 120 | auto callee = CreatePeerConnection(); |
| 121 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 122 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 123 | {"audio_stream"})); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 124 | ASSERT_TRUE( |
| 125 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 126 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 127 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 128 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 12:41:51 | [diff] [blame] | 129 | auto& add_track_event = callee->observer()->add_track_events_[0]; |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 130 | ASSERT_EQ(add_track_event.streams.size(), 1u); |
Henrik Boström | 9e6fd2b | 2017-11-21 12:41:51 | [diff] [blame] | 131 | EXPECT_EQ("audio_stream", add_track_event.streams[0]->label()); |
| 132 | EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track")); |
| 133 | EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams()); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 134 | } |
| 135 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 136 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 137 | RemoveTrackWithoutStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 138 | auto caller = CreatePeerConnection(); |
| 139 | auto callee = CreatePeerConnection(); |
| 140 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 141 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 142 | ASSERT_TRUE( |
| 143 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 144 | static_cast<webrtc::RTCError*>(nullptr))); |
| 145 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 146 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 147 | ASSERT_TRUE( |
| 148 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 149 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 150 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 151 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 152 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 153 | callee->observer()->remove_track_events_); |
| 154 | } |
| 155 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 156 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 157 | RemoveTrackWithStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 158 | auto caller = CreatePeerConnection(); |
| 159 | auto callee = CreatePeerConnection(); |
| 160 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 161 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 162 | {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 163 | ASSERT_TRUE( |
| 164 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 165 | static_cast<webrtc::RTCError*>(nullptr))); |
| 166 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 167 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 168 | ASSERT_TRUE( |
| 169 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 170 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 171 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 172 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 173 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 174 | callee->observer()->remove_track_events_); |
| 175 | } |
| 176 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 177 | TEST_F(PeerConnectionRtpCallbacksTest, |
| 178 | RemoveTrackWithSharedStreamFiresOnRemoveTrack) { |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 179 | auto caller = CreatePeerConnection(); |
| 180 | auto callee = CreatePeerConnection(); |
| 181 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 182 | const char kSharedStreamLabel[] = "shared_audio_stream"; |
| 183 | auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
| 184 | {kSharedStreamLabel}); |
| 185 | auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"), |
| 186 | {kSharedStreamLabel}); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 187 | ASSERT_TRUE( |
| 188 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 189 | static_cast<webrtc::RTCError*>(nullptr))); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 190 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 191 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 192 | |
| 193 | // Remove "audio_track1". |
| 194 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 195 | ASSERT_TRUE( |
| 196 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 197 | static_cast<webrtc::RTCError*>(nullptr))); |
| 198 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 199 | EXPECT_EQ( |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 200 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 201 | callee->observer()->add_track_events_[0].receiver}, |
| 202 | callee->observer()->remove_track_events_); |
| 203 | |
| 204 | // Remove "audio_track2". |
| 205 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 206 | ASSERT_TRUE( |
| 207 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 208 | static_cast<webrtc::RTCError*>(nullptr))); |
| 209 | ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u); |
Henrik Boström | 933d8b0 | 2017-10-10 17:05:16 | [diff] [blame] | 210 | EXPECT_EQ(callee->observer()->GetAddTrackReceivers(), |
| 211 | callee->observer()->remove_track_events_); |
| 212 | } |
| 213 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 214 | // These tests examine the state of the peer connection as a result of |
| 215 | // performing SetRemoteDescription(). |
| 216 | class PeerConnectionRtpObserverTest : public PeerConnectionRtpTest {}; |
| 217 | |
| 218 | TEST_F(PeerConnectionRtpObserverTest, AddSenderWithoutStreamAddsReceiver) { |
| 219 | auto caller = CreatePeerConnection(); |
| 220 | auto callee = CreatePeerConnection(); |
| 221 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 222 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), {})); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 223 | ASSERT_TRUE( |
| 224 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 225 | static_cast<webrtc::RTCError*>(nullptr))); |
| 226 | |
| 227 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 228 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 229 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 230 | // TODO(hbos): When "no stream" is handled correctly we would expect |
| 231 | // |receiver_added->streams()| to be empty. https://crbug.com/webrtc/7933 |
| 232 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
| 233 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 234 | } |
| 235 | |
| 236 | TEST_F(PeerConnectionRtpObserverTest, AddSenderWithStreamAddsReceiver) { |
| 237 | auto caller = CreatePeerConnection(); |
| 238 | auto callee = CreatePeerConnection(); |
| 239 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 240 | ASSERT_TRUE(caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 241 | {"audio_stream"})); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 242 | ASSERT_TRUE( |
| 243 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 244 | static_cast<webrtc::RTCError*>(nullptr))); |
| 245 | |
| 246 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 247 | auto receiver_added = callee->pc()->GetReceivers()[0]; |
| 248 | EXPECT_EQ("audio_track", receiver_added->track()->id()); |
| 249 | EXPECT_EQ(receiver_added->streams().size(), 1u); |
| 250 | EXPECT_EQ("audio_stream", receiver_added->streams()[0]->label()); |
| 251 | EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track")); |
| 252 | } |
| 253 | |
| 254 | TEST_F(PeerConnectionRtpObserverTest, |
| 255 | RemoveSenderWithoutStreamRemovesReceiver) { |
| 256 | auto caller = CreatePeerConnection(); |
| 257 | auto callee = CreatePeerConnection(); |
| 258 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 259 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 260 | ASSERT_TRUE(sender); |
| 261 | ASSERT_TRUE( |
| 262 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 263 | static_cast<webrtc::RTCError*>(nullptr))); |
| 264 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 265 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 266 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 267 | ASSERT_TRUE( |
| 268 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 269 | static_cast<webrtc::RTCError*>(nullptr))); |
| 270 | |
| 271 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 272 | // Instead, the transceiver owning the receiver will become inactive. |
| 273 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 274 | } |
| 275 | |
| 276 | TEST_F(PeerConnectionRtpObserverTest, RemoveSenderWithStreamRemovesReceiver) { |
| 277 | auto caller = CreatePeerConnection(); |
| 278 | auto callee = CreatePeerConnection(); |
| 279 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 280 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), |
| 281 | {"audio_stream"}); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 282 | ASSERT_TRUE(sender); |
| 283 | ASSERT_TRUE( |
| 284 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 285 | static_cast<webrtc::RTCError*>(nullptr))); |
| 286 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u); |
| 287 | auto receiver = callee->pc()->GetReceivers()[0]; |
| 288 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 289 | ASSERT_TRUE( |
| 290 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 291 | static_cast<webrtc::RTCError*>(nullptr))); |
| 292 | |
| 293 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 294 | // Instead, the transceiver owning the receiver will become inactive. |
| 295 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 296 | } |
| 297 | |
| 298 | TEST_F(PeerConnectionRtpObserverTest, |
| 299 | RemoveSenderWithSharedStreamRemovesReceiver) { |
| 300 | auto caller = CreatePeerConnection(); |
| 301 | auto callee = CreatePeerConnection(); |
| 302 | |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 303 | const char kSharedStreamLabel[] = "shared_audio_stream"; |
| 304 | auto sender1 = caller->AddTrack(caller->CreateAudioTrack("audio_track1"), |
| 305 | {kSharedStreamLabel}); |
| 306 | auto sender2 = caller->AddTrack(caller->CreateAudioTrack("audio_track2"), |
| 307 | {kSharedStreamLabel}); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 308 | ASSERT_TRUE( |
| 309 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 310 | static_cast<webrtc::RTCError*>(nullptr))); |
| 311 | |
| 312 | ASSERT_EQ(callee->pc()->GetReceivers().size(), 2u); |
| 313 | rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver1; |
| 314 | rtc::scoped_refptr<webrtc::RtpReceiverInterface> receiver2; |
| 315 | if (callee->pc()->GetReceivers()[0]->track()->id() == "audio_track1") { |
| 316 | receiver1 = callee->pc()->GetReceivers()[0]; |
| 317 | receiver2 = callee->pc()->GetReceivers()[1]; |
| 318 | } else { |
| 319 | receiver1 = callee->pc()->GetReceivers()[1]; |
| 320 | receiver2 = callee->pc()->GetReceivers()[0]; |
| 321 | } |
| 322 | EXPECT_EQ("audio_track1", receiver1->track()->id()); |
| 323 | EXPECT_EQ("audio_track2", receiver2->track()->id()); |
| 324 | |
| 325 | // Remove "audio_track1". |
| 326 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender1)); |
| 327 | ASSERT_TRUE( |
| 328 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 329 | static_cast<webrtc::RTCError*>(nullptr))); |
| 330 | // Only |receiver2| should remain. |
| 331 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 332 | // Instead, the transceiver owning the receiver will become inactive. |
| 333 | EXPECT_EQ( |
| 334 | std::vector<rtc::scoped_refptr<webrtc::RtpReceiverInterface>>{receiver2}, |
| 335 | callee->pc()->GetReceivers()); |
| 336 | |
| 337 | // Remove "audio_track2". |
| 338 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender2)); |
| 339 | ASSERT_TRUE( |
| 340 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), |
| 341 | static_cast<webrtc::RTCError*>(nullptr))); |
| 342 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 343 | // Instead, the transceiver owning the receiver will become inactive. |
| 344 | EXPECT_EQ(callee->pc()->GetReceivers().size(), 0u); |
| 345 | } |
| 346 | |
| 347 | // Invokes SetRemoteDescription() twice in a row without synchronizing the two |
| 348 | // calls and examine the state of the peer connection inside the callbacks to |
| 349 | // ensure that the second call does not occur prematurely, contaminating the |
| 350 | // state of the peer connection of the first callback. |
| 351 | TEST_F(PeerConnectionRtpObserverTest, |
| 352 | StatesCorrelateWithSetRemoteDescriptionCall) { |
| 353 | auto caller = CreatePeerConnection(); |
| 354 | auto callee = CreatePeerConnection(); |
| 355 | |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 356 | // Create SDP for adding a track and for removing it. This will be used in the |
| 357 | // first and second SetRemoteDescription() calls. |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 358 | auto sender = caller->AddTrack(caller->CreateAudioTrack("audio_track"), {}); |
Henrik Boström | 3163867 | 2017-11-23 16:48:32 | [diff] [blame] | 359 | auto srd1_sdp = caller->CreateOfferAndSetAsLocal(); |
| 360 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 361 | auto srd2_sdp = caller->CreateOfferAndSetAsLocal(); |
| 362 | |
| 363 | // In the first SetRemoteDescription() callback, check that we have a |
| 364 | // receiver for the track. |
| 365 | auto pc = callee->pc(); |
| 366 | bool srd1_callback_called = false; |
| 367 | auto srd1_callback = [&srd1_callback_called, &pc]() { |
| 368 | EXPECT_EQ(pc->GetReceivers().size(), 1u); |
| 369 | srd1_callback_called = true; |
| 370 | }; |
| 371 | |
| 372 | // In the second SetRemoteDescription() callback, check that the receiver has |
| 373 | // been removed. |
| 374 | // TODO(hbos): When we implement Unified Plan, receivers will not be removed. |
| 375 | // Instead, the transceiver owning the receiver will become inactive. |
| 376 | // https://crbug.com/webrtc/7600 |
| 377 | bool srd2_callback_called = false; |
| 378 | auto srd2_callback = [&srd2_callback_called, &pc]() { |
| 379 | EXPECT_TRUE(pc->GetReceivers().empty()); |
| 380 | srd2_callback_called = true; |
| 381 | }; |
| 382 | |
| 383 | // Invoke SetRemoteDescription() twice in a row without synchronizing the two |
| 384 | // calls. The callbacks verify that the two calls are synchronized, as in, the |
| 385 | // effects of the second SetRemoteDescription() call must not have happened by |
| 386 | // the time the first callback is invoked. If it has then the receiver that is |
| 387 | // added as a result of the first SetRemoteDescription() call will already |
| 388 | // have been removed as a result of the second SetRemoteDescription() call |
| 389 | // when the first callback is invoked. |
| 390 | callee->pc()->SetRemoteDescription( |
| 391 | std::move(srd1_sdp), |
| 392 | new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback)); |
| 393 | callee->pc()->SetRemoteDescription( |
| 394 | std::move(srd2_sdp), |
| 395 | new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback)); |
| 396 | EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout); |
| 397 | EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout); |
| 398 | } |
| 399 | |
| 400 | // Tests for the legacy SetRemoteDescription() function signature. |
| 401 | class PeerConnectionRtpLegacyObserverTest : public PeerConnectionRtpTest {}; |
| 402 | |
| 403 | // Sanity test making sure the callback is invoked. |
| 404 | TEST_F(PeerConnectionRtpLegacyObserverTest, OnSuccess) { |
| 405 | auto caller = CreatePeerConnection(); |
| 406 | auto callee = CreatePeerConnection(); |
| 407 | |
| 408 | std::string error; |
| 409 | ASSERT_TRUE( |
| 410 | callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error)); |
| 411 | } |
| 412 | |
| 413 | // Verifies legacy behavior: The observer is not called if if the peer |
| 414 | // connection is destroyed because the asynchronous callback is executed in the |
| 415 | // peer connection's message handler. |
| 416 | TEST_F(PeerConnectionRtpLegacyObserverTest, |
| 417 | ObserverNotCalledIfPeerConnectionDereferenced) { |
| 418 | auto caller = CreatePeerConnection(); |
| 419 | auto callee = CreatePeerConnection(); |
| 420 | |
| 421 | rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer = |
| 422 | new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>(); |
| 423 | |
| 424 | auto offer = caller->CreateOfferAndSetAsLocal(); |
| 425 | callee->pc()->SetRemoteDescription(observer, offer.release()); |
| 426 | callee = nullptr; |
| 427 | rtc::Thread::Current()->ProcessMessages(0); |
| 428 | EXPECT_FALSE(observer->called()); |
| 429 | } |
| 430 | |
Steve Anton | f9381f0 | 2017-12-14 18:23:57 | [diff] [blame] | 431 | // RtpTransceiver Tests. |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 432 | |
| 433 | // Test that by default there are no transceivers with Unified Plan. |
| 434 | TEST_F(PeerConnectionRtpTest, PeerConnectionHasNoTransceivers) { |
| 435 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 436 | EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre()); |
| 437 | } |
| 438 | |
| 439 | // Test that a transceiver created with the audio kind has the correct initial |
| 440 | // properties. |
| 441 | TEST_F(PeerConnectionRtpTest, AddTransceiverHasCorrectInitProperties) { |
| 442 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 443 | |
| 444 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 445 | EXPECT_EQ(rtc::nullopt, transceiver->mid()); |
| 446 | EXPECT_FALSE(transceiver->stopped()); |
| 447 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 448 | EXPECT_EQ(rtc::nullopt, transceiver->current_direction()); |
| 449 | } |
| 450 | |
| 451 | // Test that adding a transceiver with the audio kind creates an audio sender |
| 452 | // and audio receiver with the receiver having a live audio track. |
| 453 | TEST_F(PeerConnectionRtpTest, |
| 454 | AddAudioTransceiverCreatesAudioSenderAndReceiver) { |
| 455 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 456 | |
| 457 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 458 | |
| 459 | ASSERT_TRUE(transceiver->sender()); |
| 460 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type()); |
| 461 | |
| 462 | ASSERT_TRUE(transceiver->receiver()); |
| 463 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type()); |
| 464 | |
| 465 | auto track = transceiver->receiver()->track(); |
| 466 | ASSERT_TRUE(track); |
| 467 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind()); |
| 468 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 469 | } |
| 470 | |
| 471 | // Test that adding a transceiver with the video kind creates an video sender |
| 472 | // and video receiver with the receiver having a live video track. |
| 473 | TEST_F(PeerConnectionRtpTest, |
| 474 | AddAudioTransceiverCreatesVideoSenderAndReceiver) { |
| 475 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 476 | |
| 477 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
| 478 | |
| 479 | ASSERT_TRUE(transceiver->sender()); |
| 480 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type()); |
| 481 | |
| 482 | ASSERT_TRUE(transceiver->receiver()); |
| 483 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type()); |
| 484 | |
| 485 | auto track = transceiver->receiver()->track(); |
| 486 | ASSERT_TRUE(track); |
| 487 | EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind()); |
| 488 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state()); |
| 489 | } |
| 490 | |
| 491 | // Test that after a call to AddTransceiver, the transceiver shows in |
| 492 | // GetTransceivers(), the transceiver's sender shows in GetSenders(), and the |
| 493 | // transceiver's receiver shows in GetReceivers(). |
| 494 | TEST_F(PeerConnectionRtpTest, AddTransceiverShowsInLists) { |
| 495 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 496 | |
| 497 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 498 | EXPECT_EQ( |
| 499 | std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver}, |
| 500 | caller->pc()->GetTransceivers()); |
| 501 | EXPECT_EQ( |
| 502 | std::vector<rtc::scoped_refptr<RtpSenderInterface>>{ |
| 503 | transceiver->sender()}, |
| 504 | caller->pc()->GetSenders()); |
| 505 | EXPECT_EQ( |
| 506 | std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{ |
| 507 | transceiver->receiver()}, |
| 508 | caller->pc()->GetReceivers()); |
| 509 | } |
| 510 | |
| 511 | // Test that the direction passed in through the AddTransceiver init parameter |
| 512 | // is set in the returned transceiver. |
| 513 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithDirectionIsReflected) { |
| 514 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 515 | |
| 516 | RtpTransceiverInit init; |
| 517 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 518 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 519 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 520 | } |
| 521 | |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 522 | // Test that calling AddTransceiver with a track creates a transceiver which has |
| 523 | // its sender's track set to the passed-in track. |
| 524 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithTrackCreatesSenderWithTrack) { |
| 525 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 526 | |
| 527 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 528 | auto transceiver = caller->AddTransceiver(audio_track); |
| 529 | |
| 530 | auto sender = transceiver->sender(); |
| 531 | ASSERT_TRUE(sender->track()); |
| 532 | EXPECT_EQ(audio_track, sender->track()); |
| 533 | |
| 534 | auto receiver = transceiver->receiver(); |
| 535 | ASSERT_TRUE(receiver->track()); |
| 536 | EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind()); |
| 537 | EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, |
| 538 | receiver->track()->state()); |
| 539 | } |
| 540 | |
| 541 | // Test that calling AddTransceiver twice with the same track creates distinct |
| 542 | // transceivers, senders with the same track. |
| 543 | TEST_F(PeerConnectionRtpTest, |
| 544 | AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) { |
| 545 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 546 | |
| 547 | auto audio_track = caller->CreateAudioTrack("audio track"); |
| 548 | |
| 549 | auto transceiver1 = caller->AddTransceiver(audio_track); |
| 550 | auto transceiver2 = caller->AddTransceiver(audio_track); |
| 551 | |
| 552 | EXPECT_NE(transceiver1, transceiver2); |
| 553 | |
| 554 | auto sender1 = transceiver1->sender(); |
| 555 | auto sender2 = transceiver2->sender(); |
| 556 | EXPECT_NE(sender1, sender2); |
| 557 | EXPECT_EQ(audio_track, sender1->track()); |
| 558 | EXPECT_EQ(audio_track, sender2->track()); |
| 559 | |
| 560 | EXPECT_THAT(caller->pc()->GetTransceivers(), |
| 561 | UnorderedElementsAre(transceiver1, transceiver2)); |
| 562 | EXPECT_THAT(caller->pc()->GetSenders(), |
| 563 | UnorderedElementsAre(sender1, sender2)); |
| 564 | } |
| 565 | |
Steve Anton | 3fe1b15 | 2017-12-12 18:20:08 | [diff] [blame] | 566 | // RtpTransceiver error handling tests. |
| 567 | |
| 568 | TEST_F(PeerConnectionRtpTest, AddTransceiverWithInvalidKindReturnsError) { |
| 569 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 570 | |
| 571 | auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA); |
| 572 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
| 573 | } |
| 574 | |
| 575 | TEST_F(PeerConnectionRtpTest, UnifiedPlanCanClosePeerConnection) { |
| 576 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 577 | |
| 578 | caller->pc()->Close(); |
| 579 | } |
| 580 | |
Steve Anton | f9381f0 | 2017-12-14 18:23:57 | [diff] [blame] | 581 | // Unified Plan AddTrack tests. |
| 582 | |
| 583 | class PeerConnectionRtpUnifiedPlanTest : public PeerConnectionRtpTest {}; |
| 584 | |
| 585 | // Test that adding an audio track creates a new audio RtpSender with the given |
| 586 | // track. |
| 587 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddAudioTrackCreatesAudioSender) { |
| 588 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 589 | |
| 590 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 591 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 18:23:57 | [diff] [blame] | 592 | ASSERT_TRUE(sender); |
| 593 | |
| 594 | EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type()); |
| 595 | EXPECT_EQ(audio_track, sender->track()); |
| 596 | } |
| 597 | |
| 598 | // Test that adding a video track creates a new video RtpSender with the given |
| 599 | // track. |
| 600 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddVideoTrackCreatesVideoSender) { |
| 601 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 602 | |
| 603 | auto video_track = caller->CreateVideoTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 604 | auto sender = caller->AddTrack(video_track); |
Steve Anton | f9381f0 | 2017-12-14 18:23:57 | [diff] [blame] | 605 | ASSERT_TRUE(sender); |
| 606 | |
| 607 | EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type()); |
| 608 | EXPECT_EQ(video_track, sender->track()); |
| 609 | } |
| 610 | |
| 611 | // Test that adding a track to a new PeerConnection creates an RtpTransceiver |
| 612 | // with the sender that AddTrack returns and in the sendrecv direction. |
| 613 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddFirstTrackCreatesTransceiver) { |
| 614 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 615 | |
| 616 | auto sender = caller->AddAudioTrack("a"); |
| 617 | ASSERT_TRUE(sender); |
| 618 | |
| 619 | auto transceivers = caller->pc()->GetTransceivers(); |
| 620 | ASSERT_EQ(1u, transceivers.size()); |
| 621 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 622 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction()); |
| 623 | } |
| 624 | |
| 625 | // Test that if a transceiver of the same type but no track had been added to |
| 626 | // the PeerConnection and later a call to AddTrack is made, the resulting sender |
| 627 | // is the transceiver's sender and the sender's track is the newly-added track. |
| 628 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiver) { |
| 629 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 630 | |
| 631 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 632 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 633 | auto sender = caller->AddTrack(audio_track); |
Steve Anton | f9381f0 | 2017-12-14 18:23:57 | [diff] [blame] | 634 | ASSERT_TRUE(sender); |
| 635 | |
| 636 | auto transceivers = caller->pc()->GetTransceivers(); |
| 637 | ASSERT_EQ(1u, transceivers.size()); |
| 638 | EXPECT_EQ(transceiver, transceivers[0]); |
| 639 | EXPECT_EQ(sender, transceiver->sender()); |
| 640 | EXPECT_EQ(audio_track, sender->track()); |
| 641 | } |
| 642 | |
| 643 | // Test that adding two tracks to a new PeerConnection creates two |
| 644 | // RtpTransceivers in the same order. |
| 645 | TEST_F(PeerConnectionRtpUnifiedPlanTest, TwoAddTrackCreatesTwoTransceivers) { |
| 646 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 647 | |
| 648 | auto sender1 = caller->AddAudioTrack("a"); |
| 649 | auto sender2 = caller->AddVideoTrack("v"); |
| 650 | ASSERT_TRUE(sender2); |
| 651 | |
| 652 | auto transceivers = caller->pc()->GetTransceivers(); |
| 653 | ASSERT_EQ(2u, transceivers.size()); |
| 654 | EXPECT_EQ(sender1, transceivers[0]->sender()); |
| 655 | EXPECT_EQ(sender2, transceivers[1]->sender()); |
| 656 | } |
| 657 | |
| 658 | // Test that if there are multiple transceivers with no sending track then a |
| 659 | // later call to AddTrack will use the one of the same type as the newly-added |
| 660 | // track. |
| 661 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackReusesTransceiverOfType) { |
| 662 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 663 | |
| 664 | auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 665 | auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO); |
| 666 | auto sender = caller->AddVideoTrack("v"); |
| 667 | |
| 668 | ASSERT_EQ(2u, caller->pc()->GetTransceivers().size()); |
| 669 | EXPECT_NE(sender, audio_transceiver->sender()); |
| 670 | EXPECT_EQ(sender, video_transceiver->sender()); |
| 671 | } |
| 672 | |
| 673 | // Test that if the only transceivers that do not have a sending track have a |
| 674 | // different type from the added track, then AddTrack will create a new |
| 675 | // transceiver for the track. |
| 676 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 677 | AddTrackDoesNotReuseTransceiverOfWrongType) { |
| 678 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 679 | |
| 680 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 681 | auto sender = caller->AddVideoTrack("v"); |
| 682 | |
| 683 | auto transceivers = caller->pc()->GetTransceivers(); |
| 684 | ASSERT_EQ(2u, transceivers.size()); |
| 685 | EXPECT_NE(sender, transceivers[0]->sender()); |
| 686 | EXPECT_EQ(sender, transceivers[1]->sender()); |
| 687 | } |
| 688 | |
| 689 | // Test that the first available transceiver is reused by AddTrack when multiple |
| 690 | // are available. |
| 691 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 692 | AddTrackReusesFirstMatchingTransceiver) { |
| 693 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 694 | |
| 695 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 696 | caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO); |
| 697 | auto sender = caller->AddAudioTrack("a"); |
| 698 | |
| 699 | auto transceivers = caller->pc()->GetTransceivers(); |
| 700 | ASSERT_EQ(2u, transceivers.size()); |
| 701 | EXPECT_EQ(sender, transceivers[0]->sender()); |
| 702 | EXPECT_NE(sender, transceivers[1]->sender()); |
| 703 | } |
| 704 | |
| 705 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 706 | // direction from inactive to sendonly. |
| 707 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 708 | AddTrackChangesDirectionFromInactiveToSendOnly) { |
| 709 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 710 | |
| 711 | RtpTransceiverInit init; |
| 712 | init.direction = RtpTransceiverDirection::kInactive; |
| 713 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 714 | |
| 715 | caller->observer()->clear_negotiation_needed(); |
| 716 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 717 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 718 | |
| 719 | EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction()); |
| 720 | } |
| 721 | |
| 722 | // Test that a call to AddTrack that reuses a transceiver will change the |
| 723 | // direction from recvonly to sendrecv. |
| 724 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 725 | AddTrackChangesDirectionFromRecvOnlyToSendRecv) { |
| 726 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 727 | |
| 728 | RtpTransceiverInit init; |
| 729 | init.direction = RtpTransceiverDirection::kRecvOnly; |
| 730 | auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init); |
| 731 | |
| 732 | caller->observer()->clear_negotiation_needed(); |
| 733 | ASSERT_TRUE(caller->AddAudioTrack("a")); |
| 734 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 735 | |
| 736 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 737 | } |
| 738 | |
| 739 | // Unified Plan AddTrack error handling. |
| 740 | |
| 741 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfClosed) { |
| 742 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 743 | |
| 744 | auto audio_track = caller->CreateAudioTrack("a"); |
| 745 | caller->pc()->Close(); |
| 746 | |
| 747 | caller->observer()->clear_negotiation_needed(); |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 748 | auto result = caller->pc() |
| 749 | ->AddTrack(audio_track, std::vector<std::string>()); |
| 750 | EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 18:23:57 | [diff] [blame] | 751 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 752 | } |
| 753 | |
| 754 | TEST_F(PeerConnectionRtpUnifiedPlanTest, AddTrackErrorIfTrackAlreadyHasSender) { |
| 755 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 756 | |
| 757 | auto audio_track = caller->CreateAudioTrack("a"); |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 758 | ASSERT_TRUE(caller->AddTrack(audio_track)); |
Steve Anton | f9381f0 | 2017-12-14 18:23:57 | [diff] [blame] | 759 | |
| 760 | caller->observer()->clear_negotiation_needed(); |
Steve Anton | 2d6c76a | 2018-01-06 01:10:52 | [diff] [blame] | 761 | auto result = caller->pc() |
| 762 | ->AddTrack(audio_track, std::vector<std::string>()); |
| 763 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type()); |
Steve Anton | f9381f0 | 2017-12-14 18:23:57 | [diff] [blame] | 764 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 765 | } |
| 766 | |
| 767 | // Unified Plan RemoveTrack tests. |
| 768 | |
| 769 | // Test that calling RemoveTrack on a sender with a previously-added track |
| 770 | // clears the sender's track. |
| 771 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackClearsSenderTrack) { |
| 772 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 773 | |
| 774 | auto sender = caller->AddAudioTrack("a"); |
| 775 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 776 | |
| 777 | EXPECT_FALSE(sender->track()); |
| 778 | } |
| 779 | |
| 780 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 781 | // in the sendrecv direction changes the transceiver's direction to recvonly. |
| 782 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 783 | RemoveTrackChangesDirectionFromSendRecvToRecvOnly) { |
| 784 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 785 | |
| 786 | RtpTransceiverInit init; |
| 787 | init.direction = RtpTransceiverDirection::kSendRecv; |
| 788 | auto transceiver = |
| 789 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 790 | |
| 791 | caller->observer()->clear_negotiation_needed(); |
| 792 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 793 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 794 | |
| 795 | EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction()); |
| 796 | EXPECT_TRUE(caller->observer()->renegotiation_needed_); |
| 797 | } |
| 798 | |
| 799 | // Test that calling RemoveTrack on a sender where the transceiver is configured |
| 800 | // in the sendonly direction changes the transceiver's direction to inactive. |
| 801 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 802 | RemoveTrackChangesDirectionFromSendOnlyToInactive) { |
| 803 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 804 | |
| 805 | RtpTransceiverInit init; |
| 806 | init.direction = RtpTransceiverDirection::kSendOnly; |
| 807 | auto transceiver = |
| 808 | caller->AddTransceiver(caller->CreateAudioTrack("a"), init); |
| 809 | |
| 810 | caller->observer()->clear_negotiation_needed(); |
| 811 | ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender())); |
| 812 | EXPECT_TRUE(caller->observer()->negotiation_needed()); |
| 813 | |
| 814 | EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction()); |
| 815 | } |
| 816 | |
| 817 | // Test that calling RemoveTrack with a sender that has a null track results in |
| 818 | // no change in state. |
| 819 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackWithNullSenderTrackIsNoOp) { |
| 820 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 821 | |
| 822 | auto sender = caller->AddAudioTrack("a"); |
| 823 | auto transceiver = caller->pc()->GetTransceivers()[0]; |
| 824 | ASSERT_TRUE(sender->SetTrack(nullptr)); |
| 825 | |
| 826 | caller->observer()->clear_negotiation_needed(); |
| 827 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 828 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 829 | |
| 830 | EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction()); |
| 831 | } |
| 832 | |
| 833 | // Unified Plan RemoveTrack error handling. |
| 834 | |
| 835 | TEST_F(PeerConnectionRtpUnifiedPlanTest, RemoveTrackErrorIfClosed) { |
| 836 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 837 | |
| 838 | auto sender = caller->AddAudioTrack("a"); |
| 839 | caller->pc()->Close(); |
| 840 | |
| 841 | caller->observer()->clear_negotiation_needed(); |
| 842 | EXPECT_FALSE(caller->pc()->RemoveTrack(sender)); |
| 843 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 844 | } |
| 845 | |
| 846 | TEST_F(PeerConnectionRtpUnifiedPlanTest, |
| 847 | RemoveTrackNoErrorIfTrackAlreadyRemoved) { |
| 848 | auto caller = CreatePeerConnectionWithUnifiedPlan(); |
| 849 | |
| 850 | auto sender = caller->AddAudioTrack("a"); |
| 851 | ASSERT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 852 | |
| 853 | caller->observer()->clear_negotiation_needed(); |
| 854 | EXPECT_TRUE(caller->pc()->RemoveTrack(sender)); |
| 855 | EXPECT_FALSE(caller->observer()->negotiation_needed()); |
| 856 | } |
| 857 | |
Steve Anton | 9158ef6 | 2017-11-27 21:01:52 | [diff] [blame] | 858 | } // namespace webrtc |