| commit | 0244632009a662973de9f22a8d798c10b7196807 | [log] [tgz] |
|---|---|---|
| author | philipel <philipel@webrtc.org> | Tue Feb 21 15:28:31 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Feb 21 15:28:31 2017 |
| tree | fe39c7a31c8388678e8ba1bd5f574fe48d44a8ba | |
| parent | 10b86244939d023a86da31ee1ec875d006a134b8 [diff] |
Reland of Fixes a bug where a video stream can get stuck in the suspended state. (patchset #1 id:1 of https://codereview.chromium.org/2703393002/ ) Reason for revert: Downstream fixed Original issue's description: > Revert of Fixes a bug where a video stream can get stuck in the suspended state. (patchset #8 id:120001 of https://codereview.webrtc.org/2705603002/ ) > > Reason for revert: > Breaks downstream > > Original issue's description: > > Fixes a bug where a video stream can get stuck in the suspended state. > > > > This happens if a lot of FEC is allocated when the stream becomes suspended. The required bitrate to unsuspend can then be too high so that the padding bitrate we are allowed to generate is not enough. > > > > This CL also switches the tests from using ISAC to OPUS as RampUpTest.UpDownUpAudioVideoTransportSequenceNumberRtx relies on audio BWE to work (which is only compatible with OPUS). I don't know why it didn't fail before. > > > > BUG=webrtc:7178 > > > > Review-Url: https://codereview.webrtc.org/2705603002 > > Cr-Commit-Position: refs/heads/master@{#16739} > > Committed: https://chromium.googlesource.com/external/webrtc/+/a518a39963d34616d8f0e94991c7f5fbb5affb38 > > TBR=mflodman@webrtc.org,terelius@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7178 > > Review-Url: https://codereview.webrtc.org/2703393002 > Cr-Commit-Position: refs/heads/master@{#16751} > Committed: https://chromium.googlesource.com/external/webrtc/+/b80bdcafed6c529be140da7d9f3e95a00b94219e TBR=mflodman@webrtc.org,terelius@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7178 Review-Url: https://codereview.webrtc.org/2704323003 Cr-Original-Commit-Position: refs/heads/master@{#16753} Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc Cr-Mirrored-Commit: 5ef2bc191428928ee27f853c722f2ebd7d0a8a0c