commit | 070722c9c7f15d71d2bcdbf82c8315de4a566d35 | [log] [tgz] |
---|---|---|
author | mbonadei <mbonadei@webrtc.org> | Tue Sep 05 12:17:02 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Sep 05 12:17:02 2017 |
tree | 0133a1310841252519b1a62fcf318fa0446ecb9d | |
parent | 1a9dee574f66a6b6864a57afb0cbf93322aa7db6 [diff] |
Revert of Decoupling rtc_base from Obj-C code (patchset #1 id:1 of https://codereview.webrtc.org/3004373002/ ) Reason for revert: It breaks a chromium FYI trybot (the switch from rtc_static_library to rtc_source_set seems to be the problem). Original issue's description: > Reland of Decoupling rtc_base from Obj-C code (patchset #1 id:1 of https://codereview.webrtc.org/3008103002/ ) > > Reason for revert: > Trying to reland after fixing downstream project. > > Original issue's description: > > Revert of Decoupling rtc_base from Obj-C code (patchset #8 id:140001 of https://codereview.webrtc.org/3001623003/ ) > > > > Reason for revert: > > It breaks a downstream project. > > > > Original issue's description: > > > Decoupling rtc_base from Obj-C code > > > > > > The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have > > > also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 > > > for more information). > > > > > > To achieve this we have created 2 targets (rtc_base_objc and rtc_base_generic) > > > and rtc_base will act as a proxy between these targets (this way we can avoid a > > > circular dependency between rtc_base_generic and rtc_base_objc). > > > > > > BUG=webrtc:7743 > > > > > > Review-Url: https://codereview.webrtc.org/3001623003 > > > Cr-Commit-Position: refs/heads/master@{#19661} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/a0a5b98937de0f0bf90e17011d2cbc8c632cb409 > > > > TBR=kjellander@webrtc.org,kwiberg@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:7743 > > > > Review-Url: https://codereview.webrtc.org/3008103002 > > Cr-Commit-Position: refs/heads/master@{#19664} > > Committed: https://chromium.googlesource.com/external/webrtc/+/791a8f611da8cc6b0668ccc03bf7525e6ba72a46 > > TBR=kjellander@webrtc.org,kwiberg@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7743 > > Review-Url: https://codereview.webrtc.org/3004373002 > Cr-Commit-Position: refs/heads/master@{#19681} > Committed: https://chromium.googlesource.com/external/webrtc/+/a0c893f324da5c9f0773f8990a29cd24643864e4 TBR=kjellander@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/3007183002 Cr-Original-Commit-Position: refs/heads/master@{#19688} Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc Cr-Mirrored-Commit: 9c5e511806ef64c4cede52722c8a7ae7ae50ff56