| commit | 130ee0591582f23d593c1eedf025c8cf1c19ac4d | [log] [tgz] |
|---|---|---|
| author | kjellander <kjellander@webrtc.org> | Thu May 26 09:46:53 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Thu May 26 09:46:59 2016 |
| tree | aef9f2e39c9a08c53d525592d63bf1dd5958c1de | |
| parent | 7332e77518ecb27c10b5570301a7dc77b8f5dfb3 [diff] |
Revert of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2009253004/ ) Reason for revert: Fails unexpectedly on multiple commit bots: https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug%20%28Clang%29/builds/1748 https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%29/builds/1683 I filed https://bugs.chromium.org/p/chromium/issues/detail?id=614967 to track the problem. I'll reland if it doesn't solve the problem. Original issue's description: > Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ ) > > Original issue's description: > > Adding a some checks and switching out a few assert for RTC_[D]CHECK. > > These changes are around use of AudioFrame.data_ to help us catch issues earlier since assert() is left out in release builds, including builds with DCHECK enabled. I've also added a few full-on CHECKs to avoid reading past buffer boundaries or continuing on in a failed state. > > > > BUG=chromium:613482 > > NOTRY=true > > (using notry due to offline android_arm64_rel bot) > > > > Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b > > Cr-Commit-Position: refs/heads/master@{#12870} > > TBR=henrik.lundin@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:613482 > > Committed: https://crrev.com/ba189cc4f4f6fe311a815646059e8011ffa53894 > Cr-Commit-Position: refs/heads/master@{#12907} TBR=henrik.lundin@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:613482 Review-Url: https://codereview.webrtc.org/2006313009 Cr-Original-Commit-Position: refs/heads/master@{#12909} Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc Cr-Mirrored-Commit: 6895d8ca788df29f4d3a4b97fe891f0fb3a6dbec