commit | 7e7ca922d4abb4585933192dc912bed93597f116 | [log] [tgz] |
---|---|---|
author | kthelgason <kthelgason@webrtc.org> | Thu Mar 09 11:36:58 2017 |
committer | Commit bot <commit-bot@chromium.org> | Thu Mar 09 11:36:58 2017 |
tree | 12dedf38522bfa3b0d4db066051db5266c923079 | |
parent | bb6c54b0f759a0ff7b2141dcbc5db927face9f9e [diff] |
Reland of Add unit tests for RTCMTLVideoView. (patchset #1 id:1 of https://codereview.webrtc.org/2733953006/ ) Reason for revert: Dependant CL has been relanded Original issue's description: > Revert of Add unit tests for RTCMTLVideoView. (patchset #6 id:100001 of https://codereview.webrtc.org/2723903003/ ) > > Reason for revert: > This CL depends on a reverted CL. > > Original issue's description: > > Add unit tests for RTCMTLVideoView. > > > > To properly test the functionality, following changes were needed > > - Make RTCMTLVideoView compiliable for all cpu architectures not just arm64. > > This is needed so that the test can run on any device and on simulator as well. > > - Refactor RTCMTLVideoView to have mockable class methods. > > The unittest class, RTCMTLVideoViewTests was designed to provide easy transition > > to XCTest when the time comes for that. > > To transition to XCTest it would suffice to inherit from XCTestCase and remove > > the gtest methods. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2723903003 > > Cr-Commit-Position: refs/heads/master@{#17014} > > Committed: https://chromium.googlesource.com/external/webrtc/+/0ebe0199acd1070f17ca2abc5bc22fdd8b0861ca > > TBR=magjed@webrtc.org,denicija@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2733953006 > Cr-Commit-Position: refs/heads/master@{#17118} > Committed: https://chromium.googlesource.com/external/webrtc/+/96d91524fa66b9a2e4f9fbbbc9c5e5149021a3f0 TBR=magjed@webrtc.org,denicija@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2743663002 Cr-Original-Commit-Position: refs/heads/master@{#17140} Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc Cr-Mirrored-Commit: 954d9b943bff1c0ed834903a973f67ee1842b04a