| commit | a6d6db14832667de0784bbb93db71d23fe3b60fd | [log] [tgz] |
|---|---|---|
| author | skvlad <skvlad@webrtc.org> | Wed Aug 31 10:42:29 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Aug 31 10:42:35 2016 |
| tree | 25fc16b2e8af03bb6cbcbbcbcb2a4f8cc584eae4 | |
| parent | 19a955fb7b09f01ff2f2dea9a07b7fa2dca03f3d [diff] |
Fixed flaky test: WebRtcVideoChannel2BaseTest.GetStatsMultipleRecvStreams
This test has been failing on TSan lately:
../../webrtc/media/base/videoengine_unittest.h:519: Failure
Value of: GetReceiverStats(i).frame_width
Actual: 0
Expected: DefaultCodec().width
Which is: 640
The root cause for the failure appears to be that the stats update
(https://cs.chromium.org/chromium/src/third_party/webrtc/video/video_receive_stream.cc?rcl=1472584967&l=353)
happens to be after the frame is passed to the renderer - while the test
is only waiting for the former.
The fix is to give it some extra time using EXPECT_EQ_WAIT instead.
Review-Url: https://codereview.webrtc.org/2299483002
Cr-Original-Commit-Position: refs/heads/master@{#13991}
Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc
Cr-Mirrored-Commit: a8c94029d82a86c2b16131f8fe6d05f874ac2667