Add override annotation to appropriate methods in Camera1Enumerator.
Also move getDeviceNames to a more appropriate location in the file.
NOTRY=True
Review-Url: https://codereview.webrtc.org/2105813002
Cr-Original-Commit-Position: refs/heads/master@{#13312}
Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc
Cr-Mirrored-Commit: 70fae2ccc6e65967affdce1ebe324c95c207b650
diff --git a/api/java/android/org/webrtc/Camera1Enumerator.java b/api/java/android/org/webrtc/Camera1Enumerator.java
index a021da2..8523bba 100644
--- a/api/java/android/org/webrtc/Camera1Enumerator.java
+++ b/api/java/android/org/webrtc/Camera1Enumerator.java
@@ -35,16 +35,29 @@
this.captureToTexture = captureToTexture;
}
+ // Returns device names that can be used to create a new VideoCapturerAndroid.
+ @Override
+ public String[] getDeviceNames() {
+ String[] names = new String[android.hardware.Camera.getNumberOfCameras()];
+ for (int i = 0; i < android.hardware.Camera.getNumberOfCameras(); ++i) {
+ names[i] = getDeviceName(i);
+ }
+ return names;
+ }
+
+ @Override
public boolean isFrontFacing(String deviceName) {
android.hardware.Camera.CameraInfo info = getCameraInfo(getCameraIndex(deviceName));
return info.facing == android.hardware.Camera.CameraInfo.CAMERA_FACING_FRONT;
}
+ @Override
public boolean isBackFacing(String deviceName) {
android.hardware.Camera.CameraInfo info = getCameraInfo(getCameraIndex(deviceName));
return info.facing == android.hardware.Camera.CameraInfo.CAMERA_FACING_BACK;
}
+ @Override
public CameraVideoCapturer createCapturer(String deviceName,
CameraVideoCapturer.CameraEventsHandler eventsHandler) {
return new VideoCapturerAndroid(deviceName, eventsHandler, captureToTexture);
@@ -134,15 +147,6 @@
return ranges;
}
- // Returns device names that can be used to create a new VideoCapturerAndroid.
- public String[] getDeviceNames() {
- String[] names = new String[android.hardware.Camera.getNumberOfCameras()];
- for (int i = 0; i < android.hardware.Camera.getNumberOfCameras(); ++i) {
- names[i] = getDeviceName(i);
- }
- return names;
- }
-
// Returns the camera index for camera with name |deviceName|, or throws IllegalArgumentException
// if no such camera can be found.
static int getCameraIndex(String deviceName) {