commit | 296f5fcd38ab4758d8bfc08937079f8842a5be67 | [log] [tgz] |
---|---|---|
author | mbonadei <mbonadei@webrtc.org> | Sat Mar 04 03:41:59 2017 |
committer | Commit bot <commit-bot@chromium.org> | Sat Mar 04 03:41:59 2017 |
tree | 9d860bf7515759c48591d4481ffa3545d1ee2491 | |
parent | b202b8b8901d2bdc3af6f4b1f7911c1d1fab0dd6 [diff] |
Reland of Setting is_component_build to false by default (patchset #1 id:1 of https://codereview.webrtc.org/2731703004/ ) Reason for revert: Trying to fix this skipping the check if we are building webrtc within chromium. Original issue's description: > Revert of Setting is_component_build to false by default (patchset #5 id:80001 of https://codereview.webrtc.org/2728643003/ ) > > Reason for revert: > Breaks chrome rolls > > Original issue's description: > > Setting is_component_build to false by default > > > > Webrtc does not support component builds so we want to override > > the chromium default value (which can be true on debug builds if the > > os is different from iOS). > > > > Please note that the user can set this value to true in two ways: > > > > - using --args (e.g.: gn gen out/default --args='is_component_build=true' > > - changing the value in the args.gn file > > > > But in both cases the value will be ignored because we don't use the > > 'component' template but we rely directly on 'rtc_static_library' and > > 'rtc_shared_library'. > > > > BUG=webrtc:6975 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2728643003 > > Cr-Commit-Position: refs/heads/master@{#17020} > > Committed: https://chromium.googlesource.com/external/webrtc/+/2cb3944ba7e4467601ebd94888e1811a6d77be49 > > TBR=kjellander@webrtc.org,mbonadei@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6975 > > Review-Url: https://codereview.webrtc.org/2731703004 > Cr-Commit-Position: refs/heads/master@{#17025} > Committed: https://chromium.googlesource.com/external/webrtc/+/2d9e7685a59c05e62c23d7125064c8e5c1f88edb TBR=kjellander@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6975 Review-Url: https://codereview.webrtc.org/2729243003 Cr-Original-Commit-Position: refs/heads/master@{#17027} Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc Cr-Mirrored-Commit: 9660627c9dc3a9e53b66e6baa5417e16b964a744