| commit | 5403adc36e958da76fdacecbfef068038324f569 | [log] [tgz] |
|---|---|---|
| author | magjed <magjed@webrtc.org> | Sat Nov 12 16:54:45 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Sat Nov 12 16:54:50 2016 |
| tree | 3488473a7fb2097ca835cd11dc9374d3e650406a | |
| parent | ea2de0e374ac4e50bddc2f6a1ef59d0ec2b8b835 [diff] |
Revert of H.264 packetization mode 0 (try 2) (patchset #27 id:520001 of https://codereview.webrtc.org/2337453002/ ) Reason for revert: Broke a lot of tests in chromium.webrtc browser_tests. See e.g. https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/62228 and https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/30102. [ RUN ] WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264/1 ... # # Fatal error in e:\b\c\b\win_builder\src\third_party\webrtc\modules\rtp_rtcp\source\rtp_format_h264.cc, line 170 # last system error: 0 # Check failed: packetization_mode_ == kH264PacketizationMode1 (0 vs. 2) # Original issue's description: > Implement H.264 packetization mode 0. > > This approach extends the H.264 specific information with > a packetization mode enum. > > Status: Parameter is in code. No way to set it yet. > > Rebase of CL 2009213002 > > BUG=600254 > > Committed: https://crrev.com/3bba101f36483b8030a693dfbc93af736d1dba68 > Cr-Commit-Position: refs/heads/master@{#15032} TBR=hbos@webrtc.org,sprang@webrtc.org,mflodman@webrtc.org,hta@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=600254 NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2500743002 Cr-Original-Commit-Position: refs/heads/master@{#15050} Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc Cr-Mirrored-Commit: 13ceeeadfc81a7ab73f212ebf960c3cc1bfca034