| commit | 58ad23e18f3e22122516a8021bcd3059c0fc6e78 | [log] [tgz] |
|---|---|---|
| author | ehmaldonado <ehmaldonado@webrtc.org> | Wed Sep 06 19:11:27 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 06 19:11:27 2017 |
| tree | 1c370576307b69d37f6cd8e622bc7c107cea82bd | |
| parent | 3fa5b7ba0a640ec6171536e98cbb290c34053959 [diff] |
Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #2 id:40001 of https://codereview.webrtc.org/3011023002/ ) Reason for revert: This is not needed, since the script is run on the bot, not on a swarming task. Original issue's description: > Reland of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3008083004/ ) > > Reason for revert: > Now making sure the data attribute contents is not wiped for non-Android targets, > which caused every test relying on resources to break. > > Original issue's description: > > Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ ) > > > > Reason for revert: > > Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554 > > > > Edward: do you understand why? I'll run a full CQ set before relanding for sure. > > > > Original issue's description: > > > Add //build/android/pylib/results/ to Android isolate packaging > > > > > > This is needed before relanding > > > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228 > > > > > > TESTED= > > > I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py > > > is listed in the .isolated file: > > > OUT=out/android-Release > > > TEST=tools_unittests > > > tools_webrtc/mb/mb.py isolate //$OUT $TEST > > > tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated > > > > > > BUG=chromium:717417 > > > NOTRY=True > > > > > > Review-Url: https://codereview.webrtc.org/3006103002 > > > Cr-Commit-Position: refs/heads/master@{#19695} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed > > > > TBR=ehmaldonado@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=chromium:717417 > > > > Review-Url: https://codereview.webrtc.org/3008083004 > > Cr-Commit-Position: refs/heads/master@{#19696} > > Committed: https://chromium.googlesource.com/external/webrtc/+/e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1 > > BUG=chromium:717417 > > Review-Url: https://codereview.webrtc.org/3011023002 > Cr-Commit-Position: refs/heads/master@{#19707} > Committed: https://chromium.googlesource.com/external/webrtc/+/2e75bd4ed8a6111f9bc5b71de23a1dee41137415 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:717417 Review-Url: https://codereview.webrtc.org/3011063002 Cr-Original-Commit-Position: refs/heads/master@{#19717} Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc Cr-Mirrored-Commit: 1f5bda035c8f10bf9493b0c31b1d0b5fce03d8ab