| commit | 6c8666b098fa190b2b3a88a09612e1a4db091968 | [log] [tgz] |
|---|---|---|
| author | deadbeef <deadbeef@webrtc.org> | Sat Dec 24 09:43:32 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Sat Dec 24 09:43:32 2016 |
| tree | 093d5279f6bea809c82e8b15d8fef07a3c751c38 | |
| parent | ec77eb3e5351b77281371f2e7d19a27f94645c96 [diff] |
Revert of Adding error output param to SetConfiguration, using new RTCError type. (patchset #4 id:60001 of https://codereview.webrtc.org/2587133004/ ) Reason for revert: Broke chromium FYI bot because the chromium mock PC overrides the method whose signature is changing. Also broke a downstream internal test, which I need to investigate further. Original issue's description: > Adding error output param to SetConfiguration, using new RTCError type. > > Most notably, will return "INVALID_MODIFICATION" if a field in the > configuration was modified and modification of that field isn't supported. > > Also changing RTCError to a class that wraps an enum type, because it will > eventually need to hold other information (like SDP line number), to match > the RTCError that was recently added to the spec: > https://github.com/w3c/webrtc-pc/pull/850 > > BUG=webrtc:6916 > > Review-Url: https://codereview.webrtc.org/2587133004 > Cr-Commit-Position: refs/heads/master@{#15777} > Committed: https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1aedc872478121f5ed TBR=pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6916 Review-Url: https://codereview.webrtc.org/2600813002 Cr-Original-Commit-Position: refs/heads/master@{#15778} Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc Cr-Mirrored-Commit: 1e23461d5ed79b14d918933a0f969603285aad5f