commit 753e08c02c1d0d41f8365a37d4d2333b7585b5bc
author eladalon <eladalon@webrtc.org> Tue Sep 05 11:30:30 2017
committer Commit Bot <commit-bot@chromium.org> Tue Sep 05 11:30:30 2017
tree b5bc329a6c09f9f801e9cbdff9a761b5cb1ca7d8
parent f453d910802388af6f959c750fec1a9cd589e3d4

Avoid construction of unused RtcEventLogNullImpl object

This CL addresses to nits:
1. When event_log_factory_ is not null, there's no need to create a RtcEventLogNullImpl object.
2. Use MakeUnique.

BUG=None

Review-Url: https://codereview.webrtc.org/3012763002
Cr-Original-Commit-Position: refs/heads/master@{#19686}
Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc
Cr-Mirrored-Commit: 393a9f6926636b94ec8accd5dfe4cd6e5c8ebafe

pc/peerconnectionfactory.cc

diff --git a/pc/peerconnectionfactory.cc b/pc/peerconnectionfactory.cc
index be083c2..d4ee405 100644
--- a/pc/peerconnectionfactory.cc
+++ b/pc/peerconnectionfactory.cc
@@ -21,6 +21,7 @@
 #include "webrtc/logging/rtc_event_log/rtc_event_log.h"
 #include "webrtc/rtc_base/bind.h"
 #include "webrtc/rtc_base/checks.h"
+#include "webrtc/rtc_base/ptr_util.h"
 // Adding 'nogncheck' to disable the gn include headers check to support modular
 // WebRTC build targets.
 // TODO(zhihuang): This wouldn't be necessary if the interface and
@@ -260,10 +261,9 @@
       RTC_FROM_HERE, rtc::Bind(&cricket::PortAllocator::SetNetworkIgnoreMask,
                                allocator.get(), options_.network_ignore_mask));
 
-  std::unique_ptr<RtcEventLog> event_log(new RtcEventLogNullImpl());
-  if (event_log_factory_) {
-    event_log = event_log_factory_->CreateRtcEventLog();
-  }
+  std::unique_ptr<RtcEventLog> event_log =
+      event_log_factory_ ? event_log_factory_->CreateRtcEventLog()
+                         : rtc::MakeUnique<RtcEventLogNullImpl>();
 
   std::unique_ptr<Call> call = worker_thread_->Invoke<std::unique_ptr<Call>>(
       RTC_FROM_HERE,