Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2018 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Mirko Bonadei | 317a1f0 | 2019-09-17 15:06:18 | [diff] [blame] | 11 | #include <memory> |
| 12 | |
Danil Chapovalov | 44db436 | 2019-09-30 02:16:28 | [diff] [blame] | 13 | #include "api/task_queue/task_queue_base.h" |
Artem Titov | 46c4e60 | 2018-08-17 12:26:54 | [diff] [blame] | 14 | #include "api/test/simulated_network.h" |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 15 | #include "api/units/time_delta.h" |
Jiawei Ou | c2ebe21 | 2018-11-08 18:02:56 | [diff] [blame] | 16 | #include "api/video/builtin_video_bitrate_allocator_factory.h" |
Erik Språng | f93eda1 | 2019-01-16 16:10:57 | [diff] [blame] | 17 | #include "api/video/video_bitrate_allocation.h" |
Artem Titov | 4e199e9 | 2018-08-20 11:30:39 | [diff] [blame] | 18 | #include "call/fake_network_pipe.h" |
Tomas Gunnarsson | fae0562 | 2020-06-03 06:54:39 | [diff] [blame] | 19 | #include "modules/rtp_rtcp/source/rtp_rtcp_impl2.h" |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 20 | #include "rtc_base/rate_limiter.h" |
Markus Handell | 9bbff07 | 2020-07-07 12:23:18 | [diff] [blame] | 21 | #include "rtc_base/synchronization/mutex.h" |
Danil Chapovalov | 82a3f0a | 2019-10-21 07:24:27 | [diff] [blame] | 22 | #include "rtc_base/task_queue_for_test.h" |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 23 | #include "system_wrappers/include/sleep.h" |
| 24 | #include "test/call_test.h" |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 25 | #include "test/fake_encoder.h" |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 26 | #include "test/field_trial.h" |
| 27 | #include "test/gtest.h" |
Per K | 569849e | 2024-04-29 08:37:37 | [diff] [blame] | 28 | #include "test/network/simulated_network.h" |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 29 | #include "test/rtcp_packet_parser.h" |
| 30 | #include "test/rtp_rtcp_observer.h" |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 31 | #include "test/video_encoder_proxy_factory.h" |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 32 | #include "test/video_test_constants.h" |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 33 | |
| 34 | namespace webrtc { |
Elad Alon | d8d3248 | 2019-02-18 22:45:57 | [diff] [blame] | 35 | namespace { |
| 36 | enum : int { // The first valid value is 1. |
| 37 | kAbsSendTimeExtensionId = 1, |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 38 | kTransportSequenceNumberId, |
Elad Alon | d8d3248 | 2019-02-18 22:45:57 | [diff] [blame] | 39 | }; |
| 40 | } // namespace |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 41 | |
Ilya Nikolaevskiy | cb96062 | 2018-09-04 09:07:31 | [diff] [blame] | 42 | class BandwidthEndToEndTest : public test::CallTest { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 43 | public: |
Ilya Nikolaevskiy | cb96062 | 2018-09-04 09:07:31 | [diff] [blame] | 44 | BandwidthEndToEndTest() = default; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 45 | }; |
| 46 | |
Ilya Nikolaevskiy | cb96062 | 2018-09-04 09:07:31 | [diff] [blame] | 47 | TEST_F(BandwidthEndToEndTest, ReceiveStreamSendsRemb) { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 48 | class RembObserver : public test::EndToEndTest { |
| 49 | public: |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 50 | RembObserver() : EndToEndTest(test::VideoTestConstants::kDefaultTimeout) {} |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 51 | |
| 52 | void ModifyVideoConfigs( |
| 53 | VideoSendStream::Config* send_config, |
Tommi | f6f4543 | 2022-05-20 13:21:20 | [diff] [blame] | 54 | std::vector<VideoReceiveStreamInterface::Config>* receive_configs, |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 55 | VideoEncoderConfig* encoder_config) override { |
| 56 | send_config->rtp.extensions.clear(); |
Elad Alon | d8d3248 | 2019-02-18 22:45:57 | [diff] [blame] | 57 | send_config->rtp.extensions.push_back( |
| 58 | RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeExtensionId)); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 59 | } |
| 60 | |
Harald Alvestrand | d43af91 | 2023-08-15 11:41:45 | [diff] [blame] | 61 | Action OnReceiveRtcp(rtc::ArrayView<const uint8_t> packet) override { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 62 | test::RtcpPacketParser parser; |
Harald Alvestrand | d43af91 | 2023-08-15 11:41:45 | [diff] [blame] | 63 | EXPECT_TRUE(parser.Parse(packet)); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 64 | |
| 65 | if (parser.remb()->num_packets() > 0) { |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 66 | EXPECT_EQ(test::VideoTestConstants::kReceiverLocalVideoSsrc, |
| 67 | parser.remb()->sender_ssrc()); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 68 | EXPECT_LT(0U, parser.remb()->bitrate_bps()); |
| 69 | EXPECT_EQ(1U, parser.remb()->ssrcs().size()); |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 70 | EXPECT_EQ(test::VideoTestConstants::kVideoSendSsrcs[0], |
| 71 | parser.remb()->ssrcs()[0]); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 72 | observation_complete_.Set(); |
| 73 | } |
| 74 | |
| 75 | return SEND_PACKET; |
| 76 | } |
| 77 | void PerformTest() override { |
| 78 | EXPECT_TRUE(Wait()) << "Timed out while waiting for a " |
| 79 | "receiver RTCP REMB packet to be " |
| 80 | "sent."; |
| 81 | } |
| 82 | } test; |
| 83 | |
| 84 | RunBaseTest(&test); |
| 85 | } |
| 86 | |
| 87 | class BandwidthStatsTest : public test::EndToEndTest { |
| 88 | public: |
Danil Chapovalov | 85a1000 | 2019-10-21 13:00:53 | [diff] [blame] | 89 | BandwidthStatsTest(bool send_side_bwe, TaskQueueBase* task_queue) |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 90 | : EndToEndTest(test::VideoTestConstants::kDefaultTimeout), |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 91 | sender_call_(nullptr), |
| 92 | receiver_call_(nullptr), |
| 93 | has_seen_pacer_delay_(false), |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 94 | send_side_bwe_(send_side_bwe), |
| 95 | task_queue_(task_queue) {} |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 96 | |
Danil Chapovalov | 2f2049a | 2019-11-06 12:28:11 | [diff] [blame] | 97 | ~BandwidthStatsTest() override { |
| 98 | // Block until all already posted tasks run to avoid races when such task |
Artem Titov | ab30d72 | 2021-07-27 14:22:11 | [diff] [blame] | 99 | // accesses `this`. |
Danil Chapovalov | e519f38 | 2022-08-11 10:26:09 | [diff] [blame] | 100 | SendTask(task_queue_, [] {}); |
Danil Chapovalov | 2f2049a | 2019-11-06 12:28:11 | [diff] [blame] | 101 | } |
| 102 | |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 103 | void ModifyVideoConfigs( |
| 104 | VideoSendStream::Config* send_config, |
Tommi | f6f4543 | 2022-05-20 13:21:20 | [diff] [blame] | 105 | std::vector<VideoReceiveStreamInterface::Config>* receive_configs, |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 106 | VideoEncoderConfig* encoder_config) override { |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 107 | send_config->rtp.extensions.clear(); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 108 | if (!send_side_bwe_) { |
Elad Alon | d8d3248 | 2019-02-18 22:45:57 | [diff] [blame] | 109 | send_config->rtp.extensions.push_back( |
| 110 | RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeExtensionId)); |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 111 | } else { |
| 112 | send_config->rtp.extensions.push_back( |
| 113 | RtpExtension(RtpExtension::kTransportSequenceNumberUri, |
| 114 | kTransportSequenceNumberId)); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 115 | } |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 116 | |
| 117 | // Force a too high encoder bitrate to make sure we get pacer delay. |
| 118 | encoder_config->number_of_streams = 1; |
| 119 | encoder_config->max_bitrate_bps = kMaxBitrateBps * 2; |
| 120 | encoder_config->simulcast_layers[0].min_bitrate_bps = kMaxBitrateBps * 2; |
| 121 | encoder_config->simulcast_layers[0].target_bitrate_bps = kMaxBitrateBps * 2; |
| 122 | encoder_config->simulcast_layers[0].max_bitrate_bps = kMaxBitrateBps * 2; |
| 123 | } |
| 124 | |
| 125 | void ModifySenderBitrateConfig(BitrateConstraints* bitrate_config) override { |
| 126 | bitrate_config->max_bitrate_bps = kMaxBitrateBps; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 127 | } |
| 128 | |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 129 | // Called on the pacer thread. |
Harald Alvestrand | d43af91 | 2023-08-15 11:41:45 | [diff] [blame] | 130 | Action OnSendRtp(rtc::ArrayView<const uint8_t> packet) override { |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 131 | // Stats need to be fetched on the thread where the caller objects were |
| 132 | // constructed. |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 133 | task_queue_->PostTask([this]() { |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 134 | if (!sender_call_ || !receiver_call_) { |
| 135 | return; |
| 136 | } |
| 137 | |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 138 | Call::Stats sender_stats = sender_call_->GetStats(); |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 139 | if (!has_seen_pacer_delay_) { |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 140 | has_seen_pacer_delay_ = sender_stats.pacer_delay_ms > 0; |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 141 | } |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 142 | |
| 143 | if (sender_stats.send_bandwidth_bps > 0 && has_seen_pacer_delay_) { |
| 144 | Call::Stats receiver_stats = receiver_call_->GetStats(); |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 145 | if (send_side_bwe_ || receiver_stats.recv_bandwidth_bps > 0) { |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 146 | observation_complete_.Set(); |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 147 | } |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 148 | } |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 149 | }); |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 150 | |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 151 | return SEND_PACKET; |
| 152 | } |
| 153 | |
| 154 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
| 155 | sender_call_ = sender_call; |
| 156 | receiver_call_ = receiver_call; |
| 157 | } |
| 158 | |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 159 | void OnStreamsStopped() override { |
| 160 | sender_call_ = nullptr; |
| 161 | receiver_call_ = nullptr; |
| 162 | } |
| 163 | |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 164 | void PerformTest() override { |
| 165 | EXPECT_TRUE(Wait()) << "Timed out while waiting for " |
| 166 | "non-zero bandwidth stats."; |
| 167 | } |
| 168 | |
| 169 | private: |
Erik Språng | 8d65e9a | 2019-10-30 15:48:28 | [diff] [blame] | 170 | static const int kMaxBitrateBps = 3000000; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 171 | Call* sender_call_; |
| 172 | Call* receiver_call_; |
| 173 | bool has_seen_pacer_delay_; |
| 174 | const bool send_side_bwe_; |
Danil Chapovalov | 85a1000 | 2019-10-21 13:00:53 | [diff] [blame] | 175 | TaskQueueBase* const task_queue_; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 176 | }; |
| 177 | |
Ilya Nikolaevskiy | cb96062 | 2018-09-04 09:07:31 | [diff] [blame] | 178 | TEST_F(BandwidthEndToEndTest, VerifySendSideBweStats) { |
Danil Chapovalov | d15a028 | 2019-10-22 08:48:17 | [diff] [blame] | 179 | BandwidthStatsTest test(true, task_queue()); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 180 | RunBaseTest(&test); |
| 181 | } |
| 182 | |
Ilya Nikolaevskiy | cb96062 | 2018-09-04 09:07:31 | [diff] [blame] | 183 | TEST_F(BandwidthEndToEndTest, VerifyRecvSideBweStats) { |
Danil Chapovalov | d15a028 | 2019-10-22 08:48:17 | [diff] [blame] | 184 | BandwidthStatsTest test(false, task_queue()); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 185 | RunBaseTest(&test); |
| 186 | } |
| 187 | |
| 188 | // Verifies that it's possible to limit the send BWE by sending a REMB. |
| 189 | // This is verified by allowing the send BWE to ramp-up to >1000 kbps, |
| 190 | // then have the test generate a REMB of 500 kbps and verify that the send BWE |
| 191 | // is reduced to exactly 500 kbps. Then a REMB of 1000 kbps is generated and the |
| 192 | // test verifies that the send BWE ramps back up to exactly 1000 kbps. |
Ilya Nikolaevskiy | cb96062 | 2018-09-04 09:07:31 | [diff] [blame] | 193 | TEST_F(BandwidthEndToEndTest, RembWithSendSideBwe) { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 194 | class BweObserver : public test::EndToEndTest { |
| 195 | public: |
Danil Chapovalov | 85a1000 | 2019-10-21 13:00:53 | [diff] [blame] | 196 | explicit BweObserver(TaskQueueBase* task_queue) |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 197 | : EndToEndTest(test::VideoTestConstants::kDefaultTimeout), |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 198 | sender_call_(nullptr), |
| 199 | clock_(Clock::GetRealTimeClock()), |
| 200 | sender_ssrc_(0), |
| 201 | remb_bitrate_bps_(1000000), |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 202 | state_(kWaitForFirstRampUp), |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 203 | retransmission_rate_limiter_(clock_, 1000), |
| 204 | task_queue_(task_queue) {} |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 205 | |
Markus Handell | 3da2577 | 2021-11-05 15:48:38 | [diff] [blame] | 206 | void OnStreamsStopped() override { rtp_rtcp_ = nullptr; } |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 207 | |
Niels Möller | de8e6e6 | 2018-11-13 14:10:33 | [diff] [blame] | 208 | void ModifySenderBitrateConfig( |
| 209 | BitrateConstraints* bitrate_config) override { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 210 | // Set a high start bitrate to reduce the test completion time. |
Niels Möller | de8e6e6 | 2018-11-13 14:10:33 | [diff] [blame] | 211 | bitrate_config->start_bitrate_bps = remb_bitrate_bps_; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 212 | } |
| 213 | |
| 214 | void ModifyVideoConfigs( |
| 215 | VideoSendStream::Config* send_config, |
Tommi | f6f4543 | 2022-05-20 13:21:20 | [diff] [blame] | 216 | std::vector<VideoReceiveStreamInterface::Config>* receive_configs, |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 217 | VideoEncoderConfig* encoder_config) override { |
| 218 | ASSERT_EQ(1u, send_config->rtp.ssrcs.size()); |
| 219 | sender_ssrc_ = send_config->rtp.ssrcs[0]; |
| 220 | |
| 221 | encoder_config->max_bitrate_bps = 2000000; |
| 222 | |
| 223 | ASSERT_EQ(1u, receive_configs->size()); |
Per Kjellander | 89870ff | 2023-01-19 15:45:58 | [diff] [blame] | 224 | remb_sender_local_ssrc_ = (*receive_configs)[0].rtp.local_ssrc; |
| 225 | remb_sender_remote_ssrc_ = (*receive_configs)[0].rtp.remote_ssrc; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 226 | } |
| 227 | |
| 228 | void OnCallsCreated(Call* sender_call, Call* receiver_call) override { |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 229 | RTC_DCHECK(sender_call); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 230 | sender_call_ = sender_call; |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 231 | task_queue_->PostTask([this]() { PollStats(); }); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 232 | } |
| 233 | |
Per Kjellander | 89870ff | 2023-01-19 15:45:58 | [diff] [blame] | 234 | void OnTransportCreated( |
| 235 | test::PacketTransport* /*to_receiver*/, |
| 236 | SimulatedNetworkInterface* /*sender_network*/, |
| 237 | test::PacketTransport* to_sender, |
| 238 | SimulatedNetworkInterface* /*receiver_network*/) override { |
| 239 | RtpRtcpInterface::Configuration config; |
| 240 | config.receiver_only = true; |
| 241 | config.clock = clock_; |
| 242 | config.outgoing_transport = to_sender; |
| 243 | config.retransmission_rate_limiter = &retransmission_rate_limiter_; |
| 244 | config.local_media_ssrc = remb_sender_local_ssrc_; |
| 245 | |
| 246 | rtp_rtcp_ = ModuleRtpRtcpImpl2::Create(config); |
| 247 | rtp_rtcp_->SetRemoteSSRC(remb_sender_remote_ssrc_); |
| 248 | rtp_rtcp_->SetRTCPStatus(RtcpMode::kReducedSize); |
| 249 | } |
| 250 | |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 251 | void PollStats() { |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 252 | Call::Stats stats = sender_call_->GetStats(); |
| 253 | switch (state_) { |
| 254 | case kWaitForFirstRampUp: |
| 255 | if (stats.send_bandwidth_bps >= remb_bitrate_bps_) { |
| 256 | state_ = kWaitForRemb; |
| 257 | remb_bitrate_bps_ /= 2; |
| 258 | rtp_rtcp_->SetRemb( |
| 259 | remb_bitrate_bps_, |
| 260 | std::vector<uint32_t>(&sender_ssrc_, &sender_ssrc_ + 1)); |
| 261 | rtp_rtcp_->SendRTCP(kRtcpRr); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 262 | } |
Tommi | e80885a | 2019-08-05 13:08:17 | [diff] [blame] | 263 | break; |
| 264 | |
| 265 | case kWaitForRemb: |
| 266 | if (stats.send_bandwidth_bps == remb_bitrate_bps_) { |
| 267 | state_ = kWaitForSecondRampUp; |
| 268 | remb_bitrate_bps_ *= 2; |
| 269 | rtp_rtcp_->SetRemb( |
| 270 | remb_bitrate_bps_, |
| 271 | std::vector<uint32_t>(&sender_ssrc_, &sender_ssrc_ + 1)); |
| 272 | rtp_rtcp_->SendRTCP(kRtcpRr); |
| 273 | } |
| 274 | break; |
| 275 | |
| 276 | case kWaitForSecondRampUp: |
| 277 | if (stats.send_bandwidth_bps == remb_bitrate_bps_) { |
| 278 | observation_complete_.Set(); |
| 279 | return; |
| 280 | } |
| 281 | break; |
| 282 | } |
| 283 | |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 284 | task_queue_->PostDelayedTask([this] { PollStats(); }, |
| 285 | TimeDelta::Seconds(1)); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 286 | } |
| 287 | |
| 288 | void PerformTest() override { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 289 | EXPECT_TRUE(Wait()) |
| 290 | << "Timed out while waiting for bitrate to change according to REMB."; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 291 | } |
| 292 | |
| 293 | private: |
| 294 | enum TestState { kWaitForFirstRampUp, kWaitForRemb, kWaitForSecondRampUp }; |
| 295 | |
| 296 | Call* sender_call_; |
| 297 | Clock* const clock_; |
| 298 | uint32_t sender_ssrc_; |
Per Kjellander | 89870ff | 2023-01-19 15:45:58 | [diff] [blame] | 299 | uint32_t remb_sender_local_ssrc_ = 0; |
| 300 | uint32_t remb_sender_remote_ssrc_ = 0; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 301 | int remb_bitrate_bps_; |
Tomas Gunnarsson | f25761d | 2020-06-03 20:55:33 | [diff] [blame] | 302 | std::unique_ptr<ModuleRtpRtcpImpl2> rtp_rtcp_; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 303 | TestState state_; |
| 304 | RateLimiter retransmission_rate_limiter_; |
Danil Chapovalov | 85a1000 | 2019-10-21 13:00:53 | [diff] [blame] | 305 | TaskQueueBase* const task_queue_; |
Danil Chapovalov | d15a028 | 2019-10-22 08:48:17 | [diff] [blame] | 306 | } test(task_queue()); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 307 | |
| 308 | RunBaseTest(&test); |
| 309 | } |
| 310 | |
Ilya Nikolaevskiy | cb96062 | 2018-09-04 09:07:31 | [diff] [blame] | 311 | TEST_F(BandwidthEndToEndTest, ReportsSetEncoderRates) { |
Erik Språng | 7ca375c | 2019-02-06 15:20:17 | [diff] [blame] | 312 | // If these fields trial are on, we get lower bitrates than expected by this |
| 313 | // test, due to the packetization overhead and encoder pushback. |
| 314 | webrtc::test::ScopedFieldTrials field_trials( |
| 315 | std::string(field_trial::GetFieldTrialString()) + |
Erik Språng | 7ca375c | 2019-02-06 15:20:17 | [diff] [blame] | 316 | "WebRTC-VideoRateControl/bitrate_adjuster:false/"); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 317 | class EncoderRateStatsTest : public test::EndToEndTest, |
| 318 | public test::FakeEncoder { |
| 319 | public: |
Danil Chapovalov | b065f1b | 2024-04-15 11:53:03 | [diff] [blame] | 320 | explicit EncoderRateStatsTest(const Environment& env, |
| 321 | TaskQueueBase* task_queue) |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 322 | : EndToEndTest(test::VideoTestConstants::kDefaultTimeout), |
Danil Chapovalov | b065f1b | 2024-04-15 11:53:03 | [diff] [blame] | 323 | FakeEncoder(env), |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 324 | task_queue_(task_queue), |
| 325 | send_stream_(nullptr), |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 326 | encoder_factory_(this), |
Jiawei Ou | c2ebe21 | 2018-11-08 18:02:56 | [diff] [blame] | 327 | bitrate_allocator_factory_( |
| 328 | CreateBuiltinVideoBitrateAllocatorFactory()), |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 329 | bitrate_kbps_(0) {} |
| 330 | |
Tommi | f6f4543 | 2022-05-20 13:21:20 | [diff] [blame] | 331 | void OnVideoStreamsCreated(VideoSendStream* send_stream, |
| 332 | const std::vector<VideoReceiveStreamInterface*>& |
| 333 | receive_streams) override { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 334 | send_stream_ = send_stream; |
| 335 | } |
| 336 | |
| 337 | void ModifyVideoConfigs( |
| 338 | VideoSendStream::Config* send_config, |
Tommi | f6f4543 | 2022-05-20 13:21:20 | [diff] [blame] | 339 | std::vector<VideoReceiveStreamInterface::Config>* receive_configs, |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 340 | VideoEncoderConfig* encoder_config) override { |
Niels Möller | 4db138e | 2018-04-19 07:04:13 | [diff] [blame] | 341 | send_config->encoder_settings.encoder_factory = &encoder_factory_; |
Jiawei Ou | c2ebe21 | 2018-11-08 18:02:56 | [diff] [blame] | 342 | send_config->encoder_settings.bitrate_allocator_factory = |
| 343 | bitrate_allocator_factory_.get(); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 344 | RTC_DCHECK_EQ(1, encoder_config->number_of_streams); |
| 345 | } |
| 346 | |
Erik Språng | 16cb8f5 | 2019-04-12 11:59:09 | [diff] [blame] | 347 | void SetRates(const RateControlParameters& parameters) override { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 348 | // Make sure not to trigger on any default zero bitrates. |
Erik Språng | 16cb8f5 | 2019-04-12 11:59:09 | [diff] [blame] | 349 | if (parameters.bitrate.get_sum_bps() == 0) |
| 350 | return; |
Markus Handell | 9bbff07 | 2020-07-07 12:23:18 | [diff] [blame] | 351 | MutexLock lock(&mutex_); |
Erik Språng | 16cb8f5 | 2019-04-12 11:59:09 | [diff] [blame] | 352 | bitrate_kbps_ = parameters.bitrate.get_sum_kbps(); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 353 | observation_complete_.Set(); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 354 | } |
| 355 | |
| 356 | void PerformTest() override { |
| 357 | ASSERT_TRUE(Wait()) |
| 358 | << "Timed out while waiting for encoder SetRates() call."; |
| 359 | |
Danil Chapovalov | e519f38 | 2022-08-11 10:26:09 | [diff] [blame] | 360 | SendTask(task_queue_, [this]() { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 361 | WaitForEncoderTargetBitrateMatchStats(); |
| 362 | send_stream_->Stop(); |
| 363 | WaitForStatsReportZeroTargetBitrate(); |
| 364 | send_stream_->Start(); |
| 365 | WaitForEncoderTargetBitrateMatchStats(); |
| 366 | }); |
| 367 | } |
| 368 | |
| 369 | void WaitForEncoderTargetBitrateMatchStats() { |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 370 | for (int i = 0; i < test::VideoTestConstants::kDefaultTimeout.ms(); ++i) { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 371 | VideoSendStream::Stats stats = send_stream_->GetStats(); |
| 372 | { |
Markus Handell | 9bbff07 | 2020-07-07 12:23:18 | [diff] [blame] | 373 | MutexLock lock(&mutex_); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 374 | if ((stats.target_media_bitrate_bps + 500) / 1000 == |
| 375 | static_cast<int>(bitrate_kbps_)) { |
| 376 | return; |
| 377 | } |
| 378 | } |
| 379 | SleepMs(1); |
| 380 | } |
| 381 | FAIL() |
| 382 | << "Timed out waiting for stats reporting the currently set bitrate."; |
| 383 | } |
| 384 | |
| 385 | void WaitForStatsReportZeroTargetBitrate() { |
Artem Titov | 8a9f3a8 | 2023-04-25 07:56:49 | [diff] [blame] | 386 | for (int i = 0; i < test::VideoTestConstants::kDefaultTimeout.ms(); ++i) { |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 387 | if (send_stream_->GetStats().target_media_bitrate_bps == 0) { |
| 388 | return; |
| 389 | } |
| 390 | SleepMs(1); |
| 391 | } |
| 392 | FAIL() << "Timed out waiting for stats reporting zero bitrate."; |
| 393 | } |
| 394 | |
| 395 | private: |
Danil Chapovalov | 85a1000 | 2019-10-21 13:00:53 | [diff] [blame] | 396 | TaskQueueBase* const task_queue_; |
Markus Handell | 9bbff07 | 2020-07-07 12:23:18 | [diff] [blame] | 397 | Mutex mutex_; |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 398 | VideoSendStream* send_stream_; |
Niels Möller | cbcbc22 | 2018-09-28 07:07:24 | [diff] [blame] | 399 | test::VideoEncoderProxyFactory encoder_factory_; |
Jiawei Ou | c2ebe21 | 2018-11-08 18:02:56 | [diff] [blame] | 400 | std::unique_ptr<VideoBitrateAllocatorFactory> bitrate_allocator_factory_; |
Markus Handell | 9bbff07 | 2020-07-07 12:23:18 | [diff] [blame] | 401 | uint32_t bitrate_kbps_ RTC_GUARDED_BY(mutex_); |
Danil Chapovalov | b065f1b | 2024-04-15 11:53:03 | [diff] [blame] | 402 | } test(env(), task_queue()); |
Sebastian Jansson | c501713 | 2018-02-02 15:24:16 | [diff] [blame] | 403 | |
| 404 | RunBaseTest(&test); |
| 405 | } |
| 406 | } // namespace webrtc |