Google Git Google Git
Sign in
webrtc/src/1b9f86f801^!/.
commit
1b9f86f801e9a5ee887adc2ba733474263e90ef7
[log]
author
Philipp Hancke <philipp.hancke@googlemail.com>
Wed Mar 25 07:35:58 2026
committer
WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Mar 26 09:28:26 2026
tree
e38ff8c2925d67ad2b5bd351b2e6d7c32c1eaf2c
parent
246b8dee2304df4a20513f595e315a0ca3df079c [diff] 
build: remove unnecessary targets in video_coding

using
  tools_webrtc/gn_check_autofix -r modules/video_coding/BUILD.gn
followed by
  tools_webrtc/gn_check_autofix -C out/Default
with some platform-specific manual reverts and dependencies on test fixtures

Bug: webrtc:467294026
Change-Id: I17731b0bea95110fd05ee7aa4da36ce0c0489c08
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/459940
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#47264}

diff --git a/modules/video_coding/BUILD.gn b/modules/video_coding/BUILD.gn
index 34ff20e3..0ca6954 100644
--- a/modules/video_coding/BUILD.gn
+++ b/modules/video_coding/BUILD.gn

@@ -23,12 +23,8 @@
     "../../api/video:video_frame",
     "../../api/video:video_frame_type",
     "../../api/video:video_rtp_headers",
-    "../../modules:module_api_public",
-    "../../modules/rtp_rtcp:rtp_video_header",
-    "../../rtc_base:checks",
-    "../../rtc_base/experiments:alr_experiment",
     "../../rtc_base/system:rtc_export",
-    "../../system_wrappers",
+    "../rtp_rtcp:rtp_video_header",
   ]
 }
 
@@ -39,7 +35,6 @@
   ]
 
   deps = [
-    "../../rtc_base:checks",
     "../../rtc_base:logging",
     "//third_party/abseil-cpp/absl/container:inlined_vector",
   ]
@@ -82,7 +77,6 @@
     "../../rtc_base:macromagic",
     "../../rtc_base:mod_ops",
     "../../rtc_base:rtc_numerics",
-    "../../rtc_base/experiments:field_trial_parser",
     "../../rtc_base/system:no_unique_address",
     "../../rtc_base/task_utils:repeating_task",
     "../../system_wrappers",
@@ -96,10 +90,6 @@
   ]
   deps = [
     ":codec_globals_headers",
-    "../../api:array_view",
-    "../../api:rtp_packet_info",
-    "../../api/units:timestamp",
-    "../../api/video:encoded_image",
     "../../api/video:video_frame",
     "../../api/video:video_frame_type",
     "../../common_video",
@@ -124,9 +114,6 @@
     ":h264_sprop_parameter_sets",
     ":packet_buffer",
     "../../api:array_view",
-    "../../api:rtp_packet_info",
-    "../../api/units:timestamp",
-    "../../api/video:encoded_image",
     "../../api/video:video_frame",
     "../../api/video:video_frame_type",
     "../../common_video",
@@ -134,7 +121,6 @@
     "../../rtc_base:copy_on_write_buffer",
     "../../rtc_base:logging",
     "../../rtc_base:rtc_numerics",
-    "../rtp_rtcp:rtp_rtcp_format",
     "../rtp_rtcp:rtp_video_header",
     "//third_party/abseil-cpp/absl/algorithm:container",
     "//third_party/abseil-cpp/absl/base:core_headers",
@@ -206,8 +192,6 @@
   deps = [
     ":codec_globals_headers",
     ":encoded_frame",
-    ":frame_helpers",
-    ":h264_sprop_parameter_sets",
     ":video_codec_interface",
     ":video_coding_utility",
     ":webrtc_vp8_scalability",
@@ -218,36 +202,25 @@
     "../../api:array_view",
     "../../api:fec_controller_api",
     "../../api:field_trials_view",
-    "../../api:rtp_headers",
     "../../api:rtp_packet_info",
     "../../api:scoped_refptr",
     "../../api:sequence_checker",
     "../../api/environment",
-    "../../api/task_queue",
     "../../api/units:data_rate",
-    "../../api/units:data_size",
-    "../../api/units:frequency",
     "../../api/units:time_delta",
     "../../api/units:timestamp",
-    "../../api/video:builtin_video_bitrate_allocator_factory",
     "../../api/video:encoded_frame",
     "../../api/video:encoded_image",
     "../../api/video:render_resolution",
-    "../../api/video:video_adaptation",
-    "../../api/video:video_bitrate_allocation",
-    "../../api/video:video_bitrate_allocator",
-    "../../api/video:video_bitrate_allocator_factory",
     "../../api/video:video_codec_constants",
     "../../api/video:video_frame",
     "../../api/video:video_frame_type",
     "../../api/video:video_rtp_headers",
     "../../api/video/corruption_detection:frame_instrumentation_data",
-    "../../api/video/corruption_detection:frame_instrumentation_evaluation",
     "../../api/video_codecs:scalability_mode",
     "../../api/video_codecs:video_codecs_api",
     "../../common_video",
     "../../common_video:corruption_score_calculator",
-    "../../rtc_base:base64",
     "../../rtc_base:buffer",
     "../../rtc_base:byte_buffer",
     "../../rtc_base:checks",
@@ -256,30 +229,19 @@
     "../../rtc_base:logging",
     "../../rtc_base:macromagic",
     "../../rtc_base:mod_ops",
-    "../../rtc_base:rtc_event",
     "../../rtc_base:rtc_numerics",
     "../../rtc_base:safe_conversions",
-    "../../rtc_base:stringutils",
-    "../../rtc_base:threading",
-    "../../rtc_base:timeutils",
-    "../../rtc_base/experiments:alr_experiment",
-    "../../rtc_base/experiments:field_trial_parser",
     "../../rtc_base/experiments:min_video_bitrate_experiment",
     "../../rtc_base/experiments:rate_control_settings",
     "../../rtc_base/synchronization:mutex",
     "../../rtc_base/system:no_unique_address",
-    "../../rtc_base/task_utils:repeating_task",
     "../../system_wrappers",
     "../../system_wrappers:metrics",
     "../../video/config:encoder_config",
     "../rtp_rtcp",
-    "../rtp_rtcp:rtp_rtcp_format",
     "../rtp_rtcp:rtp_video_header",
     "codecs/av1:av1_svc_config",
     "svc:scalability_mode_util",
-    "timing:inter_frame_delay_variation_calculator",
-    "timing:jitter_estimator",
-    "timing:rtt_filter",
     "timing:timing_module",
     "//third_party/abseil-cpp/absl/algorithm:container",
     "//third_party/abseil-cpp/absl/container:inlined_vector",
@@ -307,9 +269,7 @@
     "../../api/video/corruption_detection:frame_instrumentation_data",
     "../../api/video_codecs:scalability_mode",
     "../../api/video_codecs:video_codecs_api",
-    "../../common_video",
     "../../common_video/generic_frame_descriptor",
-    "../../rtc_base:checks",
     "../../rtc_base/system:rtc_export",
   ]
 }
@@ -342,7 +302,6 @@
     "..:module_api_public",
     "../../api/units:time_delta",
     "../../api/video:video_frame",
-    "../../rtc_base:timeutils",
   ]
 }
 
@@ -379,7 +338,6 @@
   ]
 
   deps = [
-    ":video_codec_interface",
     "../../api:array_view",
     "../../api:field_trials_view",
     "../../api:scoped_refptr",
@@ -388,39 +346,30 @@
     "../../api/task_queue",
     "../../api/units:data_rate",
     "../../api/units:time_delta",
-    "../../api/video:encoded_frame",
     "../../api/video:encoded_image",
-    "../../api/video:video_adaptation",
     "../../api/video:video_bitrate_allocation",
     "../../api/video:video_bitrate_allocator",
     "../../api/video:video_codec_constants",
     "../../api/video:video_frame",
     "../../api/video:video_frame_type",
-    "../../api/video/corruption_detection:corruption_detection_settings_generator",
-    "../../api/video/corruption_detection:filter_settings",
     "../../api/video_codecs:video_codecs_api",
     "../../common_video",
-    "../../modules/rtp_rtcp",
     "../../rtc_base:bitstream_reader",
     "../../rtc_base:checks",
     "../../rtc_base:logging",
     "../../rtc_base:macromagic",
     "../../rtc_base:rate_statistics",
-    "../../rtc_base:refcount",
     "../../rtc_base:rtc_numerics",
     "../../rtc_base:stringutils",
-    "../../rtc_base:timeutils",
     "../../rtc_base:weak_ptr",
     "../../rtc_base/experiments:encoder_info_settings",
     "../../rtc_base/experiments:quality_scaler_settings",
     "../../rtc_base/experiments:quality_scaling_experiment",
     "../../rtc_base/experiments:rate_control_settings",
     "../../rtc_base/synchronization:mutex",
-    "../../rtc_base/system:arch",
     "../../rtc_base/system:file_wrapper",
     "../../rtc_base/system:no_unique_address",
     "../../rtc_base/system:rtc_export",
-    "../../rtc_base/task_utils:repeating_task",
     "../../video/config:encoder_config",
     "../rtp_rtcp:rtp_rtcp_format",
     "svc:scalability_mode_util",
@@ -436,7 +385,6 @@
     "utility/encoder_speed_controller_impl.h",
   ]
   deps = [
-    "../../api:array_view",
     "../../api/units:time_delta",
     "../../api/units:timestamp",
     "../../api/video_codecs:video_codecs_api",
@@ -466,7 +414,6 @@
     ":video_coding_utility",
     "../../api:scoped_refptr",
     "../../api/environment",
-    "../../api/transport/rtp:dependency_descriptor",
     "../../api/units:data_rate",
     "../../api/video:encoded_image",
     "../../api/video:render_resolution",
@@ -481,15 +428,12 @@
     "../../api/video_codecs:video_codecs_api",
     "../../common_video",
     "../../media:media_constants",
-    "../../media:rtc_media_base",
     "../../rtc_base:checks",
     "../../rtc_base:event_tracer",
     "../../rtc_base:logging",
-    "../../rtc_base:timeutils",
     "../../rtc_base/experiments:psnr_experiment",
     "../../rtc_base/system:rtc_export",
     "../../system_wrappers:metrics",
-    "../rtp_rtcp:rtp_rtcp_format",
     "svc:scalability_structures",
     "svc:scalable_video_controller",
     "//third_party/abseil-cpp/absl/base:nullability",
@@ -556,7 +500,6 @@
     ":video_coding_utility",
     ":webrtc_libvpx_interface",
     ":webrtc_vp8_scalability",
-    ":webrtc_vp8_temporal_layers",
     "../../api:fec_controller_api",
     "../../api:field_trials_view",
     "../../api:scoped_refptr",
@@ -588,7 +531,6 @@
     "../../rtc_base/experiments:rate_control_settings",
     "../../system_wrappers:metrics",
     "../rtp_rtcp:rtp_rtcp_format",
-    "svc:scalability_mode_util",
     "//third_party/abseil-cpp/absl/algorithm:container",
     "//third_party/abseil-cpp/absl/base:nullability",
     "//third_party/abseil-cpp/absl/container:inlined_vector",
@@ -622,8 +564,6 @@
   deps = [
     ":codec_globals_headers",
     ":video_codec_interface",
-    ":video_coding_utility",
-    "../../api:fec_controller_api",
     "../../api/environment",
     "../../api/transport/rtp:dependency_descriptor",
     "../../api/video:video_codec_constants",
@@ -648,15 +588,9 @@
 
   deps = [
     ":codec_globals_headers",
-    ":video_codec_interface",
-    "../../api/video:video_bitrate_allocation",
-    "../../api/video:video_bitrate_allocator",
-    "../../api/video:video_codec_constants",
     "../../api/video:video_frame",
     "../../api/video_codecs:scalability_mode",
     "../../api/video_codecs:video_codecs_api",
-    "../../common_video",
-    "../../media:video_common",
     "../../rtc_base:checks",
     "../../rtc_base:logging",
     "svc:scalability_mode_util",
@@ -785,7 +719,6 @@
       ":video_codec_interface",
       "../../api:create_frame_generator",
       "../../api:frame_generator_api",
-      "../../api/transport/rtp:dependency_descriptor",
       "../../api/units:timestamp",
       "../../api/video:encoded_image",
       "../../api/video:render_resolution",
@@ -805,7 +738,6 @@
 
     deps = [
       ":video_codec_interface",
-      ":video_coding",
       ":video_coding_utility",
       "../../api:mock_video_decoder",
       "../../api:mock_video_encoder",
@@ -819,7 +751,6 @@
       "../../api/video:video_frame_type",
       "../../api/video:video_rtp_headers",
       "../../api/video_codecs:video_codecs_api",
-      "../../common_video",
       "../../rtc_base:checks",
       "../../test:test_support",
     ]
@@ -836,12 +767,10 @@
 
     deps = [
       ":codec_globals_headers",
+      ":simulcast_test_fixture_impl",
       ":video_codec_interface",
-      ":video_coding",
       ":video_coding_utility",
       ":videocodec_test_stats_impl",
-      ":webrtc_vp9_helpers",
-      "..:module_api",
       "../../api:create_frame_generator",
       "../../api:field_trials",
       "../../api:frame_generator_api",
@@ -851,24 +780,18 @@
       "../../api:videocodec_test_stats_api",
       "../../api/environment",
       "../../api/environment:environment_factory",
-      "../../api/numerics",
       "../../api/task_queue",
-      "../../api/task_queue:default_task_queue_factory",
-      "../../api/test/metrics:global_metrics_logger_and_exporter",
       "../../api/units:time_delta",
       "../../api/video:builtin_video_bitrate_allocator_factory",
       "../../api/video:encoded_image",
       "../../api/video:resolution",
-      "../../api/video:video_bitrate_allocation",
       "../../api/video:video_bitrate_allocator",
       "../../api/video:video_bitrate_allocator_factory",
-      "../../api/video:video_codec_constants",
       "../../api/video:video_frame",
       "../../api/video:video_frame_type",
       "../../api/video:video_rtp_headers",
       "../../api/video_codecs:video_codecs_api",
       "../../common_video",
-      "../../rtc_base:buffer",
       "../../rtc_base:checks",
       "../../rtc_base:macromagic",
       "../../rtc_base:rtc_event",
@@ -927,7 +850,6 @@
     ]
     deps = [
       ":codec_globals_headers",
-      ":video_codec_interface",
       ":video_codecs_test_framework",
       ":video_coding_utility",
       ":videocodec_test_stats_impl",
@@ -942,13 +864,10 @@
       "../../api/environment:environment_factory",
       "../../api/test/metrics:global_metrics_logger_and_exporter",
       "../../api/test/metrics:metric",
-      "../../api/test/video:function_video_factory",
       "../../api/video:encoded_image",
       "../../api/video:resolution",
-      "../../api/video:video_bitrate_allocation",
       "../../api/video:video_codec_constants",
       "../../api/video:video_frame",
-      "../../api/video:video_frame_type",
       "../../api/video_codecs:video_codecs_api",
       "../../api/video_codecs:video_decoder_factory_template",
       "../../api/video_codecs:video_decoder_factory_template_dav1d_adapter",
@@ -962,7 +881,6 @@
       "../../api/video_codecs:video_encoder_factory_template_open_h264_adapter",
       "../../common_video",
       "../../media:media_constants",
-      "../../media:rtc_audio_video",
       "../../rtc_base:checks",
       "../../rtc_base:cpu_info",
       "../../rtc_base:logging",
@@ -992,16 +910,11 @@
     ]
     deps = [
       "../../api:videocodec_test_stats_api",
-      "../../api/numerics",
-      "../../api/test/metrics:global_metrics_logger_and_exporter",
-      "../../api/test/metrics:metric",
       "../../api/units:data_rate",
       "../../api/units:frequency",
       "../../api/video:video_frame_type",
       "../../rtc_base:checks",
       "../../rtc_base:rtc_numerics",
-      "../../rtc_base:stringutils",
-      "../../test:test_common",
       "../rtp_rtcp:rtp_rtcp_format",
     ]
   }
@@ -1012,8 +925,6 @@
     sources = [ "codecs/test/video_codec_test.cc" ]
 
     deps = [
-      ":video_codec_interface",
-      "../../api:field_trials",
       "../../api/environment",
       "../../api/environment:environment_factory",
       "../../api/test/metrics:global_metrics_logger_and_exporter",
@@ -1024,7 +935,6 @@
       "../../api/video_codecs:builtin_video_encoder_factory",
       "../../api/video_codecs:scalability_mode",
       "../../api/video_codecs:video_codecs_api",
-      "../../modules/video_coding/svc:scalability_mode_util",
       "../../rtc_base:checks",
       "../../rtc_base:logging",
       "../../rtc_base:stringutils",
@@ -1033,6 +943,7 @@
       "../../test:test_flags",
       "../../test:test_support",
       "../../test:video_codec_tester",
+      "svc:scalability_mode_util",
       "//third_party/abseil-cpp/absl/flags:flag",
       "//third_party/abseil-cpp/absl/functional:any_invocable",
     ]
@@ -1088,7 +999,6 @@
       "../../api:field_trials",
       "../../api:frame_generator_api",
       "../../api:make_ref_counted",
-      "../../api:mock_video_codec_factory",
       "../../api:mock_video_decoder",
       "../../api:mock_video_encoder",
       "../../api:scoped_refptr",
@@ -1096,7 +1006,6 @@
       "../../api:videocodec_test_stats_api",
       "../../api/environment",
       "../../api/environment:environment_factory",
-      "../../api/test/metrics:global_metrics_logger_and_exporter",
       "../../api/test/video:function_video_factory",
       "../../api/units:data_rate",
       "../../api/units:time_delta",
@@ -1108,25 +1017,19 @@
       "../../api/video:video_frame",
       "../../api/video:video_frame_type",
       "../../api/video:video_rtp_headers",
-      "../../api/video_codecs:rtc_software_fallback_wrappers",
       "../../api/video_codecs:scalability_mode",
       "../../api/video_codecs:video_codecs_api",
       "../../common_video",
-      "../../common_video/test:utilities",
-      "../../media:codec",
       "../../media:media_constants",
       "../../media:rtc_internal_video_codecs",
       "../../media:rtc_simulcast_encoder_adapter",
       "../../rtc_base:checks",
-      "../../rtc_base:refcount",
-      "../../rtc_base:stringutils",
       "../../rtc_base:timeutils",
       "../../test:create_test_field_trials",
       "../../test:fileutils",
       "../../test:test_support",
       "../../test:video_test_common",
       "../rtp_rtcp:rtp_rtcp_format",
-      "codecs/av1:dav1d_decoder",
       "svc:scalability_mode_util",
       "//third_party/abseil-cpp/absl/container:inlined_vector",
       "//third_party/abseil-cpp/absl/memory",
@@ -1210,16 +1113,12 @@
     deps = [
       ":chain_diff_calculator",
       ":codec_globals_headers",
-      ":encoded_frame",
-      ":encoder_speed_controller_impl",
       ":frame_dependencies_calculator",
       ":frame_helpers",
-      ":frame_sampler",
       ":h264_sprop_parameter_sets",
       ":h26x_packet_buffer",
       ":nack_requester",
       ":packet_buffer",
-      ":simulcast_test_fixture_impl",
       ":video_codec_interface",
       ":video_codecs_test_framework",
       ":video_coding",
@@ -1229,7 +1128,6 @@
       ":webrtc_h264",
       ":webrtc_vp8",
       ":webrtc_vp8_temporal_layers",
-      ":webrtc_vp9",
       ":webrtc_vp9_helpers",
       "..:module_api",
       "..:module_fec_api",
@@ -1244,7 +1142,6 @@
       "../../api:mock_fec_controller_override",
       "../../api:mock_video_decoder",
       "../../api:mock_video_encoder",
-      "../../api:rtp_headers",
       "../../api:rtp_packet_info",
       "../../api:scoped_refptr",
       "../../api:simulcast_test_fixture_api",
@@ -1252,20 +1149,15 @@
       "../../api/environment",
       "../../api/environment:environment_factory",
       "../../api/task_queue",
-      "../../api/task_queue:default_task_queue_factory",
       "../../api/test/video:function_video_factory",
       "../../api/transport/rtp:dependency_descriptor",
       "../../api/units:data_rate",
-      "../../api/units:data_size",
-      "../../api/units:frequency",
       "../../api/units:time_delta",
       "../../api/units:timestamp",
       "../../api/video:builtin_video_bitrate_allocator_factory",
       "../../api/video:encoded_frame",
       "../../api/video:encoded_image",
-      "../../api/video:frame_buffer",
       "../../api/video:render_resolution",
-      "../../api/video:video_adaptation",
       "../../api/video:video_bitrate_allocation",
       "../../api/video:video_bitrate_allocator",
       "../../api/video:video_bitrate_allocator_factory",
@@ -1274,7 +1166,6 @@
       "../../api/video:video_frame_type",
       "../../api/video:video_rtp_headers",
       "../../api/video/corruption_detection:corruption_detection_unittests",
-      "../../api/video/corruption_detection:filter_settings",
       "../../api/video/corruption_detection:frame_instrumentation_data",
       "../../api/video_codecs:scalability_mode",
       "../../api/video_codecs:video_codecs_api",
@@ -1284,30 +1175,20 @@
       "../../common_video/generic_frame_descriptor",
       "../../common_video/test:utilities",
       "../../media:media_constants",
-      "../../media:rtc_internal_video_codecs",
       "../../rtc_base:checks",
       "../../rtc_base:copy_on_write_buffer",
-      "../../rtc_base:gunit_helpers",
-      "../../rtc_base:histogram_percentile_counter",
-      "../../rtc_base:platform_thread",
       "../../rtc_base:random",
-      "../../rtc_base:refcount",
       "../../rtc_base:rtc_base_tests_utils",
       "../../rtc_base:rtc_event",
-      "../../rtc_base:rtc_numerics",
-      "../../rtc_base:stringutils",
       "../../rtc_base:task_queue_for_test",
       "../../rtc_base:threading",
-      "../../rtc_base:timeutils",
       "../../rtc_base/experiments:encoder_info_settings",
-      "../../rtc_base/synchronization:mutex",
       "../../rtc_base/system:file_wrapper",
       "../../rtc_base/system:unused",
       "../../system_wrappers",
       "../../system_wrappers:metrics",
       "../../test:create_test_environment",
       "../../test:create_test_field_trials",
-      "../../test:fake_encoded_frame",
       "../../test:fake_video_codecs",
       "../../test:fileutils",
       "../../test:run_loop",
@@ -1315,7 +1196,6 @@
       "../../test:video_test_common",
       "../../test:video_test_support",
       "../../test/time_controller",
-      "../../third_party/libyuv",
       "../../video/config:encoder_config",
       "../rtp_rtcp",
       "../rtp_rtcp:rtp_rtcp_format",
@@ -1324,7 +1204,6 @@
       "svc:scalability_structure_tests",
       "svc:simulcast_to_svc_converter_tests",
       "svc:svc_rate_allocator_tests",
-      "timing:jitter_estimator",
       "timing:timing_module",
       "//third_party/abseil-cpp/absl/container:inlined_vector",
     ]