commit 246724b0fe1ff48263039acb776dcba89b990bc0
author Harald Alvestrand <hta@webrtc.org> Tue Dec 03 21:31:42 2019
committer Commit Bot <commit-bot@chromium.org> Tue Dec 03 22:57:17 2019
tree 81410f2b47eb42936c2e73823a3f96014c31b858
parent e19a375f8c3ec85b2059af50f41eb71e65b81fd4

Move messaging -> PostTask for freeing datachannels

I could find no reason for the extra complexity of doing messaging
in order to schedule a task to be done after the current cycle.
It also simplifies the peerconnection/datachannelcontroller coupling.

Bug: webrtc:11146
Change-Id: I68f45059b9f4a6869fb44b856e05a480f4652365
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161232
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29997}

pc/data_channel_controller.cc

diff --git a/pc/data_channel_controller.cc b/pc/data_channel_controller.cc
index cc9f1493..0eaf44d 100644
--- a/pc/data_channel_controller.cc
+++ b/pc/data_channel_controller.cc
@@ -348,7 +348,13 @@
       // we can't free it directly here; we need to free it asynchronously.
       sctp_data_channels_to_free_.push_back(*it);
       sctp_data_channels_.erase(it);
-      pc_->SignalFreeDataChannels();
+      signaling_thread()->PostTask(
+          RTC_FROM_HERE, [self = weak_factory_.GetWeakPtr()] {
+            if (self) {
+              RTC_DCHECK_RUN_ON(self->signaling_thread());
+              self->sctp_data_channels_to_free_.clear();
+            }
+          });
       return;
     }
   }

pc/data_channel_controller.h

diff --git a/pc/data_channel_controller.h b/pc/data_channel_controller.h
index bfce16c..91bba66 100644
--- a/pc/data_channel_controller.h
+++ b/pc/data_channel_controller.h
@@ -18,6 +18,7 @@
 
 #include "pc/channel.h"
 #include "pc/data_channel.h"
+#include "rtc_base/weak_ptr.h"
 
 namespace webrtc {
 
@@ -77,12 +78,6 @@
     return !rtp_data_channels_.empty();
   }
 
-  // Called when it's appropriate to delete released datachannels.
-  void FreeDataChannels() {
-    RTC_DCHECK_RUN_ON(signaling_thread());
-    sctp_data_channels_to_free_.clear();
-  }
-
   void UpdateLocalRtpDataChannels(const cricket::StreamParamsVec& streams);
   void UpdateRemoteRtpDataChannels(const cricket::StreamParamsVec& streams);
 
@@ -207,6 +202,7 @@
 
   // Owning PeerConnection.
   PeerConnection* const pc_;
+  rtc::WeakPtrFactory<DataChannelController> weak_factory_{this};
 };
 
 }  // namespace webrtc

pc/peer_connection.cc

diff --git a/pc/peer_connection.cc b/pc/peer_connection.cc
index 855df75..1339638 100644
--- a/pc/peer_connection.cc
+++ b/pc/peer_connection.cc
@@ -136,7 +136,6 @@
   MSG_SET_SESSIONDESCRIPTION_FAILED,
   MSG_CREATE_SESSIONDESCRIPTION_FAILED,
   MSG_GETSTATS,
-  MSG_FREE_DATACHANNELS,
   MSG_REPORT_USAGE_PATTERN,
 };
 
@@ -4496,10 +4495,6 @@
       delete param;
       break;
     }
-    case MSG_FREE_DATACHANNELS: {
-      data_channel_controller_.FreeDataChannels();
-      break;
-    }
     case MSG_REPORT_USAGE_PATTERN: {
       ReportUsagePattern();
       break;
@@ -5676,10 +5671,6 @@
   data_channel_controller_.OnSctpDataChannelClosed(channel);
 }
 
-void PeerConnection::SignalFreeDataChannels() {
-  signaling_thread()->Post(RTC_FROM_HERE, this, MSG_FREE_DATACHANNELS, nullptr);
-}
-
 rtc::scoped_refptr<RtpTransceiverProxyWithInternal<RtpTransceiver>>
 PeerConnection::GetAudioTransceiver() const {
   // This method only works with Plan B SDP, where there is a single

pc/peer_connection.h

diff --git a/pc/peer_connection.h b/pc/peer_connection.h
index 941b744..0e1a1f8 100644
--- a/pc/peer_connection.h
+++ b/pc/peer_connection.h
@@ -317,8 +317,6 @@
   bool GetSctpSslRole(rtc::SSLRole* role);
   // Handler for the "channel closed" signal
   void OnSctpDataChannelClosed(DataChannel* channel);
-  // Sends the MSG_FREE_DATACHANNELS signal
-  void SignalFreeDataChannels();
 
   // Functions made public for testing.
   void ReturnHistogramVeryQuicklyForTesting() {