commit 307f7f37e07e3df6949460697eda680241f67c45
author Mirko Bonadei <mbonadei@webrtc.org> Mon Sep 12 12:38:24 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 12 15:08:47 2022
tree 39f78af0629d245749ac62c32c8ced87dc5c3c7b
parent b88c3b5e02cc50c7dae29f1184b4ee6e7fc58cbc

Fix memcpy nullptr src or dest (UB).

Detected by the new UBSan configurations (crbug.com/1352721):

[ RUN      ] TestDecodingState.FrameContinuity
../../modules/video_coding/session_info.cc:250:10: runtime error: null pointer passed as argument 1, which is declared to never be null
../../build/linux/debian_bullseye_amd64-sysroot/usr/include/string.h:44:28: note: nonnull attribute specified here

No-Try: True
Bug: None
Change-Id: Ib4fb20d948b41da1a35dacb8abe944eb24f806f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275200
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38063}

modules/video_coding/session_info.cc

diff --git a/modules/video_coding/session_info.cc b/modules/video_coding/session_info.cc
index bee763c..854230a 100644
--- a/modules/video_coding/session_info.cc
+++ b/modules/video_coding/session_info.cc
@@ -243,6 +243,9 @@
                               size_t length,
                               bool insert_start_code,
                               uint8_t* frame_buffer) {
+  if (!buffer || !frame_buffer) {
+    return 0;
+  }
   if (insert_start_code) {
     const unsigned char startCode[] = {0, 0, 0, 1};
     memcpy(frame_buffer, startCode, kH264StartCodeLengthBytes);