commit 32c4ecb3db871a73c83ee02e4483f0c2496a68ea
author Byoungchan Lee <daniel.l@hpcnt.com> Thu Oct 28 06:49:46 2021
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 28 13:52:13 2021
tree 44c883d331289c0a28c5d447677dda544cf9421b
parent e5e78c4521b3fc250d02a3ec6209b77c30245773

Fix -Wunused-but-set-variable in sdk/objc.

Bug: None
Change-Id: I7576db57b0a8d86fe7281176956c2efef78c1252
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236540
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35273}

sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm

diff --git a/sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm b/sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm
index 1f0549a..63ba934 100644
--- a/sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm
+++ b/sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm
@@ -25,6 +25,7 @@
 #import "base/RTCVideoDecoderFactory.h"
 #import "base/RTCVideoEncoderFactory.h"
 #import "helpers/NSString+StdString.h"
+#include "rtc_base/checks.h"
 #include "sdk/objc/native/api/network_monitor_factory.h"
 #include "system_wrappers/include/field_trial.h"
 
@@ -118,17 +119,17 @@
     _networkThread = rtc::Thread::CreateWithSocketServer();
     _networkThread->SetName("network_thread", _networkThread.get());
     BOOL result = _networkThread->Start();
-    NSAssert(result, @"Failed to start network thread.");
+    RTC_DCHECK(result) << "Failed to start network thread.";
 
     _workerThread = rtc::Thread::Create();
     _workerThread->SetName("worker_thread", _workerThread.get());
     result = _workerThread->Start();
-    NSAssert(result, @"Failed to start worker thread.");
+    RTC_DCHECK(result) << "Failed to start worker thread.";
 
     _signalingThread = rtc::Thread::Create();
     _signalingThread->SetName("signaling_thread", _signalingThread.get());
     result = _signalingThread->Start();
-    NSAssert(result, @"Failed to start signaling thread.");
+    RTC_DCHECK(result) << "Failed to start signaling thread.";
   }
   return self;
 }

sdk/objc/unittests/RTCPeerConnectionTest.mm

diff --git a/sdk/objc/unittests/RTCPeerConnectionTest.mm b/sdk/objc/unittests/RTCPeerConnectionTest.mm
index 1d0ae26..19b3c8e 100644
--- a/sdk/objc/unittests/RTCPeerConnectionTest.mm
+++ b/sdk/objc/unittests/RTCPeerConnectionTest.mm
@@ -128,7 +128,6 @@
   RTC_OBJC_TYPE(RTCPeerConnectionFactory) *factory =
       [[RTC_OBJC_TYPE(RTCPeerConnectionFactory) alloc] init];
 
-  RTC_OBJC_TYPE(RTCConfiguration) * newConfig;
   std::unique_ptr<webrtc::PeerConnectionDependencies> pc_dependencies =
       std::make_unique<webrtc::PeerConnectionDependencies>(nullptr);
   @autoreleasepool {
@@ -137,7 +136,7 @@
                                     constraints:contraints
                                    dependencies:std::move(pc_dependencies)
                                        delegate:nil];
-    newConfig = peerConnection.configuration;
+    ASSERT_NE(peerConnection, nil);
   }
 }