| commit | 3b35fbcb66fee8af58b0c0990527833f1dcbcd7b | [log] [tgz] |
|---|---|---|
| author | Mirko Bonadei <mbonadei@webrtc.org> | Tue Jul 20 08:37:07 2021 |
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jul 20 09:06:48 2021 |
| tree | 781b2a29b9f673c98ed654452f2e17a22b49eab8 | |
| parent | 022567dc9c184fb44d44473e47e2570d890eaf86 [diff] |
Reland "Make webrtc_fuzzer_test use //:common_config." This is a reland of 9e09831767995531ae1c2804e1c15fa2be4053f2 The field "additional_configs" needs to be used to set "configs" for the "fuzzer_test" GN template. See https://source.chromium.org/chromium/chromium/src/+/main:testing/libfuzzer/fuzzer_test.gni;l=18;drc=825f86aa594207bfc50f87495544b48014814c9d. Original change's description: > Make webrtc_fuzzer_test use //:common_config. > > Before this CL, the GN template webrtc_fuzzer_test was using a build > config that was different from the one used by other WebRTC's targets. > > We discovered this in [1] where we detected that RTC_DCHECK_IS_ON had > different values across translation units (1 everywhere and 0 in the > one of the .cc file owned by the webrtc_fuzzer_test). > > This was because webrtc_fuzzer_test was not including the default > config //:common_config in its "configs". > > [1] - https://webrtc-review.googlesource.com/c/src/+/226465 > > Bug: None > Change-Id: I5635d90281769c23c5d86ebc8cb494da029c2e85 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226540 > Reviewed-by: Andrey Logvin <landrey@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#34509} Bug: None Change-Id: I56e2a7ea811a94762e09953acf3d33d3f46b1d24 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226542 Reviewed-by: Andrey Logvin <landrey@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34511}
diff --git a/test/fuzzers/BUILD.gn b/test/fuzzers/BUILD.gn index 9824beb..201cb49 100644 --- a/test/fuzzers/BUILD.gn +++ b/test/fuzzers/BUILD.gn
@@ -42,6 +42,7 @@ } set_defaults("webrtc_fuzzer_test") { + configs = rtc_add_configs absl_deps = [] } @@ -52,6 +53,7 @@ ":fuzz_data_helper", ":webrtc_fuzzer_main", ] + additional_configs = configs # If absl_deps is [], no action is needed. If not [], then it needs to be # converted to //third_party/abseil-cpp:absl when build_with_chromium=true