commit 45c6f5e2e1762a1abf519d085bca63c9c4d8b9f5
author Artem Titov <titovartem@webrtc.org> Wed Sep 21 12:27:29 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 21 13:30:11 2022
tree 0bf4b885d3544542cc364984b0e787d569c44642
parent b2ccd8526951229ceaaed7033643a27d2cd6ba31

Change StdoutMetricsExporter format to improve readability

Change from
<test case>/<metric name>

to
<test case> / <metric name>

to increase readability when <test case> itself contains "/" or
<metric name> contains "/"

Bug: b/246095034
Change-Id: If870fdcac37275aecf87e7d57e8aada05a5ef454
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276263
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38155}

api/test/metrics/stdout_metrics_exporter.cc

diff --git a/api/test/metrics/stdout_metrics_exporter.cc b/api/test/metrics/stdout_metrics_exporter.cc
index f509591..22243e7 100644
--- a/api/test/metrics/stdout_metrics_exporter.cc
+++ b/api/test/metrics/stdout_metrics_exporter.cc
@@ -79,7 +79,7 @@
 
 void StdoutMetricsExporter::PrintMetric(const Metric& metric) {
   rtc::StringBuilder value_stream;
-  value_stream << metric.test_case << "/" << metric.name << "= {mean=";
+  value_stream << metric.test_case << " / " << metric.name << "= {mean=";
   if (metric.stats.mean.has_value()) {
     AppendWithPrecision(*metric.stats.mean, 8, value_stream);
   } else {

api/test/metrics/stdout_metrics_exporter_test.cc

diff --git a/api/test/metrics/stdout_metrics_exporter_test.cc b/api/test/metrics/stdout_metrics_exporter_test.cc
index 4e460b2..91c06fa 100644
--- a/api/test/metrics/stdout_metrics_exporter_test.cc
+++ b/api/test/metrics/stdout_metrics_exporter_test.cc
@@ -69,9 +69,9 @@
   StdoutMetricsExporter exporter;
 
   std::string expected =
-      "RESULT: test_case_name1/test_metric1= "
+      "RESULT: test_case_name1 / test_metric1= "
       "{mean=15, stddev=5} Milliseconds (BiggerIsBetter)\n"
-      "RESULT: test_case_name2/test_metric2= "
+      "RESULT: test_case_name2 / test_metric2= "
       "{mean=30, stddev=10} KilobitsPerSecond (SmallerIsBetter)\n";
 
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric1, metric2}));
@@ -84,7 +84,7 @@
 
   Metric metric = PsnrForTestFoo(15.00000001, 0.00000001);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=15.00000001, stddev=0.00000001} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -97,7 +97,7 @@
 
   Metric metric = PsnrForTestFoo(15.12345, 0.12);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=15.12345, stddev=0.12} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -110,7 +110,7 @@
 
   Metric metric = PsnrForTestFoo(15.123450000, 0.120000000);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=15.12345, stddev=0.12} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -123,7 +123,7 @@
 
   Metric metric = PsnrForTestFoo(15.000000009, 0.999999999);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=15.00000001, stddev=1} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -136,7 +136,7 @@
 
   Metric metric = PsnrForTestFoo(15.0000000049, 0.9999999949);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=15, stddev=0.99999999} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -148,7 +148,7 @@
 
   Metric metric = PsnrForTestFoo(-15.00000001, -0.00000001);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=-15.00000001, stddev=-0.00000001} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -161,7 +161,7 @@
 
   Metric metric = PsnrForTestFoo(-15.12345, -0.12);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=-15.12345, stddev=-0.12} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -174,7 +174,7 @@
 
   Metric metric = PsnrForTestFoo(-15.123450000, -0.120000000);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=-15.12345, stddev=-0.12} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -187,7 +187,7 @@
 
   Metric metric = PsnrForTestFoo(-15.000000009, -0.999999999);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=-15.00000001, stddev=-1} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());
@@ -200,7 +200,7 @@
 
   Metric metric = PsnrForTestFoo(-15.0000000049, -0.9999999949);
   std::string expected =
-      "RESULT: foo/psnr= "
+      "RESULT: foo / psnr= "
       "{mean=-15, stddev=-0.99999999} Unitless (BiggerIsBetter)\n";
   EXPECT_TRUE(exporter.Export(std::vector<Metric>{metric}));
   EXPECT_EQ(expected, testing::internal::GetCapturedStdout());