Remove has_transport check from ReadyToUseRemoteCandidate.
It turns out that this check always returns 'true' and is
also not safe to do from this thread.
Bug: webrtc:12635
Change-Id: Iebc0097042020707678f3a1ad9c912b227a4257c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213600
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33626}
diff --git a/pc/sdp_offer_answer.cc b/pc/sdp_offer_answer.cc
index 6b8412c..293c5cb 100644
--- a/pc/sdp_offer_answer.cc
+++ b/pc/sdp_offer_answer.cc
@@ -4521,16 +4521,7 @@
return false;
}
- bool has_transport = false;
- cricket::ChannelInterface* channel = pc_->GetChannel(result.value()->name);
- if (channel) {
- has_transport = !channel->transport_name().empty();
- } else if (data_channel_controller()->data_channel_transport()) {
- auto sctp_mid = pc_->sctp_mid();
- RTC_DCHECK(sctp_mid);
- has_transport = (result.value()->name == *sctp_mid);
- }
- return has_transport;
+ return true;
}
RTCErrorOr<const cricket::ContentInfo*> SdpOfferAnswerHandler::FindContentInfo(