commit 56d3cf0c6daa7d0de80c0d3fbf6de246b63ce003
author Danil Chapovalov <danilchap@webrtc.org> Thu Feb 15 17:11:13 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 21 11:07:04 2024
tree b9a75015bbcd68a009d301d421c8c97e03397d77
parent 74a4038eaddcac773b9fc172ad446df6eb704b11

Make VideoDecoderFactory::CreateVideoDecoder private

To ensure CreateVideoDecoder is only used as a fallback when Create is not implemented,
and thus make it safer to migrate VideoDecoderFactory implementations to Create.

Bug: webrtc:15791
Change-Id: Ifb15cf1d303348949ba51a3bb4c91b855a06627f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339841
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41777}

api/video_codecs/video_decoder_factory.h

diff --git a/api/video_codecs/video_decoder_factory.h b/api/video_codecs/video_decoder_factory.h
index 6048cb2..92a2697 100644
--- a/api/video_codecs/video_decoder_factory.h
+++ b/api/video_codecs/video_decoder_factory.h
@@ -55,8 +55,9 @@
   virtual std::unique_ptr<VideoDecoder> Create(const Environment& env,
                                                const SdpVideoFormat& format);
 
-  // TODO: bugs.webrtc.org/15791 - Make private or delete when all callers are
-  // migrated to `Create`.
+ private:
+  // TODO: bugs.webrtc.org/15791 - Delete when all derived classes implement
+  // `Create`.
   virtual std::unique_ptr<VideoDecoder> CreateVideoDecoder(
       const SdpVideoFormat& format);
 };