commit 576ad5d510894040d7bbc041d5c86745c67f30f8
author Marina Ciocea <marinaciocea@webrtc.org> Fri May 15 05:52:51 2020
committer Commit Bot <commit-bot@chromium.org> Fri May 15 17:46:20 2020
tree 31e1435775afb512a1e03f59dd68318439c3c88f
parent 4515a55eed39d5d3440be2420cfcebd96576a43d

Make TransformableVideoFrameInterface::GetMetadata pure virtual.

GetMetadata() has been implemented downstream and can be made pure
virtual.

Bug: chromium:1069295
Change-Id: I62a3be6106552d2d82d8c413c6f523d31626b0d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175001
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31281}

api/frame_transformer_interface.h

diff --git a/api/frame_transformer_interface.h b/api/frame_transformer_interface.h
index 753c7f4..2cfe6ed 100644
--- a/api/frame_transformer_interface.h
+++ b/api/frame_transformer_interface.h
@@ -50,14 +50,7 @@
   // webrtc::RtpDescriptorAuthentication is exposed in api/.
   virtual std::vector<uint8_t> GetAdditionalData() const = 0;
 
-  // TODO(bugs.webrtc.org/11380) make pure virtual after implementating it
-  // downstream.
-  virtual const VideoFrameMetadata& GetMetadata() const { return metadata_; }
-
- private:
-  // TODO(bugs.webrtc.org/11380) remove from interface once GetRtpVideoHeader is
-  // pure virtual.
-  VideoFrameMetadata metadata_;
+  virtual const VideoFrameMetadata& GetMetadata() const = 0;
 };
 
 // Extends the TransformableFrameInterface to expose audio-specific information.

api/video/video_frame_metadata.h

diff --git a/api/video/video_frame_metadata.h b/api/video/video_frame_metadata.h
index ce9b2a1..2e93098 100644
--- a/api/video/video_frame_metadata.h
+++ b/api/video/video_frame_metadata.h
@@ -27,7 +27,6 @@
 class VideoFrameMetadata {
  public:
   explicit VideoFrameMetadata(const RTPVideoHeader& header);
-  VideoFrameMetadata() = default;
   VideoFrameMetadata(const VideoFrameMetadata&) = default;
   VideoFrameMetadata& operator=(const VideoFrameMetadata&) = default;