commit 6c70e16a4aa81cdb5a6714e1fd7befc2fbb79d6a
author Mirko Bonadei <mbonadei@webrtc.org> Fri Feb 01 12:17:43 2019
committer Commit Bot <commit-bot@chromium.org> Fri Feb 01 14:12:43 2019
tree a0403fd1687ded01e1319e738e90b5f9a8aa48b6
parent 4bfbb01e841365c826a8040fcbb2651fbc9b4d96

Fix RTCStatsReport::ConstIterator move constructor.

This problem has been originally discovered by clang-tidy while trying
to apply performance-move-const-arg [1] on [2].

[1] - https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html
[2] - https://webrtc-review.googlesource.com/c/src/+/120350

Bug: webrtc:10252
Change-Id: I2b0a116f78ca8096a6cf2bc23e2f4b8f372ca04f
Reviewed-on: https://webrtc-review.googlesource.com/c/120815
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26512}

api/stats/rtc_stats_report.h

diff --git a/api/stats/rtc_stats_report.h b/api/stats/rtc_stats_report.h
index 2f5b876..85da197 100644
--- a/api/stats/rtc_stats_report.h
+++ b/api/stats/rtc_stats_report.h
@@ -34,7 +34,7 @@
 
   class ConstIterator {
    public:
-    ConstIterator(const ConstIterator&& other);
+    ConstIterator(ConstIterator&& other);
     ~ConstIterator();
 
     ConstIterator& operator++();

stats/rtc_stats_report.cc

diff --git a/stats/rtc_stats_report.cc b/stats/rtc_stats_report.cc
index bdafd56..a56d30d 100644
--- a/stats/rtc_stats_report.cc
+++ b/stats/rtc_stats_report.cc
@@ -23,8 +23,7 @@
     StatsMap::const_iterator it)
     : report_(report), it_(it) {}
 
-RTCStatsReport::ConstIterator::ConstIterator(const ConstIterator&& other)
-    : report_(std::move(other.report_)), it_(std::move(other.it_)) {}
+RTCStatsReport::ConstIterator::ConstIterator(ConstIterator&& other) = default;
 
 RTCStatsReport::ConstIterator::~ConstIterator() {}