commit 7ef34f850584f6fd2de7cebb1d8897ab890a1f5f
author Per Kjellander <perkj@webrtc.org> Fri Feb 22 12:09:32 2019
committer Commit Bot <commit-bot@chromium.org> Fri Feb 22 13:08:18 2019
tree a695636603bffd3dfc2e0856537c806af955e715
parent ce8e8677df1c34cc52c2b5f98818455f4cc4bb0c

Replace field trials with WebRtcKeyValueConfig in PacedSender

Replaces use of field trials in PacedSender with injectable WebRtcKeyValueConfig.
Implementation still defaults to field trials.

BUG: webrtc:10335
Change-Id: Ie8870d93d51e996e762f2c2de7545bad261b6bb7
Reviewed-on: https://webrtc-review.googlesource.com/c/123521
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26818}

modules/pacing/BUILD.gn

diff --git a/modules/pacing/BUILD.gn b/modules/pacing/BUILD.gn
index 7ebd37b..00fde9e 100644
--- a/modules/pacing/BUILD.gn
+++ b/modules/pacing/BUILD.gn
@@ -29,7 +29,9 @@
   deps = [
     ":interval_budget",
     "..:module_api",
+    "../../api/transport:field_trial_based_config",
     "../../api/transport:network_control",
+    "../../api/transport:webrtc_key_value_config",
     "../../logging:rtc_event_bwe",
     "../../logging:rtc_event_log_api",
     "../../logging:rtc_event_pacing",

modules/pacing/DEPS

diff --git a/modules/pacing/DEPS b/modules/pacing/DEPS
index 3088a75..1b2e6dc 100644
--- a/modules/pacing/DEPS
+++ b/modules/pacing/DEPS
@@ -1,4 +1,6 @@
 include_rules = [
-  "+system_wrappers",
+  "+system_wrappers", 
+  # Avoid directly using field_trial. Instead use WebRtcKeyValueConfig.
+  "-system_wrappers/include/field_trial.h",  
   "+logging/rtc_event_log"
 ]

modules/pacing/paced_sender.cc

diff --git a/modules/pacing/paced_sender.cc b/modules/pacing/paced_sender.cc
index 44bb774..70c8ad4 100644
--- a/modules/pacing/paced_sender.cc
+++ b/modules/pacing/paced_sender.cc
@@ -22,8 +22,8 @@
 #include "rtc_base/checks.h"
 #include "rtc_base/logging.h"
 #include "system_wrappers/include/clock.h"
-#include "system_wrappers/include/field_trial.h"
 
+namespace webrtc {
 namespace {
 // Time limit in milliseconds between packet bursts.
 const int64_t kDefaultMinPacketLimitMs = 5;
@@ -35,23 +35,44 @@
 // time.
 const int64_t kMaxIntervalTimeMs = 30;
 
-}  // namespace
+bool IsDisabled(const WebRtcKeyValueConfig& field_trials,
+                absl::string_view key) {
+  return field_trials.Lookup(key).find("Disabled") == 0;
+}
 
-namespace webrtc {
+bool IsEnabled(const WebRtcKeyValueConfig& field_trials,
+               absl::string_view key) {
+  return field_trials.Lookup(key).find("Enabled") == 0;
+}
+
+}  // namespace
 
 const int64_t PacedSender::kMaxQueueLengthMs = 2000;
 const float PacedSender::kDefaultPaceMultiplier = 2.5f;
 
 PacedSender::PacedSender(Clock* clock,
                          PacketSender* packet_sender,
-                         RtcEventLog* event_log)
+                         RtcEventLog* event_log,
+                         const WebRtcKeyValueConfig* field_trials)
+    : PacedSender(clock,
+                  packet_sender,
+                  event_log,
+                  field_trials
+                      ? *field_trials
+                      : static_cast<const webrtc::WebRtcKeyValueConfig&>(
+                            FieldTrialBasedConfig())) {}
+
+PacedSender::PacedSender(Clock* clock,
+                         PacketSender* packet_sender,
+                         RtcEventLog* event_log,
+                         const WebRtcKeyValueConfig& field_trials)
     : clock_(clock),
       packet_sender_(packet_sender),
       alr_detector_(),
-      drain_large_queues_(!field_trial::IsDisabled("WebRTC-Pacer-DrainQueue")),
+      drain_large_queues_(!IsDisabled(field_trials, "WebRTC-Pacer-DrainQueue")),
       send_padding_if_silent_(
-          field_trial::IsEnabled("WebRTC-Pacer-PadInSilence")),
-      pace_audio_(!field_trial::IsDisabled("WebRTC-Pacer-BlockAudio")),
+          IsEnabled(field_trials, "WebRTC-Pacer-PadInSilence")),
+      pace_audio_(!IsDisabled(field_trials, "WebRTC-Pacer-BlockAudio")),
       min_packet_limit_ms_("", kDefaultMinPacketLimitMs),
       last_timestamp_ms_(clock_->TimeInMilliseconds()),
       paused_(false),
@@ -76,7 +97,7 @@
                            "pushback experiment must be enabled.";
   }
   ParseFieldTrial({&min_packet_limit_ms_},
-                  field_trial::FindFullName("WebRTC-Pacer-MinPacketLimitMs"));
+                  field_trials.Lookup("WebRTC-Pacer-MinPacketLimitMs"));
   UpdateBudgetWithElapsedTime(min_packet_limit_ms_);
 }
 

modules/pacing/paced_sender.h

diff --git a/modules/pacing/paced_sender.h b/modules/pacing/paced_sender.h
index 438748f..a6aad24 100644
--- a/modules/pacing/paced_sender.h
+++ b/modules/pacing/paced_sender.h
@@ -17,7 +17,9 @@
 #include <memory>
 
 #include "absl/types/optional.h"
+#include "api/transport/field_trial_based_config.h"
 #include "api/transport/network_types.h"
+#include "api/transport/webrtc_key_value_config.h"
 #include "modules/pacing/bitrate_prober.h"
 #include "modules/pacing/interval_budget.h"
 #include "modules/pacing/pacer.h"
@@ -71,7 +73,8 @@
 
   PacedSender(Clock* clock,
               PacketSender* packet_sender,
-              RtcEventLog* event_log);
+              RtcEventLog* event_log,
+              const WebRtcKeyValueConfig* field_trials = nullptr);
 
   ~PacedSender() override;
 
@@ -147,6 +150,11 @@
   void SetQueueTimeLimit(int limit_ms);
 
  private:
+  PacedSender(Clock* clock,
+              PacketSender* packet_sender,
+              RtcEventLog* event_log,
+              const WebRtcKeyValueConfig& field_trials);
+
   int64_t UpdateTimeAndGetElapsedMs(int64_t now_us)
       RTC_EXCLUSIVE_LOCKS_REQUIRED(critsect_);
   bool ShouldSendKeepalive(int64_t at_time_us) const