commit 8731176b922ad7d82d0407f2ac36d9f5396f9ac2
author Henrik Lundin <henrik.lundin@webrtc.org> Mon Oct 23 09:36:01 2017
committer Commit Bot <commit-bot@chromium.org> Mon Oct 23 11:56:47 2017
tree ed1f15a5e98a29ddbce9967bb25fdcc0d9e78bb3
parent 9155e4986d6d3bea0174e0b1d3c3fccf1ad06960

NetEq: Fix an UBSan error

UBSan will trigger when shifting a negative value. This change avoids
that by replacing "x << 8" with "x * (1 << 8)".

Bug: chromium:666877
Change-Id: Ic89bd98e5a3feff35075df96b104b386cb4d8803
Reviewed-on: https://webrtc-review.googlesource.com/14552
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20387}

modules/audio_coding/neteq/buffer_level_filter.cc

diff --git a/modules/audio_coding/neteq/buffer_level_filter.cc b/modules/audio_coding/neteq/buffer_level_filter.cc
index 5df59c7..6005de6 100644
--- a/modules/audio_coding/neteq/buffer_level_filter.cc
+++ b/modules/audio_coding/neteq/buffer_level_filter.cc
@@ -40,9 +40,9 @@
     // value of |time_stretched_samples| from |filtered_current_level_| after
     // converting |time_stretched_samples| from samples to packets in Q8.
     // Make sure that the filtered value remains non-negative.
-    filtered_current_level_ = std::max(0,
-        filtered_current_level_ -
-        (time_stretched_samples << 8) / static_cast<int>(packet_len_samples));
+    filtered_current_level_ = std::max(
+        0, filtered_current_level_ - (time_stretched_samples * (1 << 8)) /
+                                         static_cast<int>(packet_len_samples));
   }
 }