VAD SplitFilter may overflow integerr. VAD Split filter is design such that, in some specific cases, signed integer overflow can occurs. Those are fine and will only affect the output audio making some clicks and/or digital noise. Bug: webrtc:490331112 Change-Id: Ib4a2eb01a84f6b11e7be0d3df55a892379018178 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/457301 Commit-Queue: Lionel Koenig <lionelk@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/main@{#47173}
diff --git a/common_audio/vad/vad_filterbank.c b/common_audio/vad/vad_filterbank.c index 32830fa0..04cfba9 100644 --- a/common_audio/vad/vad_filterbank.c +++ b/common_audio/vad/vad_filterbank.c
@@ -12,6 +12,7 @@ #include "common_audio/signal_processing/include/signal_processing_library.h" #include "rtc_base/checks.h" +#include "rtc_base/sanitizer.h" // Constants used in LogOfEnergy(). static const int16_t kLogConst = 24660; // 160*log10(2) in Q9. @@ -79,7 +80,8 @@ // - filter_coefficient [i] : Given in Q15. // - filter_state [i/o] : State of the filter given in Q(-1). // - data_out [o] : Output audio signal given in Q(-1). -static void AllPassFilter(const int16_t* data_in, +static void RTC_NO_SANITIZE("signed-integer-overflow") // https://bugs.webrtc.org/490331112 + AllPassFilter(const int16_t* data_in, size_t data_length, int16_t filter_coefficient, int16_t* filter_state,