Delete the AEC3 json config fuzzer The code is test-only nowadays. Additionally, the JSON parser we use is not robust enough for fuzzing the config: It crashes on deep nesting. Bug: chromium:440374794, chromium:441805811, chromium:441805815 Change-Id: Icd6daad3dfc500184c5a9dc3dce0bb15815cb516 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/457240 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/main@{#47267}
diff --git a/test/fuzzers/BUILD.gn b/test/fuzzers/BUILD.gn index e690727..34244b1 100644 --- a/test/fuzzers/BUILD.gn +++ b/test/fuzzers/BUILD.gn
@@ -593,18 +593,6 @@ seed_corpus = "corpora/agc-corpus" } -webrtc_fuzzer_test("aec3_config_json_fuzzer") { - sources = [ "aec3_config_json_fuzzer.cc" ] - deps = [ - ":fuzz_data_helper", - "../../api/audio:aec3_config", - "../../modules/audio_processing:aec3_config_json", - "//third_party/abseil-cpp/absl/strings:string_view", - ] - dict = "//testing/libfuzzer/fuzzers/dicts/json.dict" - seed_corpus = "corpora/aec3-config-json-corpus" -} - webrtc_fuzzer_test("aec3_fuzzer") { defines = [] if (apm_debug_dump) { @@ -818,7 +806,6 @@ group("fuzzers") { testonly = true deps = [ - ":aec3_config_json_fuzzer", ":aec3_fuzzer", ":agc_fuzzer", ":audio_decoder_fuzzer",
diff --git a/test/fuzzers/aec3_config_json_fuzzer.cc b/test/fuzzers/aec3_config_json_fuzzer.cc deleted file mode 100644 index 0eb19e9..0000000 --- a/test/fuzzers/aec3_config_json_fuzzer.cc +++ /dev/null
@@ -1,31 +0,0 @@ -/* - * Copyright (c) 2019 The WebRTC project authors. All Rights Reserved. - * - * Use of this source code is governed by a BSD-style license - * that can be found in the LICENSE file in the root of the source - * tree. An additional intellectual property rights grant can be found - * in the file PATENTS. All contributing project authors may - * be found in the AUTHORS file in the root of the source tree. - */ - -#include <cstddef> - -#include "absl/strings/string_view.h" -#include "api/audio/echo_canceller3_config.h" -#include "modules/audio_processing/test/echo_canceller3_config_json.h" -#include "test/fuzzers/fuzz_data_helper.h" - -namespace webrtc { -void FuzzOneInput(FuzzDataHelper fuzz_data) { - if (fuzz_data.size() > 10'000) { - return; - } - absl::string_view config_json = fuzz_data.ReadString(); - - EchoCanceller3Config config; - bool success; - Aec3ConfigFromJsonString(config_json, &config, &success); - EchoCanceller3Config::Validate(&config); -} - -} // namespace webrtc
diff --git a/test/fuzzers/corpora/aec3-config-json-corpus/default.json b/test/fuzzers/corpora/aec3-config-json-corpus/default.json deleted file mode 100644 index 4dcbcee..0000000 --- a/test/fuzzers/corpora/aec3-config-json-corpus/default.json +++ /dev/null
@@ -1 +0,0 @@ -{"aec3": {"buffering": {"excess_render_detection_interval_blocks": 250,"max_allowed_excess_render_blocks": 8},"delay": {"default_delay": 5,"down_sampling_factor": 4,"num_filters": 5,"delay_headroom_samples": 32,"hysteresis_limit_blocks": 1,"fixed_capture_delay_samples": 0,"delay_estimate_smoothing": 0.7,"delay_candidate_detection_threshold": 0.2,"delay_selection_thresholds": {"initial": 5,"converged": 20},"use_external_delay_estimator": false,"downmix_before_delay_estimation": true,"log_warning_on_delay_changes": false},"filter": {"main": [13,5e-05,0.05,0.001,2,2.00753e+07],"shadow": [13,0.7,2.00753e+07],"main_initial": [12,0.005,0.5,0.001,2,2.00753e+07],"shadow_initial": [12,0.9,2.00753e+07],"config_change_duration_blocks": 250,"initial_state_seconds": 2.5,"conservative_initial_phase": false,"enable_shadow_filter_output_usage": true},"erle": {"min": 1,"max_l": 4,"max_h": 1.5,"onset_detection": true,"num_sections": 1,"clamp_quality_estimate_to_zero": true,"clamp_quality_estimate_to_one": true},"ep_strength": {"default_gain": 1,"default_len": 0.83,"echo_can_saturate": true,"bounded_erl": false},"echo_audibility": {"low_render_limit": 256,"normal_render_limit": 64,"floor_power": 128,"audibility_threshold_lf": 10,"audibility_threshold_mf": 10,"audibility_threshold_hf": 10,"use_stationarity_properties": false,"use_stationarity_properties_at_init": false},"render_levels": {"active_render_limit": 100,"poor_excitation_render_limit": 150,"poor_excitation_render_limit_ds8": 20},"echo_removal_control": {"has_clock_drift": false,"linear_and_stable_echo_path": false},"echo_model": {"noise_floor_hold": 50,"min_noise_floor_power": 1.6384e+06,"stationary_gate_slope": 10,"noise_gate_power": 27509.4,"noise_gate_slope": 0.3,"render_pre_window_size": 1,"render_post_window_size": 1},"suppressor": {"nearend_average_blocks": 4,"normal_tuning": {"mask_lf": [0.3,0.4,0.3],"mask_hf": [0.07,0.1,0.3],"max_inc_factor": 2,"max_dec_factor_lf": 0.25},"nearend_tuning": {"mask_lf": [1.09,1.1,0.3],"mask_hf": [0.1,0.3,0.3],"max_inc_factor": 2,"max_dec_factor_lf": 0.25},"dominant_nearend_detection": {"enr_threshold": 0.25,"enr_exit_threshold": 10,"snr_threshold": 30,"hold_duration": 50,"trigger_threshold": 12,"use_during_initial_phase": 1},"high_bands_suppression": {"enr_threshold": 1,"max_gain_during_echo": 1},"floor_first_increase": 1e-05,"enforce_transparent": false,"enforce_empty_higher_bands": false}}}