commit 98d9c306efbeb487a36c59116c1c5f5b959c3cc4
author Niels Möller <nisse@webrtc.org> Wed Dec 16 10:53:09 2020
committer Commit Bot <commit-bot@chromium.org> Wed Dec 16 14:01:02 2020
tree cec6124caeedc4d1ca966e7356fd5f6e2c29800f
parent 7bb3afac79f8da7ae30658b0decae2401e14bd42

Don't instantiate any CallStats object in RtpVideoSender tests

Tests appear to not depend on any CallStats behaviour, and the usage
is not compatible with the threading requirements of the new
internal::CallStats class.

Bug: webrtc:11581
Change-Id: I8802a46842930eb58bd7609bcd8384ae97e3cf59
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/197814
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32847}

call/rtp_video_sender_unittest.cc

diff --git a/call/rtp_video_sender_unittest.cc b/call/rtp_video_sender_unittest.cc
index 5ea4034..5b14a93 100644
--- a/call/rtp_video_sender_unittest.cc
+++ b/call/rtp_video_sender_unittest.cc
@@ -30,7 +30,6 @@
 #include "test/mock_transport.h"
 #include "test/scenario/scenario.h"
 #include "test/time_controller/simulated_time_controller.h"
-#include "video/call_stats.h"
 #include "video/send_delay_stats.h"
 #include "video/send_statistics_proxy.h"
 
@@ -136,8 +135,6 @@
             time_controller_.CreateProcessThread("PacerThread"),
             time_controller_.GetTaskQueueFactory(),
             &field_trials_),
-        process_thread_(time_controller_.CreateProcessThread("test_thread")),
-        call_stats_(time_controller_.GetClock(), process_thread_.get()),
         stats_proxy_(time_controller_.GetClock(),
                      config_,
                      VideoEncoderConfig::ContentType::kRealtimeVideo),
@@ -148,7 +145,7 @@
     router_ = std::make_unique<RtpVideoSender>(
         time_controller_.GetClock(), suspended_ssrcs, suspended_payload_states,
         config_.rtp, config_.rtcp_report_interval_ms, &transport_,
-        CreateObservers(&call_stats_, &encoder_feedback_, &stats_proxy_,
+        CreateObservers(nullptr, &encoder_feedback_, &stats_proxy_,
                         &stats_proxy_, &stats_proxy_, &stats_proxy_,
                         frame_count_observer, &stats_proxy_, &stats_proxy_,
                         &send_delay_stats_),
@@ -196,9 +193,6 @@
   BitrateConstraints bitrate_config_;
   const FieldTrialBasedConfig field_trials_;
   RtpTransportControllerSend transport_controller_;
-  std::unique_ptr<ProcessThread> process_thread_;
-  // TODO(tommi): Use internal::CallStats.
-  CallStats call_stats_;
   SendStatisticsProxy stats_proxy_;
   RateLimiter retransmission_rate_limiter_;
   std::unique_ptr<RtpVideoSender> router_;