commit 9fd2908f2eea51a5c86fece14fc24fb46b7404e0
author Jonas Olsson <jonasolsson@webrtc.org> Wed Aug 21 09:18:11 2019
committer Commit Bot <commit-bot@chromium.org> Thu Aug 22 09:01:54 2019
tree cf60429b5372aa81ac650a2958185abe449794e2
parent df578330b8a0b1a003a37ca34253e7344caf17f4

Remove unused framerate parameter from simulcast bitrate allocator.

It's not removed from VideoBitrateAllocationParameters as that struct
is part of the API.

Bug: webrtc:9883
Change-Id: I69f683e3c1dc3a0edc1711f6289514b86b05ad77
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149815
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28935}

modules/video_coding/utility/simulcast_rate_allocator.cc

diff --git a/modules/video_coding/utility/simulcast_rate_allocator.cc b/modules/video_coding/utility/simulcast_rate_allocator.cc
index 1124241..5929572 100644
--- a/modules/video_coding/utility/simulcast_rate_allocator.cc
+++ b/modules/video_coding/utility/simulcast_rate_allocator.cc
@@ -69,8 +69,7 @@
   VideoBitrateAllocation allocated_bitrates_bps;
   DistributeAllocationToSimulcastLayers(parameters.total_bitrate.bps(),
                                         &allocated_bitrates_bps);
-  DistributeAllocationToTemporalLayers(std::ceil(parameters.framerate),
-                                       &allocated_bitrates_bps);
+  DistributeAllocationToTemporalLayers(&allocated_bitrates_bps);
   return allocated_bitrates_bps;
 }
 
@@ -187,7 +186,6 @@
 }
 
 void SimulcastRateAllocator::DistributeAllocationToTemporalLayers(
-    uint32_t framerate,
     VideoBitrateAllocation* allocated_bitrates_bps) const {
   const int num_spatial_streams =
       std::max(1, static_cast<int>(codec_.numberOfSimulcastStreams));
@@ -237,10 +235,10 @@
     } else {
       if (conference_screenshare_mode) {
         tl_allocation = ScreenshareTemporalLayerAllocation(
-            target_bitrate_kbps, max_bitrate_kbps, framerate, simulcast_id);
+            target_bitrate_kbps, max_bitrate_kbps, simulcast_id);
       } else {
         tl_allocation = DefaultTemporalLayerAllocation(
-            target_bitrate_kbps, max_bitrate_kbps, framerate, simulcast_id);
+            target_bitrate_kbps, max_bitrate_kbps, simulcast_id);
       }
     }
     RTC_DCHECK_GT(tl_allocation.size(), 0);
@@ -262,7 +260,6 @@
 std::vector<uint32_t> SimulcastRateAllocator::DefaultTemporalLayerAllocation(
     int bitrate_kbps,
     int max_bitrate_kbps,
-    int framerate,
     int simulcast_id) const {
   const size_t num_temporal_layers = NumTemporalStreams(simulcast_id);
   std::vector<uint32_t> bitrates;
@@ -294,11 +291,10 @@
 SimulcastRateAllocator::ScreenshareTemporalLayerAllocation(
     int bitrate_kbps,
     int max_bitrate_kbps,
-    int framerate,
     int simulcast_id) const {
   if (simulcast_id > 0) {
     return DefaultTemporalLayerAllocation(bitrate_kbps, max_bitrate_kbps,
-                                          framerate, simulcast_id);
+                                          simulcast_id);
   }
   std::vector<uint32_t> allocation;
   allocation.push_back(bitrate_kbps);

modules/video_coding/utility/simulcast_rate_allocator.h

diff --git a/modules/video_coding/utility/simulcast_rate_allocator.h b/modules/video_coding/utility/simulcast_rate_allocator.h
index ea9211b..efbe514 100644
--- a/modules/video_coding/utility/simulcast_rate_allocator.h
+++ b/modules/video_coding/utility/simulcast_rate_allocator.h
@@ -39,16 +39,13 @@
       uint32_t total_bitrate_bps,
       VideoBitrateAllocation* allocated_bitrates_bps);
   void DistributeAllocationToTemporalLayers(
-      uint32_t framerate,
       VideoBitrateAllocation* allocated_bitrates_bps) const;
   std::vector<uint32_t> DefaultTemporalLayerAllocation(int bitrate_kbps,
                                                        int max_bitrate_kbps,
-                                                       int framerate,
                                                        int simulcast_id) const;
   std::vector<uint32_t> ScreenshareTemporalLayerAllocation(
       int bitrate_kbps,
       int max_bitrate_kbps,
-      int framerate,
       int simulcast_id) const;
   int NumTemporalStreams(size_t simulcast_id) const;