[AEC3] Remove unused GetConfiguration from NeuralResidualEchoEstimator This method was not used anywhere in the codebase and its removal simplifies the interface. Bug: webrtc:442444736 No-Iwyu: Not changing the tflite includes. Change-Id: I0d98b9e636eea8b1b0e05dc8d1e4667c7357fa38 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/464022 Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org> Cr-Commit-Position: refs/heads/main@{#47423}
diff --git a/api/audio/neural_residual_echo_estimator.h b/api/audio/neural_residual_echo_estimator.h index 974bc67..03da2f1 100644 --- a/api/audio/neural_residual_echo_estimator.h +++ b/api/audio/neural_residual_echo_estimator.h
@@ -54,9 +54,6 @@ std::span<std::array<float, 65>> R2, std::span<std::array<float, 65>> R2_unbounded) = 0; - // Returns a recommended AEC3 configuration for this estimator. - virtual EchoCanceller3Config GetConfiguration(bool multi_channel) const = 0; - // Adjusts the provided AEC3 suppressor configuration based on the estimator's // requirements. virtual EchoCanceller3Config::Suppressor AdjustConfig(
diff --git a/modules/audio_processing/aec3/echo_canceller3_unittest.cc b/modules/audio_processing/aec3/echo_canceller3_unittest.cc index a27b3e8..0f22c1e 100644 --- a/modules/audio_processing/aec3/echo_canceller3_unittest.cc +++ b/modules/audio_processing/aec3/echo_canceller3_unittest.cc
@@ -1191,10 +1191,6 @@ return residual_echo_estimate_requested_; } - EchoCanceller3Config GetConfiguration(bool multi_channel) const override { - return EchoCanceller3Config(); - } - EchoCanceller3Config::Suppressor AdjustConfig( const EchoCanceller3Config::Suppressor& config) const override { return config;
diff --git a/modules/audio_processing/aec3/neural_residual_echo_estimator/neural_residual_echo_estimator_impl.cc b/modules/audio_processing/aec3/neural_residual_echo_estimator/neural_residual_echo_estimator_impl.cc index a18f1e5..88d6b05 100644 --- a/modules/audio_processing/aec3/neural_residual_echo_estimator/neural_residual_echo_estimator_impl.cc +++ b/modules/audio_processing/aec3/neural_residual_echo_estimator/neural_residual_echo_estimator_impl.cc
@@ -566,14 +566,6 @@ } } -EchoCanceller3Config NeuralResidualEchoEstimatorImpl::GetConfiguration( - bool multi_channel) const { - EchoCanceller3Config config; - config.suppressor = AdjustConfig(config.suppressor); - config.filter.enable_coarse_filter_output_usage = false; - return config; -} - EchoCanceller3Config::Suppressor NeuralResidualEchoEstimatorImpl::AdjustConfig( const EchoCanceller3Config::Suppressor& suppressor_config) const { EchoCanceller3Config::Suppressor adjusted_suppressor_config =
diff --git a/modules/audio_processing/aec3/neural_residual_echo_estimator/neural_residual_echo_estimator_impl.h b/modules/audio_processing/aec3/neural_residual_echo_estimator/neural_residual_echo_estimator_impl.h index f92358e..e72629e 100644 --- a/modules/audio_processing/aec3/neural_residual_echo_estimator/neural_residual_echo_estimator_impl.h +++ b/modules/audio_processing/aec3/neural_residual_echo_estimator/neural_residual_echo_estimator_impl.h
@@ -80,7 +80,6 @@ std::span<std::array<float, kFftLengthBy2Plus1>> R2, std::span<std::array<float, kFftLengthBy2Plus1>> R2_unbounded) override; - EchoCanceller3Config GetConfiguration(bool multi_channel) const override; EchoCanceller3Config::Suppressor AdjustConfig( const EchoCanceller3Config::Suppressor& config) const override;