commit a782022d6ccd7b098881a3d3b1da1dad703e0045
author Danil Chapovalov <danilchap@webrtc.org> Tue Jan 12 10:44:05 2021
committer Commit Bot <commit-bot@chromium.org> Tue Jan 12 12:36:43 2021
tree 9f94dbb71840cf855e4ad2c071fa1d3666a13603
parent a68bfc5537fab1d32be9ec142a33c499b6784d37

Use rtc::CopyOnWriteBuffer::MutableData instead of data in fuzzers

Bug: webrtc:12334
Change-Id: I3df42998f5cf5c3b09ad3f6253cab34170d725bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201380
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32947}

test/fuzzers/flexfec_header_reader_fuzzer.cc

diff --git a/test/fuzzers/flexfec_header_reader_fuzzer.cc b/test/fuzzers/flexfec_header_reader_fuzzer.cc
index 7d710d9..854cc8b 100644
--- a/test/fuzzers/flexfec_header_reader_fuzzer.cc
+++ b/test/fuzzers/flexfec_header_reader_fuzzer.cc
@@ -27,7 +27,7 @@
       std::min(size, static_cast<size_t>(IP_PACKET_SIZE));
   packet.pkt->data.SetSize(packet_size);
   packet.pkt->data.EnsureCapacity(IP_PACKET_SIZE);
-  memcpy(packet.pkt->data.data(), data, packet_size);
+  memcpy(packet.pkt->data.MutableData(), data, packet_size);
 
   FlexfecHeaderReader flexfec_reader;
   flexfec_reader.ReadFecHeader(&packet);

test/fuzzers/forward_error_correction_fuzzer.cc

diff --git a/test/fuzzers/forward_error_correction_fuzzer.cc b/test/fuzzers/forward_error_correction_fuzzer.cc
index 09009e1..04a459b 100644
--- a/test/fuzzers/forward_error_correction_fuzzer.cc
+++ b/test/fuzzers/forward_error_correction_fuzzer.cc
@@ -57,7 +57,7 @@
     recovered_packet->pkt = rtc::scoped_refptr<ForwardErrorCorrection::Packet>(
         new ForwardErrorCorrection::Packet());
     recovered_packet->pkt->data.SetSize(kPacketSize);
-    memset(recovered_packet->pkt->data.data(), 0, kPacketSize);
+    memset(recovered_packet->pkt->data.MutableData(), 0, kPacketSize);
     recovered_packet->ssrc = kMediaSsrc;
     recovered_packet->seq_num = media_seqnum++;
     recovered_packets.emplace_back(recovered_packet);
@@ -69,7 +69,7 @@
       new ForwardErrorCorrection::Packet());
   received_packet.pkt->data.SetSize(kPacketSize);
   received_packet.pkt->data.EnsureCapacity(IP_PACKET_SIZE);
-  uint8_t* packet_buffer = received_packet.pkt->data.data();
+  uint8_t* packet_buffer = received_packet.pkt->data.MutableData();
   uint8_t reordering;
   uint16_t seq_num_diff;
   uint8_t packet_type;

test/fuzzers/ulpfec_generator_fuzzer.cc

diff --git a/test/fuzzers/ulpfec_generator_fuzzer.cc b/test/fuzzers/ulpfec_generator_fuzzer.cc
index 9426ef0..43d9450 100644
--- a/test/fuzzers/ulpfec_generator_fuzzer.cc
+++ b/test/fuzzers/ulpfec_generator_fuzzer.cc
@@ -45,9 +45,9 @@
     packet.EnsureCapacity(IP_PACKET_SIZE);
     // Write a valid parsable header (version = 2, no padding, no extensions,
     // no CSRCs).
-    ByteWriter<uint8_t>::WriteBigEndian(&packet[0], 2 << 6);
+    ByteWriter<uint8_t>::WriteBigEndian(packet.MutableData(), 2 << 6);
     // Make sure sequence numbers are increasing.
-    ByteWriter<uint16_t>::WriteBigEndian(&packet[2], seq_num++);
+    ByteWriter<uint16_t>::WriteBigEndian(packet.MutableData() + 2, seq_num++);
     i += payload_size + rtp_header_length;
     const bool protect = data[i++] % 2 == 1;
 

test/fuzzers/ulpfec_header_reader_fuzzer.cc

diff --git a/test/fuzzers/ulpfec_header_reader_fuzzer.cc b/test/fuzzers/ulpfec_header_reader_fuzzer.cc
index 570fa32..243cb4e 100644
--- a/test/fuzzers/ulpfec_header_reader_fuzzer.cc
+++ b/test/fuzzers/ulpfec_header_reader_fuzzer.cc
@@ -27,7 +27,7 @@
       std::min(size, static_cast<size_t>(IP_PACKET_SIZE));
   packet.pkt->data.SetSize(packet_size);
   packet.pkt->data.EnsureCapacity(IP_PACKET_SIZE);
-  memcpy(packet.pkt->data.data(), data, packet_size);
+  memcpy(packet.pkt->data.MutableData(), data, packet_size);
 
   UlpfecHeaderReader ulpfec_reader;
   ulpfec_reader.ReadFecHeader(&packet);