| commit | acae9abe2e45d53eaf9992246376c8ac904b6a9d | [log] [tgz] |
|---|---|---|
| author | Alex Loiko <aleloi@webrtc.org> | Tue Apr 23 13:26:49 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 23 13:51:15 2019 |
| tree | 8a328cf94839cad862757fb4872318c711387b80 | |
| parent | c1d209258a898d93f555f68a2df1f2a940ed7b33 [diff] |
'Fixing' a few TODOs by removing them. The one with enum.IntFlag is not feasible. An attempt is done here: https://webrtc-review.googlesource.com/c/src/+/133884 It requires re-writing QualityAssessment to Python3 which is too much work for little benefit. (I tried, but couldn't get the unit-tests to pass for both 2 and 3.) The second one is not a real todo. TBR=alessiob@webrtc.org NOPRESUBMIT=True Bug=None NOTRY=True Change-Id: Ia25817533cd504c30490f86e4058f0b2d59dd39c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133908 Commit-Queue: Alex Loiko <aleloi@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27715}
diff --git a/modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py b/modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py index ca5bd1f..1f7afe2 100644 --- a/modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py +++ b/modules/audio_processing/test/py_quality_assessment/quality_assessment/annotations.py
@@ -33,7 +33,6 @@ """Extracts annotations from audio files. """ - # TODO(aleloi): change to enum.IntEnum when py 3.6 is available. class VadType(object): ENERGY_THRESHOLD = 1 # TODO(alessiob): Consider switching to P56 standard. WEBRTC_COMMON_AUDIO = 2 # common_audio/vad/include/vad.h
diff --git a/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py b/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py index 7296745..86b2bd2 100644 --- a/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py +++ b/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py
@@ -350,7 +350,6 @@ self._input_frequency = None def _Run(self, output_path): - # TODO(aleloi): Integrate changes made locally. self._CheckInputSignal() self._LoadTestedSignal()