| commit | aec979412042429623b04f6a3607a771c6246d07 | [log] [tgz] |
|---|---|---|
| author | Piotr (Peter) Slatala <psla@webrtc.org> | Thu Feb 14 17:48:43 2019 |
| committer | Peter Slatala <psla@webrtc.org> | Thu Feb 14 18:11:19 2019 |
| tree | 7612b161301d948448f018351818ac5f8ef751d0 | |
| parent | 9e2692c2902b438cb5f9806bfdbe25b77e90225c [diff] |
Fix DCHECK when encoding GenericPacket* events using the legacy RTC event log format. Bug: webrtc:10319 Change-Id: I6764072281b8d66a8e4a5b2c0e547af3bfddda37 Reviewed-on: https://webrtc-review.googlesource.com/c/123121 Commit-Queue: Peter Slatala <psla@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26693}
diff --git a/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc b/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc index 4e8529c..dac054c 100644 --- a/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc +++ b/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc
@@ -365,8 +365,8 @@ case RtcEvent::Type::GenericPacketReceived: case RtcEvent::Type::GenericPacketSent: case RtcEvent::Type::GenericAckReceived: - // These are unsupported in the old format. - break; + // These are unsupported in the old format, but shouldn't crash. + return ""; } int event_type = static_cast<int>(event.GetType());