commit b6458e1af240ee23f9f0ebc0d769c774d181aa05
author Artem Titov <titovartem@webrtc.org> Thu Jan 31 13:42:57 2019
committer Commit Bot <commit-bot@chromium.org> Thu Jan 31 14:16:11 2019
tree 14333a184ef8b0c7e90db116f7cd3ad0ecfaf4e6
parent c84f661b10ef4104ba28e27578b72a87ae1754ff

Switch test on audio stream instead of data channel.

Create audio stream instead of data channel to check compatibility of
network layer with PeerConnection. Replacement is done because there is
a data race inside data channel sctp transport. This CL will fix
bot behavior. Further data race investigation will be done in this
bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=10268

Bug: webrtc:10268, webrtc:10138
Change-Id: I4f7a1116c65dbf4a3508b7d81d654ccd320795f0
Reviewed-on: https://webrtc-review.googlesource.com/c/120807
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26495}

test/scenario/network/network_emulation_pc_unittest.cc

diff --git a/test/scenario/network/network_emulation_pc_unittest.cc b/test/scenario/network/network_emulation_pc_unittest.cc
index 105cb56..f2fcb07 100644
--- a/test/scenario/network/network_emulation_pc_unittest.cc
+++ b/test/scenario/network/network_emulation_pc_unittest.cc
@@ -159,8 +159,11 @@
   network_manager.Start();
 
   signaling_thread->Invoke<void>(RTC_FROM_HERE, [&]() {
-    rtc::scoped_refptr<DataChannelInterface> channel =
-        alice->CreateDataChannel("data");
+    rtc::scoped_refptr<webrtc::AudioSourceInterface> source =
+        alice_pcf->CreateAudioSource(cricket::AudioOptions());
+    rtc::scoped_refptr<AudioTrackInterface> track =
+        alice_pcf->CreateAudioTrack("audio", source);
+    alice->AddTransceiver(track);
 
     // Connect peers.
     ASSERT_TRUE(alice->ExchangeOfferAnswerWith(bob.get()));
@@ -180,13 +183,6 @@
     ASSERT_TRUE_WAIT(bob->IsIceConnected(), kDefaultTimeoutMs);
     ASSERT_TRUE_WAIT(alice->IsIceConnected(), kDefaultTimeoutMs);
 
-    ASSERT_TRUE_WAIT(bob->observer()->last_datachannel_ != nullptr,
-                     kDefaultTimeoutMs);
-    MockDataChannelObserver observer(bob->observer()->last_datachannel_);
-    channel->Send(DataBuffer("Test data"));
-    ASSERT_TRUE_WAIT(observer.received_message_count() == 1, kDefaultTimeoutMs);
-    ASSERT_EQ("Test data", observer.last_message());
-
     // Close peer connections
     alice->pc()->Close();
     bob->pc()->Close();