Removing usage of //build/config/compiler:no_size_t_to_int_warning.
Bug: webrtc:9251, webrtc:1348
Change-Id: I76e52abbfab5666cad73044b49172a9799539108
Reviewed-on: https://webrtc-review.googlesource.com/84144
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23686}diff --git a/common_video/BUILD.gn b/common_video/BUILD.gn
index 44e2170..650b6ad 100644
--- a/common_video/BUILD.gn
+++ b/common_video/BUILD.gn
@@ -99,9 +99,6 @@
"libyuv/libyuv_unittest.cc",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
diff --git a/modules/audio_processing/BUILD.gn b/modules/audio_processing/BUILD.gn
index c361976..ae6118c 100644
--- a/modules/audio_processing/BUILD.gn
+++ b/modules/audio_processing/BUILD.gn
@@ -168,9 +168,6 @@
defines += [ "WEBRTC_NS_FLOAT" ]
}
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
deps += [
"../../common_audio",
"../../common_audio:fir_filter",
@@ -420,9 +417,6 @@
} else {
sources += [ "aecm/aecm_core_c.cc" ]
}
-
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
if (rtc_include_tests) {
diff --git a/modules/audio_processing/aec3/BUILD.gn b/modules/audio_processing/aec3/BUILD.gn
index 3cd28f3..f6b8ad0 100644
--- a/modules/audio_processing/aec3/BUILD.gn
+++ b/modules/audio_processing/aec3/BUILD.gn
@@ -125,8 +125,6 @@
"../../../system_wrappers:metrics_api",
"//third_party/abseil-cpp/absl/types:optional",
]
-
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
if (rtc_include_tests) {
@@ -202,7 +200,5 @@
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
-
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
}
diff --git a/modules/bitrate_controller/BUILD.gn b/modules/bitrate_controller/BUILD.gn
index 6c47856..d45b724 100644
--- a/modules/bitrate_controller/BUILD.gn
+++ b/modules/bitrate_controller/BUILD.gn
@@ -23,10 +23,6 @@
} else {
defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
}
-
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
diff --git a/modules/congestion_controller/BUILD.gn b/modules/congestion_controller/BUILD.gn
index f4d1f7a..423f170 100644
--- a/modules/congestion_controller/BUILD.gn
+++ b/modules/congestion_controller/BUILD.gn
@@ -30,9 +30,6 @@
"send_side_congestion_controller.cc",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
diff --git a/modules/congestion_controller/goog_cc/BUILD.gn b/modules/congestion_controller/goog_cc/BUILD.gn
index fad65ef..554a83c 100644
--- a/modules/congestion_controller/goog_cc/BUILD.gn
+++ b/modules/congestion_controller/goog_cc/BUILD.gn
@@ -29,9 +29,6 @@
"probe_controller.h",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
diff --git a/modules/congestion_controller/rtp/BUILD.gn b/modules/congestion_controller/rtp/BUILD.gn
index 3b36691..25b200d 100644
--- a/modules/congestion_controller/rtp/BUILD.gn
+++ b/modules/congestion_controller/rtp/BUILD.gn
@@ -26,9 +26,6 @@
"send_side_congestion_controller.cc",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
diff --git a/modules/pacing/BUILD.gn b/modules/pacing/BUILD.gn
index a8b6e3f..2b41eee 100644
--- a/modules/pacing/BUILD.gn
+++ b/modules/pacing/BUILD.gn
@@ -82,8 +82,6 @@
"../rtp_rtcp:rtp_rtcp_format",
]
- # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
diff --git a/modules/rtp_rtcp/BUILD.gn b/modules/rtp_rtcp/BUILD.gn
index 6d39e9e..f19b328 100644
--- a/modules/rtp_rtcp/BUILD.gn
+++ b/modules/rtp_rtcp/BUILD.gn
@@ -224,9 +224,6 @@
"../remote_bitrate_estimator",
"//third_party/abseil-cpp/absl/types:optional",
]
-
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
rtc_source_set("rtcp_transceiver") {
@@ -271,9 +268,6 @@
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
]
-
- # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
rtc_source_set("mock_rtp_rtcp") {
@@ -434,8 +428,5 @@
"../audio_coding:audio_format_conversion",
"//third_party/abseil-cpp/absl/types:optional",
]
-
- # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
}
diff --git a/modules/video_coding/BUILD.gn b/modules/video_coding/BUILD.gn
index ad2a034..f247ac9 100644
--- a/modules/video_coding/BUILD.gn
+++ b/modules/video_coding/BUILD.gn
@@ -45,9 +45,6 @@
"nack_module.h",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -144,9 +141,6 @@
"video_sender.cc",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -399,9 +393,6 @@
"codecs/vp8/temporal_layers.h",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -440,9 +431,6 @@
"codecs/vp8/libvpx_vp8_encoder.h",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -481,9 +469,6 @@
"codecs/vp9/svc_rate_allocator.h",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -895,9 +880,6 @@
if (rtc_build_libvpx) {
deps += [ rtc_libvpx_dir ]
}
-
- # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
diff --git a/pc/BUILD.gn b/pc/BUILD.gn
index 5509a0c..afa08a3 100644
--- a/pc/BUILD.gn
+++ b/pc/BUILD.gn
@@ -473,9 +473,6 @@
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
deps = [
":peerconnection",
":rtc_pc_base",
diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn
index f99be15..6d200da 100644
--- a/rtc_tools/BUILD.gn
+++ b/rtc_tools/BUILD.gn
@@ -145,9 +145,6 @@
"frame_editing/frame_editing_lib.h",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -330,9 +327,6 @@
"simple_command_line_parser_unittest.cc",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
diff --git a/sdk/android/BUILD.gn b/sdk/android/BUILD.gn
index 9522785..031a20f 100644
--- a/sdk/android/BUILD.gn
+++ b/sdk/android/BUILD.gn
@@ -333,9 +333,6 @@
"src/jni/yuvhelper.cc",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (rtc_use_builtin_sw_codecs) {
sources += [
"src/jni/androidmediacodeccommon.h",
@@ -554,9 +551,6 @@
]
}
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
deps = [
":base_jni",
":generated_external_classes_jni",
diff --git a/system_wrappers/BUILD.gn b/system_wrappers/BUILD.gn
index af778fd..9b178f9 100644
--- a/system_wrappers/BUILD.gn
+++ b/system_wrappers/BUILD.gn
@@ -83,9 +83,6 @@
defines += [ "WEBRTC_THREAD_RR" ]
}
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (is_win) {
libs += [ "winmm.lib" ]
@@ -218,12 +215,9 @@
"source/ntp_time_unittest.cc",
"source/rtp_to_ntp_estimator_unittest.cc",
]
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
if (is_posix || is_fuchsia) {
- sources += [
- "source/event_timer_posix_unittest.cc",
- ]
+ sources += [ "source/event_timer_posix_unittest.cc" ]
}
if (!build_with_chromium && is_clang) {
diff --git a/test/BUILD.gn b/test/BUILD.gn
index 60d725b..00304a8 100644
--- a/test/BUILD.gn
+++ b/test/BUILD.gn
@@ -338,9 +338,6 @@
"testsupport/yuv_frame_writer_unittest.cc",
]
- # TODO(jschuh): Bug 1348: fix this warning.
- configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
