commit bfc991166112b62f593b040398f981bc9a721cbd
author Mirko Bonadei <mbonadei@webrtc.org> Sat Feb 02 23:08:18 2019
committer Commit Bot <commit-bot@chromium.org> Mon Feb 04 19:46:30 2019
tree dcaceed24ae9a77c61af876dedc706680a335f18
parent 167497fc2e1eff119f787b2fd83f36575ff9b388

Remove TCPPort incoming_only_ member.

TCPPort's incoming_only_ member seems unused and there was a TODO
about this. This CL just removes it.

Bug: webrtc:10198
Change-Id: I216c291159a32fa2924309affa3769a4be116fd0
Reviewed-on: https://webrtc-review.googlesource.com/c/120931
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26538}

p2p/base/tcp_port.cc

diff --git a/p2p/base/tcp_port.cc b/p2p/base/tcp_port.cc
index f98322a..07ca300 100644
--- a/p2p/base/tcp_port.cc
+++ b/p2p/base/tcp_port.cc
@@ -97,7 +97,6 @@
            max_port,
            username,
            password),
-      incoming_only_(false),
       allow_listen_(allow_listen),
       socket_(NULL),
       error_(0) {
@@ -133,10 +132,6 @@
   if (origin == ORIGIN_OTHER_PORT)
     return NULL;
 
-  // Check if we are allowed to make outgoing TCP connections
-  if (incoming_only_ && (origin == ORIGIN_MESSAGE))
-    return NULL;
-
   // We don't know how to act as an ssl server yet
   if ((address.protocol() == SSLTCP_PROTOCOL_NAME) &&
       (origin == ORIGIN_THIS_PORT)) {

p2p/base/tcp_port.h

diff --git a/p2p/base/tcp_port.h b/p2p/base/tcp_port.h
index 67716f7..60c2d04 100644
--- a/p2p/base/tcp_port.h
+++ b/p2p/base/tcp_port.h
@@ -104,8 +104,6 @@
   void OnAddressReady(rtc::AsyncPacketSocket* socket,
                       const rtc::SocketAddress& address);
 
-  // TODO(?): Is this still needed?
-  bool incoming_only_;
   bool allow_listen_;
   rtc::AsyncPacketSocket* socket_;
   int error_;