commit c17bca74109419c567123a75bdef11ea4079383f
author Markus Handell <handellm@webrtc.org> Thu Jan 14 16:08:01 2021
committer Commit Bot <commit-bot@chromium.org> Thu Jan 14 17:46:25 2021
tree de0adae23419db35f8f3f72a659aa8456b0a05b6
parent 16691038330a55088c546a77e837c1116a926188

SetOfferedRtpHeaderExtensions: fix error code.

For the case where an unknown header extension URI is attempted
to be modified by SetOfferedRtpHeaderExtensions, WebRTC emitted
INVALID_PARAMETER. Fix this by emitting UNSUPPORTED_PARAMETER.

Bug: chromium:1051821
Change-Id: I98b68e1e3a3f90f9cfa0d45833f46a307c246ad0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201733
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32983}

pc/rtp_transceiver.cc

diff --git a/pc/rtp_transceiver.cc b/pc/rtp_transceiver.cc
index 9e62f95..d11e04b 100644
--- a/pc/rtp_transceiver.cc
+++ b/pc/rtp_transceiver.cc
@@ -485,7 +485,7 @@
         header_extensions_to_offer_.begin(), header_extensions_to_offer_.end(),
         [&entry](const auto& offered) { return entry.uri == offered.uri; });
     if (it == header_extensions_to_offer_.end()) {
-      return RTCError(RTCErrorType::INVALID_PARAMETER,
+      return RTCError(RTCErrorType::UNSUPPORTED_PARAMETER,
                       "Attempted to modify an unoffered extension.");
     }
 

pc/rtp_transceiver_unittest.cc

diff --git a/pc/rtp_transceiver_unittest.cc b/pc/rtp_transceiver_unittest.cc
index 91e1aa3..7b72620 100644
--- a/pc/rtp_transceiver_unittest.cc
+++ b/pc/rtp_transceiver_unittest.cc
@@ -186,7 +186,7 @@
       {RtpHeaderExtensionCapability("uri3", 1,
                                     RtpTransceiverDirection::kSendRecv)});
   EXPECT_THAT(transceiver_.SetOfferedRtpHeaderExtensions(modified_extensions),
-              Property(&RTCError::type, RTCErrorType::INVALID_PARAMETER));
+              Property(&RTCError::type, RTCErrorType::UNSUPPORTED_PARAMETER));
   EXPECT_EQ(transceiver_.HeaderExtensionsToOffer(), extensions_);
 }