commit c2d8f1e6bc775718a24cdf2f91b3c852f2a1a86b
author Niels Möller <nisse@webrtc.org> Tue Aug 24 13:49:34 2021
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 25 08:39:52 2021
tree 14e4eebdf2bc65bde092ab3d4ee29e408e6fcf7e
parent 2ace42f084f0e2ccd5ac716c5393f661f2a58902

Extract method VirtualSocketServer::AssignBindAddress

Bug: webrtc:13065
Change-Id: Ib8ec14dd193457c010ba6ed943c73cc237bf8bae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229982
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34845}

rtc_base/virtual_socket_server.cc

diff --git a/rtc_base/virtual_socket_server.cc b/rtc_base/virtual_socket_server.cc
index e1ff333..db6f97c 100644
--- a/rtc_base/virtual_socket_server.cc
+++ b/rtc_base/virtual_socket_server.cc
@@ -133,8 +133,8 @@
     error_ = EINVAL;
     return -1;
   }
-  local_addr_ = addr;
-  int result = server_->Bind(this, &local_addr_);
+  local_addr_ = server_->AssignBindAddress(addr);
+  int result = server_->Bind(this, local_addr_);
   if (result != 0) {
     local_addr_.Clear();
     error_ = EADDRINUSE;
@@ -431,8 +431,9 @@
                            const SocketAddress& addr) {
   // If we have not been assigned a local port, then get one.
   if (local_addr_.IsNil()) {
-    local_addr_ = EmptySocketAddressWithFamily(addr.ipaddr().family());
-    int result = server_->Bind(this, &local_addr_);
+    local_addr_ = server_->AssignBindAddress(
+        EmptySocketAddressWithFamily(addr.ipaddr().family()));
+    int result = server_->Bind(this, local_addr_);
     if (result != 0) {
       local_addr_.Clear();
       error_ = EADDRINUSE;
@@ -684,35 +685,35 @@
   return bindings_->insert(entry).second ? 0 : -1;
 }
 
-int VirtualSocketServer::Bind(VirtualSocket* socket, SocketAddress* addr) {
-  RTC_DCHECK(nullptr != socket);
+SocketAddress VirtualSocketServer::AssignBindAddress(
+    const SocketAddress& app_addr) {
+  RTC_DCHECK(!IPIsUnspec(app_addr.ipaddr()));
 
   // Normalize the IP.
-  if (!IPIsUnspec(addr->ipaddr())) {
-    addr->SetIP(addr->ipaddr().Normalized());
-  } else {
-    RTC_NOTREACHED();
-  }
+  SocketAddress addr;
+  addr.SetIP(app_addr.ipaddr().Normalized());
 
   // If the IP appears in `alternative_address_mapping_`, meaning the test has
   // configured sockets bound to this IP to actually use another IP, replace
   // the IP here.
-  auto alternative = alternative_address_mapping_.find(addr->ipaddr());
+  auto alternative = alternative_address_mapping_.find(addr.ipaddr());
   if (alternative != alternative_address_mapping_.end()) {
-    addr->SetIP(alternative->second);
+    addr.SetIP(alternative->second);
   }
 
-  // Assign a port if not assigned.
-  if (addr->port() == 0) {
+  if (app_addr.port() != 0) {
+    addr.SetPort(app_addr.port());
+  } else {
+    // Assign a port.
     for (int i = 0; i < kEphemeralPortCount; ++i) {
-      addr->SetPort(GetNextPort());
-      if (bindings_->find(*addr) == bindings_->end()) {
+      addr.SetPort(GetNextPort());
+      if (bindings_->find(addr) == bindings_->end()) {
         break;
       }
     }
   }
 
-  return Bind(socket, *addr);
+  return addr;
 }
 
 VirtualSocket* VirtualSocketServer::LookupBinding(const SocketAddress& addr) {

rtc_base/virtual_socket_server.h

diff --git a/rtc_base/virtual_socket_server.h b/rtc_base/virtual_socket_server.h
index 009ab42..490511b 100644
--- a/rtc_base/virtual_socket_server.h
+++ b/rtc_base/virtual_socket_server.h
@@ -281,8 +281,9 @@
   // socket server. Intended to be used for test assertions.
   uint32_t sent_packets() const { return sent_packets_; }
 
-  // Binds the given socket to addr, assigning and IP and Port if necessary
-  int Bind(VirtualSocket* socket, SocketAddress* addr);
+  // Assign IP and Port if application's address is unspecified. Also apply
+  // `alternative_address_mapping_`.
+  SocketAddress AssignBindAddress(const SocketAddress& app_addr);
 
   // Binds the given socket to the given (fully-defined) address.
   int Bind(VirtualSocket* socket, const SocketAddress& addr);