Bugfix: Fix declaration order in `ParsedRtcEventLogBuilder` The previous order was reversed, and might lead to crashes if ::Build() wasn't called. Bug: b/423646186 Change-Id: Ie9a167d2785cd0c18e7534812fa05433153dfc5a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/481340 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> Auto-Submit: Rasmus Brandt <brandtr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#47998}
diff --git a/video/timing/simulator/test/parsed_rtc_event_log_builder.cc b/video/timing/simulator/test/parsed_rtc_event_log_builder.cc index 4e23453..ebb9a78 100644 --- a/video/timing/simulator/test/parsed_rtc_event_log_builder.cc +++ b/video/timing/simulator/test/parsed_rtc_event_log_builder.cc
@@ -71,8 +71,8 @@ : log_clock_(Timestamp::Seconds(10000)), log_env_(CreateTestEnvironment( CreateTestEnvironmentOptions{.time = &log_clock_})), - log_(RtcEventLogFactory().Create(log_env_)), - parsed_log_(nullptr) { + parsed_log_(nullptr), + log_(RtcEventLogFactory().Create(log_env_)) { log_->StartLogging(std::make_unique<ParsingRtcEventLogOutput>( [this](std::unique_ptr<ParsedRtcEventLog> parsed_log) { parsed_log_ = std::move(parsed_log);
diff --git a/video/timing/simulator/test/parsed_rtc_event_log_builder.h b/video/timing/simulator/test/parsed_rtc_event_log_builder.h index b54a1de..43e0f1d 100644 --- a/video/timing/simulator/test/parsed_rtc_event_log_builder.h +++ b/video/timing/simulator/test/parsed_rtc_event_log_builder.h
@@ -64,8 +64,8 @@ // the simulation. SimulatedClock log_clock_; const Environment log_env_; - std::unique_ptr<RtcEventLog> log_; std::unique_ptr<ParsedRtcEventLog> parsed_log_; + std::unique_ptr<RtcEventLog> log_; }; } // namespace webrtc::video_timing_simulator