Add thread safety annotations for some more PeerConnection members (part 11)
After reviewer feedback, this CL was reduced to just adding scary
comments on two variables.
Bug: webrtc:9987
Change-Id: Id1e251ffd02e4ca8050235bd9f3971b5363f0e3f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130960
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27431}
diff --git a/pc/peer_connection.h b/pc/peer_connection.h
index 2b28f3f..be31ff0 100644
--- a/pc/peer_connection.h
+++ b/pc/peer_connection.h
@@ -1252,10 +1252,14 @@
absl::optional<bool> is_caller_ RTC_GUARDED_BY(signaling_thread());
// Content name (MID) for media transport data channels in SDP.
- absl::optional<std::string> media_transport_data_mid_;
+ absl::optional<std::string>
+ media_transport_data_mid_; // TODO(bugs.webrtc.org/9987): Accessed on
+ // both signaling and network thread.
// Media transport used for data channels. Thread-safe.
- MediaTransportInterface* media_transport_ = nullptr;
+ MediaTransportInterface* media_transport_ =
+ nullptr; // TODO(bugs.webrtc.org/9987): Object is thread safe, but
+ // pointer accessed on both signaling and network thread.
// Cached value of whether the media transport is ready to send.
bool media_transport_ready_to_send_data_ RTC_GUARDED_BY(signaling_thread()) =