commit db6145f055f197de70d0c4793025eef0a3b1eee9
author Kári Tristan Helgason <kthelgason@webrtc.org> Tue Feb 13 12:58:10 2018
committer Commit Bot <commit-bot@chromium.org> Wed Feb 14 15:29:39 2018
tree f05ff9d89253a1f7b5e39467de66e9dcaa96c3eb
parent 8366e177e7b7b1964ed82c934e6184e268a0ccb9

Fix bug in reporting decode errors in VideoToolbox

The reference back to the decoder class in the decode callback
was null. Due to the amazing properties of ObjC this led to the
setError call to silently fail.

Bug: webrtc:8600
Change-Id: I3f70fbe4c9d533c8612d0bc7bc40813252e492fd
Reviewed-on: https://webrtc-review.googlesource.com/52460
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22021}

sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm

diff --git a/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm b/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm
index 2f4b6bd..e7ce739 100644
--- a/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm
+++ b/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm
@@ -236,7 +236,7 @@
     pixelFormat = nullptr;
   }
   VTDecompressionOutputCallbackRecord record = {
-      decompressionOutputCallback, nullptr,
+      decompressionOutputCallback, (__bridge void *)self,
   };
   OSStatus status = VTDecompressionSessionCreate(
       nullptr, _videoFormat, nullptr, attributes, &record, &_decompressionSession);