Removing some MSVC warning suppression flags.
Bug: webrtc:9251
Change-Id: Idf13b49648459a37fe0a3cac12ff993ce27439d9
Reviewed-on: https://webrtc-review.googlesource.com/84281
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23685}diff --git a/media/BUILD.gn b/media/BUILD.gn
index 562d29b..4b92d14 100644
--- a/media/BUILD.gn
+++ b/media/BUILD.gn
@@ -178,14 +178,6 @@
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
- if (is_win) {
- cflags = [
- "/wd4245", # conversion from "int" to "size_t", signed/unsigned mismatch.
- "/wd4267", # conversion from "size_t" to "int", possible loss of data.
- "/wd4389", # signed/unsigned mismatch.
- ]
- }
-
include_dirs = []
public_configs = []
@@ -262,14 +254,6 @@
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
- if (is_win) {
- cflags = [
- "/wd4245", # conversion from "int" to "size_t", signed/unsigned mismatch.
- "/wd4267", # conversion from "size_t" to "int", possible loss of data.
- "/wd4389", # signed/unsigned mismatch.
- ]
- }
-
if (rtc_enable_intelligibility_enhancer) {
defines += [ "WEBRTC_INTELLIGIBILITY_ENHANCER=1" ]
} else {
@@ -354,14 +338,6 @@
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
- if (is_win) {
- cflags = [
- "/wd4245", # conversion from "int" to "size_t", signed/unsigned mismatch.
- "/wd4267", # conversion from "size_t" to "int", possible loss of data.
- "/wd4389", # signed/unsigned mismatch.
- ]
- }
-
if (rtc_enable_sctp && rtc_build_usrsctp) {
include_dirs = [
# TODO(jiayl): move this into the public_configs of
@@ -549,13 +525,6 @@
defines += [ "WEBRTC_OPUS_SUPPORT_120MS_PTIME=0" ]
}
- if (is_win) {
- cflags = [
- "/wd4245", # conversion from int to size_t, signed/unsigned mismatch.
- "/wd4389", # signed/unsigned mismatch.
- ]
- }
-
if (!build_with_chromium && is_clang) {
suppressed_configs += [
"//build/config/clang:extra_warnings",
diff --git a/modules/audio_coding/BUILD.gn b/modules/audio_coding/BUILD.gn
index 1dd3939..fb587c5 100644
--- a/modules/audio_coding/BUILD.gn
+++ b/modules/audio_coding/BUILD.gn
@@ -128,13 +128,6 @@
]
}
- if (is_win) {
- cflags = [
- # TODO(kjellander): Bug 261: fix this warning.
- "/wd4373", # virtual function override.
- ]
- }
-
deps = audio_coding_deps + [
"../../api/audio:audio_frame_api",
"..:module_api",
@@ -1433,12 +1426,6 @@
"//third_party/abseil-cpp/absl/types:optional",
]
defines = audio_coding_defines
- if (is_win) {
- cflags = [
- # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
- "/wd4373", # virtual function override.
- ]
- }
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -1632,13 +1619,6 @@
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
- if (is_win) {
- cflags = [
- # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
- "/wd4373", # virtual function override.
- ]
- }
-
deps += [
":neteq",
":neteq_test_tools",
@@ -1980,13 +1960,6 @@
data = [
"../../resources/speech_and_misc_wb.pcm",
]
-
- if (is_win) {
- cflags = [
- # Disable warnings to enable Win64 build, issue 1323.
- "/wd4267", # size_t to int truncation
- ]
- }
}
rtc_source_set("isac_test_util") {
diff --git a/modules/remote_bitrate_estimator/BUILD.gn b/modules/remote_bitrate_estimator/BUILD.gn
index b157f3d..7362e7f 100644
--- a/modules/remote_bitrate_estimator/BUILD.gn
+++ b/modules/remote_bitrate_estimator/BUILD.gn
@@ -218,12 +218,6 @@
"../pacing:pacing",
"../rtp_rtcp:rtp_rtcp_format",
]
- if (is_win) {
- cflags = [
- # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
- "/wd4373", # virtual function override.
- ]
- }
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -255,12 +249,5 @@
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
-
- if (is_win) {
- cflags = [
- # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
- "/wd4373", # virtual function override.
- ]
- }
}
}
diff --git a/pc/BUILD.gn b/pc/BUILD.gn
index 405c2a5..5509a0c 100644
--- a/pc/BUILD.gn
+++ b/pc/BUILD.gn
@@ -476,13 +476,6 @@
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
- if (is_win) {
- cflags = [
- "/wd4245", # conversion from int to size_t, signed/unsigned mismatch.
- "/wd4389", # signed/unsigned mismatch.
- ]
- }
-
deps = [
":peerconnection",
":rtc_pc_base",
diff --git a/sdk/android/BUILD.gn b/sdk/android/BUILD.gn
index 58d692e..9522785 100644
--- a/sdk/android/BUILD.gn
+++ b/sdk/android/BUILD.gn
@@ -336,13 +336,6 @@
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
- if (is_win) {
- cflags += [
- "/wd4245", # conversion from "int" to "size_t", signed/unsigned mismatch.
- "/wd4389", # signed/unsigned mismatch.
- ]
- }
-
if (rtc_use_builtin_sw_codecs) {
sources += [
"src/jni/androidmediacodeccommon.h",
@@ -564,13 +557,6 @@
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
- if (is_win) {
- cflags += [
- "/wd4245", # conversion from "int" to "size_t", signed/unsigned mismatch.
- "/wd4389", # signed/unsigned mismatch.
- ]
- }
-
deps = [
":base_jni",
":generated_external_classes_jni",
